1225225 - Incorrect pref type and name used ImageBlockingPolicy

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Nick Alexander :nalexander [he/him]]

11-16 11:03:29.860  28735-28771/org.mozilla.fennec_nalexander E/GeckoConsole﹕ [JavaScript Error: "NS_ERROR_UNEXPECTED: Component returned failure code: 0x8000ffff (NS_ERROR_UNEXPECTED) [nsIPrefBranch.getBoolPref]" {file: "jar:jar:file:///data/app/org.mozilla.fennec_nalexander-1.apk!/assets/omni.ja!/components/ImageBlockingPolicy.js" line: 106}]

The underlying code looks confused: there are multiple references to "browser.image_blocking.enabled", which looks wrong.  See https://dxr.mozilla.org/mozilla-central/search?q=image_blocking&case=true.

Comment 1

[Jonathan Almeida [:jonalmeida]]

You're right, the issue is the wrong pref value which removed .enabled.

Comment 2

[Jonathan Almeida [:jonalmeida]]

My telemetry patch overwrote the new pref value in ImageBlockingPolicy.js.

Should be a simple fix; will do it now.

Comment 3

[Jonathan Almeida [:jonalmeida]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=4e0479e8e1b3

Comment 4

[Jonathan Almeida [:jonalmeida]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f6c08b66bc6c

Comment 5

[Jonathan Almeida [:jonalmeida]]

Attachment: MozReview Request: Bug 1225225 - Incorrect pref type and name used ImageBlockingPolicy r?mfinkle

Bug 1225225 - Incorrect pref type and name used ImageBlockingPolicy r?mfinkle

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 8688082 [details]
MozReview Request: Bug 1225225 - Incorrect pref type and name used ImageBlockingPolicy r?mfinkle

https://reviewboard.mozilla.org/r/25277/#review22773

::: mobile/android/components/ImageBlockingPolicy.js:23
(Diff revision 1)
> -const PREF_IMAGEBLOCKING_ENABLED = "browser.image_blocking.enabled";
> +const PREF_IMAGEBLOCKING_ENABLED = "browser.image_blocking";

PREF_IMAGEBLOCKING_ENABLED -> PREF_IMAGEBLOCKING

::: mobile/android/components/ImageBlockingPolicy.js:95
(Diff revision 1)
>      return Services.prefs.getIntPref("browser.image_blocking");

Use the constant here

::: mobile/android/components/ImageBlockingPolicy.js:100
(Diff revision 1)
>        Services.telemetry.getHistogramById(TELEMETRY_TAP_TO_LOAD_ENABLED).add(getEnabled());

Use this.\_enabled() here

::: mobile/android/components/ImageBlockingPolicy.js:105
(Diff revision 1)
>  function getEnabled() {

Remove this method

Comment 7

[Jonathan Almeida [:jonalmeida]]

Comment on attachment 8688082 [details]
MozReview Request: Bug 1225225 - Incorrect pref type and name used ImageBlockingPolicy r?mfinkle

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/25277/diff/1-2/

Comment 8

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 8688082 [details]
MozReview Request: Bug 1225225 - Incorrect pref type and name used ImageBlockingPolicy r?mfinkle

https://reviewboard.mozilla.org/r/25277/#review22785

LGTM

Comment 9

[Jonathan Almeida [:jonalmeida]]

https://hg.mozilla.org/integration/fx-team/rev/2feb5677ea5cedb035700076148065deb08fb3aa
Bug 1225225 - Incorrect pref type and name used ImageBlockingPolicy r=mfinkle

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/2feb5677ea5c