1225327 - Crash [@ mozilla::dom::MediaRecorder::Session::SizeOfExcludingThis]

Status: RESOLVED FIXED

(Core :: Audio/Video: Recording, defect)

Description

[Jesse Ruderman]

Attachment: testcase

1. Load the testcase
2. In another tab, go to about:memory and click "Measure"

Crash [@ mozilla::dom::MediaRecorder::Session::SizeOfExcludingThis]

Comment 1

[Jesse Ruderman]

Attachment: stack

Comment 2

[Benjamin Chen [:bechen]]

Apparently the |mEncoder| is null because the |TracksAvailableCallback| doesn't be called since there is no data comes from MediaSource.

Comment 3

[Benjamin Chen [:bechen]]

Attachment: MozReview Request: Bug 1225327 - fix |mEncoder| null-dereference. r=jwwang

Bug 1225327 - fix |mEncoder| null-dereference. r?jwwang

Comment 4

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8692406 [details]
MozReview Request: Bug 1225327 - fix |mEncoder| null-dereference. r=jwwang

https://reviewboard.mozilla.org/r/26259/#review23681

Comment 5

[Benjamin Chen [:bechen]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a9829be12268

Comment 6

[Benjamin Chen [:bechen]]

Comment on attachment 8692406 [details]
MozReview Request: Bug 1225327 - fix |mEncoder| null-dereference. r=jwwang

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/26259/diff/1-2/

Comment 7

[Benjamin Chen [:bechen]]

Comment on attachment 8692406 [details]
MozReview Request: Bug 1225327 - fix |mEncoder| null-dereference. r=jwwang

https://reviewboard.mozilla.org/r/26259/#review23875

Comment 8

[Benjamin Chen [:bechen]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=6ec2ceca95ce

Comment 9

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6c6377eee8da

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/6c6377eee8da