1225424 - [Video]When adding a attachment from video app at Message, the button an the bottom of the prompt page is blank.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Video, defect)

Description

[helen（leave from Mozilla）]

[1.Description]:
[Aries v2.6]&[Flamev2.6][Video]When user tries to add an video attachment from in Message or Email app, the button at the bottom of "Add video to get started" prompt page is blank.

Occur Time: 16:20
Attachment: logcat1620.txt &Aries KK v2.6.png

[2.Testing Steps]: 
Precondition: There is no vedio at Video app.
1.Launch Message app.
2.Tap edit icon to create a new message.
3. Try to add a Video attachment.

[3.Expected Result]: 
3.There is "Cancel" at the bottom of the notification page.

[4.Actual Result]: 
3.The button at the bottom of the notification page is blank.

[5.Reproduction build]: 
Device: Aries KK v2.5(Unaffected)
Build ID               20151116174534
Gaia Revision          9473dbcbebf4e758a3b73200968efc69071b4312
Gaia Date              2015-11-16 15:49:25
Gecko Revision         http://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/17877d161e5f62726027ee70101a7004dcad5a69
Gecko Version          44.0a2
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151116.165317
Firmware Date          Mon Nov 16 16:53:25 UTC 2015
Bootloader             s1

Device: Flame KK v2.5  512mb(Unaffected)
Build ID               20151116173604
Gaia Revision          9473dbcbebf4e758a3b73200968efc69071b4312
Gaia Date              2015-11-16 15:49:25
Gecko Revision         http://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/17877d161e5f62726027ee70101a7004dcad5a69
Gecko Version          44.0a2
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151116.164743
Firmware Date          Mon Nov 16 16:47:52 UTC 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Device: Aries KK v2.6 master(Affected)
Build ID               20151112120735
Gaia Revision          27bc9412ca607648bc398b25bb1ae25653b2b278
Gaia Date              2015-11-12 02:27:47
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/3cc3b1968524248450c465c4ea2ee5596ffa65f2
Gecko Version          45.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151112.112635
Firmware Date          Thu Nov 12 11:26:43 UTC 2015
Bootloader             s1

Device: Flame KK v2.6 master 512mb(Aaffected)
Build ID               20151116150206
Gaia Revision          e8c15ae4e5324a210000ee0a869a962aa542009f
Gaia Date              2015-11-13 00:10:48
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/d1cae7deae1ac0aa4c2a4b1aca1f3b6966fa58b4
Gecko Version          45.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151116.203255
Firmware Date          Mon Nov 16 20:33:07 EST 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

[6.Reproduction Frequency]: 
Always Recurrence,5/5

[7.TCID]: 
Free Test

[8.Note]:
This bug can also appears in Email app when add attachment from Video app.

Comment 1

[helen（leave from Mozilla）]

Attachment: logcat1620.txt

Comment 2

[helen（leave from Mozilla）]

Attachment: Aries KK v2.6.png

Comment 3

[helen（leave from Mozilla）]

Hi Kevin,
This bug is probably caused by bug 1223675, could you please help to have a look? Thanks!

B2g-inbound Regression Window:

Last Working Environmental Variables:
Device: Flame KK v2.6 512mb(master):
Build ID               20151111175747
Gaia Revision          fcd12012362cffc4f4ce8aa6e184a94182cba54c
Gaia Date              2015-11-12 01:19:08
Gecko Revision         https://hg.mozilla.org/integration/b2g-inbound/rev/e145441cba85619aa3781a70121b111247e919b0
Gecko Version          45.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151112.183236
Firmware Date          Thu Nov 12 18:32:49 EST 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

First Broken Environmental Variables:
Device: Flame KK v2.6 512mb(master):
Build ID               20151111184647
Gaia Revision          98f63d4cc530906fa51d839a10469006c257b998
Gaia Date              2015-11-12 02:03:26
Gecko Revision         https://hg.mozilla.org/integration/b2g-inbound/rev/ac1e84c1fa3e9fb083ced8489939a0a40ab79a2f
Gecko Version          45.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151112.183236
Firmware Date          Thu Nov 12 18:32:49 EST 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

First Broken Gaia & Last Working Gecko - issue DOES repro
Gaia Revision          98f63d4cc530906fa51d839a10469006c257b998
Gecko Revision         https://hg.mozilla.org/integration/b2g-inbound/rev/e145441cba85619aa3781a70121b111247e919b0

First Broken Gecko & Last Working Gaia - issue DOES NOT repro
Gaia Revision          fcd12012362cffc4f4ce8aa6e184a94182cba54c
Gecko Revision         https://hg.mozilla.org/integration/b2g-inbound/rev/ac1e84c1fa3e9fb083ced8489939a0a40ab79a2f

Gaia pushlog:
https://github.com/mozilla-b2g/gaia/compare/fcd12012362cffc4f4ce8aa6e184a94182cba54c...98f63d4cc530906fa51d839a10469006c257b998

Comment 4

[Kevin Grandon :kgrandon]

Oops, there was a usage of the overlay-cancel-button string that I missed. This is only missing from master, so restoring it should fix it. Sorry about that.

Comment 5

[GitHub Autolander Bot]

Attachment: [gaia] KevinGrandon:bug_1225424_video_cancel_missing_string > mozilla-b2g:master

Comment 6

[Kevin Grandon :kgrandon]

Comment on attachment 8690461 [details] [review]
[gaia] KevinGrandon:bug_1225424_video_cancel_missing_string > mozilla-b2g:master

This is only a partial backout of bug 1223675, so R=me.

Comment 7

[Kevin Grandon :kgrandon]

In master: https://github.com/mozilla-b2g/gaia/commit/663031be0c768ad00c2e0796d98ffd9dfc2a4759

Comment 8

[helen（leave from Mozilla）]

This bug has been verified as "pass" on latest build of Flame KK master & and Aries KK master by the STR in Comment 0.

Results: 
When user tries to add an video attachment from in Message or Email app, there is "Cancel" at the bottom of the notification page.

Reproduce rate: 0/10

Device: Aries KK master( Pass )
Build ID               20151124014704
Gaia Revision          ea673b5c4cc19c3daca072691a659c68e4c6937f
Gaia Date              2015-11-23 16:41:08
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/19d89caa664dd9309c796929225ee409df5d1ee4
Gecko Version          45.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151124.005529
Firmware Date          Tue Nov 24 00:55:36 UTC 2015
Bootloader             s1

Device: Flame KK master 512mb( Pass )
Build ID               20151123030230
Gaia Revision          bae13c9ac6a91beecd7c94384e2aef25ed1a3214
Gaia Date              2015-11-23 04:08:40
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/8b1fc0961a076e35646d0472a81feefc0074558c
Gecko Version          45.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151123.064256
Firmware Date          Mon Nov 23 06:43:08 EST 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0