1225425 - [Testcase] Do not unregister the AudioChannelAgent during seeking

Status: RESOLVED FIXED

(Firefox OS Graveyard :: AudioChannel, defect)

Description

[Alastor Wu [:alwu]]

When we seek the MediaElement, its AudioChannelAgent shouldn't be unregistered.

That is because we don't want the previous interrupted audio (if exists) is resumed during seeking the MediaElement. ex. bug1198165.

Comment 1

[Alastor Wu [:alwu]]

Hi, Baku,
Do we have similar test case for this situation?
Thanks!

Comment 2

[Andrea Marchesini [:baku]]

No test for it as far as I can see from bug 1048171.

Comment 3

[Alastor Wu [:alwu]]

Attachment: MozReview Request: Bug 1225425 - [Testcase] Do not unregister the AudioChannelAgent during seeking. r=baku.

Review commit: https://reviewboard.mozilla.org/r/29061/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/29061/

Comment 4

[Alastor Wu [:alwu]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b3481b974e30

Comment 5

[Alastor Wu [:alwu]]

Comment on attachment 8701994 [details]
MozReview Request: Bug 1225425 - [Testcase] Do not unregister the AudioChannelAgent during seeking. r=baku.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/29061/diff/1-2/

Comment 6

[Andrea Marchesini [:baku]]

Comment on attachment 8701994 [details]
MozReview Request: Bug 1225425 - [Testcase] Do not unregister the AudioChannelAgent during seeking. r=baku.

https://reviewboard.mozilla.org/r/29061/#review26341

Comment 7

[Alastor Wu [:alwu]]

Comment on attachment 8701994 [details]
MozReview Request: Bug 1225425 - [Testcase] Do not unregister the AudioChannelAgent during seeking. r=baku.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/29061/diff/1-2/

Comment 8

[Alastor Wu [:alwu]]

Rebase.

Comment 9

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/fc20ecea0409

Comment 10

[Nigel Babu [:nigelb]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/31c319b09ec07c21f7fe164aab728391cf6b8f38
Backed out changeset fc20ecea0409 (bug 1225425) for failing its own tests

Comment 11

[Nigel Babu [:nigelb]]

Busted M(1) across most platforms other than b2g-related ones like this:

https://treeherder.mozilla.org/logviewer.html#?job_id=19415137&repo=mozilla-inbound

Comment 12

[Alastor Wu [:alwu]]

Comment on attachment 8701994 [details]
MozReview Request: Bug 1225425 - [Testcase] Do not unregister the AudioChannelAgent during seeking. r=baku.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/29061/diff/2-3/

Comment 13

[Alastor Wu [:alwu]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=4c8f2997a4e3

Comment 14

[Alastor Wu [:alwu]]

Comment on attachment 8701994 [details]
MozReview Request: Bug 1225425 - [Testcase] Do not unregister the AudioChannelAgent during seeking. r=baku.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/29061/diff/3-4/

Comment 15

[Alastor Wu [:alwu]]

In following try-server result, this patch can pass most of tests, except some test case fails.
However, these orange lights are also seen in other people's try. 
I think that might not be caused by my patch.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=24f349ade22a&selectedJob=15215247

Comment 16

[Alastor Wu [:alwu]]

Comment on attachment 8701994 [details]
MozReview Request: Bug 1225425 - [Testcase] Do not unregister the AudioChannelAgent during seeking. r=baku.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/29061/diff/4-5/

Comment 17

[Pulsebot]

https://hg.mozilla.org/integration/b2g-inbound/rev/783fc5968e65

Comment 18

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/783fc5968e65