[Testcase] Do not unregister the AudioChannelAgent during seeking

RESOLVED FIXED

Status

defect
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: alwu, Assigned: alwu)

Tracking

unspecified
ARM
Gonk (Firefox OS)
Dependency tree / graph

Firefox Tracking Flags

(firefox46 fixed)

Details

Attachments

(1 attachment)

When we seek the MediaElement, its AudioChannelAgent shouldn't be unregistered.

That is because we don't want the previous interrupted audio (if exists) is resumed during seeking the MediaElement. ex. bug1198165.
Hi, Baku,
Do we have similar test case for this situation?
Thanks!
Flags: needinfo?(amarchesini)
No test for it as far as I can see from bug 1048171.
Flags: needinfo?(amarchesini)
Comment on attachment 8701994 [details]
MozReview Request: Bug 1225425 - [Testcase] Do not unregister the AudioChannelAgent during seeking. r=baku.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/29061/diff/1-2/
Attachment #8701994 - Flags: review?(amarchesini)
Attachment #8701994 - Flags: review?(amarchesini) → review+
Comment on attachment 8701994 [details]
MozReview Request: Bug 1225425 - [Testcase] Do not unregister the AudioChannelAgent during seeking. r=baku.

https://reviewboard.mozilla.org/r/29061/#review26341
Comment on attachment 8701994 [details]
MozReview Request: Bug 1225425 - [Testcase] Do not unregister the AudioChannelAgent during seeking. r=baku.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/29061/diff/1-2/
Attachment #8701994 - Attachment description: MozReview Request: Bug 1225425 - [Testcase] Do not unregister the AudioChannelAgent during seeking. → MozReview Request: Bug 1225425 - [Testcase] Do not unregister the AudioChannelAgent during seeking. r=baku.
Rebase.
Keywords: checkin-needed
Busted M(1) across most platforms other than b2g-related ones like this:

https://treeherder.mozilla.org/logviewer.html#?job_id=19415137&repo=mozilla-inbound
Comment on attachment 8701994 [details]
MozReview Request: Bug 1225425 - [Testcase] Do not unregister the AudioChannelAgent during seeking. r=baku.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/29061/diff/2-3/
Comment on attachment 8701994 [details]
MozReview Request: Bug 1225425 - [Testcase] Do not unregister the AudioChannelAgent during seeking. r=baku.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/29061/diff/3-4/
In following try-server result, this patch can pass most of tests, except some test case fails.
However, these orange lights are also seen in other people's try. 
I think that might not be caused by my patch.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=24f349ade22a&selectedJob=15215247
Keywords: checkin-needed
Comment on attachment 8701994 [details]
MozReview Request: Bug 1225425 - [Testcase] Do not unregister the AudioChannelAgent during seeking. r=baku.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/29061/diff/4-5/
https://hg.mozilla.org/mozilla-central/rev/783fc5968e65
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.