1225437 - [gui] allow to choose a release or buildid instead of a date

Status: RESOLVED FIXED

(Testing :: mozregression, defect)

Description

[Julien Pagès (:parkouss)]

In the nightlies wizard page, we only allow for raw date.

We should add support for selection using the release number or a buildid.

Comment 1

[Julien Pagès (:parkouss)]

Attachment: add release and buildid selection

mikeling, could you test and review this ? From what I tested it looks good.

Thanks :)

Comment 2

[MikeLing]

Sure! I would happy to  :)

But when I use "20120913042009"(I found this value on this wiki page(https://wiki.mozilla.org/MozillaQualityAssurance:Build_Ids)) to test buildid choose, it tells me incorrect date format. Could you give me some example to tests it? 

BTW, could we make it label changed with the dropdown item(eg. when we choose buildid, it will changed to "First good buildid" and "Last bad buildid")

Comment 3

[Julien Pagès (:parkouss)]

(In reply to MikeLing from comment #2)
> Sure! I would happy to  :)

:)

> But when I use "20120913042009"(I found this value on this wiki
> page(https://wiki.mozilla.org/MozillaQualityAssurance:Build_Ids)) to test
> buildid choose, it tells me incorrect date format. Could you give me some
> example to tests it? 

Hm, 20120913042009 works for me (without the quotes). You have to keep in mind that build ids are date (and time). In the one you given:

2012   09   13  04   20      09
year month day hour minute second

So, just be sure the other date you give respect the required date order (first, latest). (maybe that was the issue ?)

> BTW, could we make it label changed with the dropdown item(eg. when we
> choose buildid, it will changed to "First good buildid" and "Last bad
> buildid")

Sure, sounds good! Do you want to work on this after this bug ? I believe there are some things that can definitely be improved around that, like the error messages also. For now, I would like to have something working first.

Comment 4

[MikeLing]

Attachment: Screen Shot 2015-10-31 at 11.47.03 AM.png

Yeah, I'm ok to work on that feature :)

You can see the 20120913042009 still doesn't work for me :(

Comment 5

[Julien Pagès (:parkouss)]

lol, this is a treeherder screenshot. :) BTW I'm on irc, we can talk about that.

Comment 6

[MikeLing]

Comment on attachment 8688393 [details] [review]
add release and buildid selection

I gone to r+ this PR :) Thank you for your trust!

Comment 7

[Julien Pagès (:parkouss)]

(In reply to MikeLing from comment #6)
> Comment on attachment 8688393 [details] [review]
> add release and buildid selection
> 
> I gone to r+ this PR :) Thank you for your trust!

Eh, thank you. :)

As discussed on irc, I fixed the error message for a bad buildid - I was a bit lazy and only focused on make this working, but reporting understandable errors is something important, so thanks for notifying this.

Merged in https://github.com/mozilla/mozregression/commit/14591fe9621420a950298593ba514fd48e26e278