1225519 - Permission in Page info should say "Send notifications" instead of "Receive notifications"

Status: RESOLVED FIXED

(Firefox :: Page Info Window, defect, P3)

Description

[Francesco Lodolo [:flod] (limited availability until Dec 11)]

https://hg.mozilla.org/mozilla-central/file/f8b569906e4c/browser/locales/en-US/chrome/browser/sitePermissions.properties#l11

permission.desktop-notification2.label = Receive Notifications

Should be "Send Notifications"

Comment 1

[BMO Automation]

Per policy at https://wiki.mozilla.org/Bug_Triage/Projects/Bug_Handling/Bug_Husbandry#Inactive_Bugs. If this bug is not an enhancement request or a bug not present in a supported release of Firefox, then it may be reopened.

Comment 2

[Manish [:manishkk]]

Attachment: Patch_Bug1225519

Please review.

Comment 3

[Francesco Lodolo [:flod] (limited availability until Dec 11)]

Needinfo is to ask for information. In this case, you're attaching a patch, so you can set the review flag to Johann.

Having said that: you're changing an existing string, which means you need to use a new ID in the .properties file, and update the code to reference it (potentially look for tests too).
https://developer.mozilla.org/en-US/docs/Mozilla/Localization/Localization_content_best_practices#Changing_existing_strings

Comment 4

[Manish [:manishkk]]

How can I test this code?

'./mach mochitest'

Comment 5

[Johann Hofmann [:johannh]]

(In reply to Manish Kumar [:manishkk] from comment #4)
> How can I test this code?
> 
> './mach mochitest'

Since you're only updating copy I'm not sure you really need to test it. If you'd like to test a bit of UI that is affected by this locally, you can run

./mach mochitest browser/base/content/test/permissions

or

./mach mochitest browser/base/content/test/pageinfo

You can also do a try run (https://wiki.mozilla.org/ReleaseEngineering/TryServer). Do you have try access? If not, I'm happy to vouch for you.

I'd personally recommend just going to https://permission.site/, accepting the notification prompt and checking the updated label in the identity popup.

Comment 6

[Manish [:manishkk]]

Thanks, you already vouch for me.

Comment 7

[Francesco Lodolo [:flod] (limited availability until Dec 11)]

@manish
Were you able to make any progress with this bug?

Comment 8

[Manish [:manishkk]]

:johannh

After the changes: 

This fails this test:

./mach mochitest browser/base/content/test/permissions

https://pastebin.mozilla.org/9092694

Comment 9

[:Lina Cambridge]

Hi Manish! Did you update https://searchfox.org/mozilla-central/rev/c3fef66a5b211ea8038c1c132706d02db408093a/browser/modules/SitePermissions.jsm#757 with the new string ID, too?

Comment 10

[Manish [:manishkk]]

Attachment: Patch_Bug1225519

Yes! I updated string ID also.

Please check patch!

Comment 11

[:Lina Cambridge]

Comment on attachment 9006098 [details] [diff] [review]
Patch_Bug1225519

LGTM, but I've triggered a Try run just in case. :-) Thanks, Manish! https://treeherder.mozilla.org/#/jobs?repo=try&revision=e32357def06b6ddb7f45d46006a06a503c69f020

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/10da2f00e15d
Permission in Page info should say Send notifications instead of Receive notifications r=lina

Comment 13

[Tiberius Oros[:tiberius_oros]]

https://hg.mozilla.org/mozilla-central/rev/10da2f00e15d

Comment 14

[Mohammad Maruf Rahman]

I have reproduced this bug with Nightly 45.0a1 (2015-11-18) on Windows 10, 64 Bit!
This bug's fix is verified with latest Nightly!

Build ID   - 20180910220142
User Agent - Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:64.0) Gecko/20100101 Firefox/64