Closed Bug 1225519 Opened 4 years ago Closed Last year

Permission in Page info should say "Send notifications" instead of "Receive notifications"


(Firefox :: Page Info Window, defect, P3)




Firefox 64
Tracking Status
firefox64 --- fixed


(Reporter: flod, Assigned: manishkk, Mentored)



(Keywords: good-first-bug)


(1 file, 1 obsolete file)

Resolution: INACTIVE → ---
Mentor: jhofmann
Keywords: good-first-bug
Priority: -- → P3
Assignee: nobody → 1991manish.kumar
Attached patch Patch_Bug1225519 (obsolete) — Splinter Review
Please review.
Flags: needinfo?(jhofmann)
Needinfo is to ask for information. In this case, you're attaching a patch, so you can set the review flag to Johann.

Having said that: you're changing an existing string, which means you need to use a new ID in the .properties file, and update the code to reference it (potentially look for tests too).
Flags: needinfo?(jhofmann)
How can I test this code?

'./mach mochitest'
Flags: needinfo?(jhofmann)
(In reply to Manish Kumar [:manishkk] from comment #4)
> How can I test this code?
> './mach mochitest'

Since you're only updating copy I'm not sure you really need to test it. If you'd like to test a bit of UI that is affected by this locally, you can run

./mach mochitest browser/base/content/test/permissions


./mach mochitest browser/base/content/test/pageinfo

You can also do a try run ( Do you have try access? If not, I'm happy to vouch for you.

I'd personally recommend just going to, accepting the notification prompt and checking the updated label in the identity popup.
Flags: needinfo?(jhofmann)
Thanks, you already vouch for me.
Were you able to make any progress with this bug?
Flags: needinfo?(1991manish.kumar)

After the changes: 

This fails this test:

./mach mochitest browser/base/content/test/permissions
Flags: needinfo?(1991manish.kumar) → needinfo?(francesco.lodolo)
Hi Manish! Did you update with the new string ID, too?
Flags: needinfo?(francesco.lodolo) → needinfo?(1991manish.kumar)
Attached patch Patch_Bug1225519Splinter Review
Yes! I updated string ID also.

Please check patch!
Attachment #8986942 - Attachment is obsolete: true
Flags: needinfo?(1991manish.kumar)
Attachment #9006098 - Flags: review?(lina)
Comment on attachment 9006098 [details] [diff] [review]

LGTM, but I've triggered a Try run just in case. :-) Thanks, Manish!
Attachment #9006098 - Flags: review?(lina) → review+
Keywords: checkin-needed
Pushed by
Permission in Page info should say Send notifications instead of Receive notifications r=lina
Keywords: checkin-needed
Closed: 2 years agoLast year
Resolution: --- → FIXED
Target Milestone: --- → Firefox 64
I have reproduced this bug with Nightly 45.0a1 (2015-11-18) on Windows 10, 64 Bit!
This bug's fix is verified with latest Nightly!

Build ID   - 20180910220142
User Agent - Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:64.0) Gecko/20100101 Firefox/64
QA Whiteboard: [bugday-20180905]
You need to log in before you can comment on or make changes to this bug.