1225566 - Slow scrolling with keyboard on PRIV by BlackBerry

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Toolbar, defect)

Description

[Liam Quinn]

User Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:42.0) Gecko/20100101 Firefox/42.0
Build ID: 20151029151421
Firefox for Android

Steps to reproduce:

1. Using Firefox on a PRIV by BlackBerry, load any Web page that allows scrolling. I tested with http://www.bbc.com/news.
2. Open the slider.
3. Scroll vertically using the touch-sensitive keyboard.


Actual results:

Scrolling is very slow.


Expected results:

It should be faster, more like Chrome 46.

Comment 1

[Andy Chen]

Attachment: For pointer scrolling, we need to match Android platform behavior, to

use the provided deltas, scaled by the preferred list item height.

Comment 2

[Andy Chen]

Attachment: For pointer scrolling, we need to match Android platform behavior, to

use the provided deltas, scaled by the preferred list item height.

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8688582 [details] [diff] [review]
For pointer scrolling, we need to match Android platform behavior, to

Review of attachment 8688582 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks!

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/c3dcefaff798

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c3dcefaff798

Comment 6

[Liam Quinn]

Is it possible to target Firefox 43 or 44 for this? The fix should be low risk, and it's a significant issue for Firefox users on the PRIV by BlackBerry.

(Thanks for taking the fix!)

Comment 7

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8688582 [details] [diff] [review]
For pointer scrolling, we need to match Android platform behavior, to

Approval Request Comment
[Feature/regressing bug #]: it's been this way for a long time, but only exposed recently on new devices (i.e. BlackBerry PRIV)
[User impact if declined]: scrolling Fennec on the PRIV is very slow
[Describe test coverage new/current, TreeHerder]: not really
[Risks and why]: very low risk; the change just updates the scroll amount per event for "pointer" input sources (which already isn't used on most devices). Touch interaction is not affected.
[String/UUID change made/needed]: none

Comment 8

[Liz Henry (:lizzard) (relman/hg->git project)]

Do we have one of these to test with? 
Kevin mentioned some risk of regression for the asus transformer pad. 
To me this sounds like support for a new feature/device without much testing. I am not sure about uplifting the fixes for Blackberry to beta.   Kats, what do you think about trying aurora instead and aiming for 44 release?

Comment 9

[Kartikaya Gupta (email:[e-mail])]

(In reply to Liz Henry (:lizzard) (needinfo? me) from comment #8)
> Do we have one of these to test with? 

I don't. I'm assuming Liam and Andy tested that the patch works on BlackBerry before they put it up, (and looking at the patch I can see why it would).

> Kevin mentioned some risk of regression for the asus transformer pad.

Technically there is some risk but I don't think it's particularly risky. If we can get somebody to verify it didn't regress on the transformer that would be good.

> To me this sounds like support for a new feature/device without much
> testing. I am not sure about uplifting the fixes for Blackberry to beta.  
> Kats, what do you think about trying aurora instead and aiming for 44
> release?

I'm happy uplifting to aurora now and reconsidering beta if we can get somebody to verify on the transformer. I feel like it would be nice to support the device because if we have users migrating from other Android devices to the blackberry they will have a degraded experience and so we might lose them to Chrome or something. It's your call though.

Comment 10

[Liz Henry (:lizzard) (relman/hg->git project)]

Margaret, what do you think? It would be nice to support this new device. HOw fast do you think it's reasonable to go here?

Comment 11

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Liam, would you be able to verify that this issue is fixed as expected on the latest Nightly build (11/19)? Thanks!

Comment 12

[:Margaret Leibovic]

(In reply to Liz Henry (:lizzard) (needinfo? me) from comment #10)
> Margaret, what do you think? It would be nice to support this new device.
> HOw fast do you think it's reasonable to go here?

This looks like a pretty simple patch. As long as this doesn't regress other devices, I think it's fine to uplift it to beta.

Comment 13

[Liam Quinn]

I tested the latest nightly (2015-11-20) on PRIV by BlackBerry, and it's working great. The scrolling feels much improved from Firefox Beta 43.0b4.

Comment 14

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

(In reply to Liam Quinn from comment #13)
> I tested the latest nightly (2015-11-20) on PRIV by BlackBerry, and it's
> working great. The scrolling feels much improved from Firefox Beta 43.0b4.

Thanks for a such a prompt follow up! This is highly appreciated.

Comment 15

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Ioana, would you be able to do some manual testing on this patch (on latest Nightly build) on our most commonly tested/supported Fennec devices to address Margaret's concern in comment 12? Thanks!

Comment 16

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8688582 [details] [diff] [review]
For pointer scrolling, we need to match Android platform behavior, to

Sounds good, let's fix this for aurora and beta, and count on next week to uncover possible (even if unlikely) regressions.

Comment 17

[Kartikaya Gupta (email:[e-mail])]

Thanks all!

https://hg.mozilla.org/releases/mozilla-aurora/rev/0b9508fe071f
https://hg.mozilla.org/releases/mozilla-beta/rev/6f9a27ecae60

Comment 18

[Ioana Chiorean]

(In reply to Ritu Kothari (:ritu) from comment #15)
> Ioana, would you be able to do some manual testing on this patch (on latest
> Nightly build) on our most commonly tested/supported Fennec devices to
> address Margaret's concern in comment 12? Thanks!

Yes! We will cover this.

Comment 19

[Kevin Brosnan [Ex-Mozilla]]

I doubt that testing will reveal anything interesting unless we have something with a secondary touch input. My concern is devices such as the Asus Transformer attachment and older Android devices with scroll-balls or touchpads.

Comment 20

[Ioana Chiorean]

Ritu, I just realized that we actually have no Blackberry with Android in the office. I can try to find a contributor or a friend with one to help out if there is none in the office either.