1225717 - Make TakeOwnershipOfErrorReporting() actually work on workers

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Boris Zbarsky [:bzbarsky]]

Splitting this out of bug 1072144.  It's a prerequisite for that, of course.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Make AutoJSAPI::TakeOwnershipOfErrorReporting actually work on workers as long as no one calls JS_ReportPendingException manually

This is slightly spruced up from attachment 8534373 [details] [diff] [review] with better comments and an mIsMainThread member

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 8689086 [details] [diff] [review]
Make AutoJSAPI::TakeOwnershipOfErrorReporting actually work on workers as long as no one calls JS_ReportPendingException manually

Review of attachment 8689086 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/base/ScriptSettings.cpp
@@ +482,5 @@
>    JSRuntime *rt = JS_GetRuntime(cx());
>    mOldAutoJSAPIOwnsErrorReporting = JS::ContextOptionsRef(cx()).autoJSAPIOwnsErrorReporting();
>    JS::ContextOptionsRef(cx()).setAutoJSAPIOwnsErrorReporting(true);
> +  // Workers have their own error reporting mechanism which deals with warnings
> +  // as well, so don't change the worker error reporter for now.  Once we switch

Can you add a bug number here?

Comment 3

[Boris Zbarsky [:bzbarsky]]

> Can you add a bug number here?

Will do.

Comment 4

[Bobby Holley (:bholley)]

Comment on attachment 8689086 [details] [diff] [review]
Make AutoJSAPI::TakeOwnershipOfErrorReporting actually work on workers as long as no one calls JS_ReportPendingException manually

Review of attachment 8689086 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm. Sorry for the lag :-(

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/bf248ceb561b

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/bf248ceb561b