1225753 - prefix is set to ac_default_prefix too late

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Landry Breuil (:gaston)]

Bug 1224490 broke linking on OpenBSD, MOZ_FIX_LINK_PATHS ends up with -rpath-link,NONE/lib because prefix isnt set. Previously it defaulted to usr/local correctly.

Now when linking, all the libs which should be looked for in usr/local/lib arent found and ld fails.

Looking at the generated configure file, 

6829 MOZ_FIX_LINK_PATHS="-Wl,-rpath-link,${DIST}/bin -Wl,-rpath-link,${prefix}/lib"
30075 test "x$prefix" = xNONE && prefix=$ac_default_prefix

That cant work.

Comment 1

[Landry Breuil (:gaston)]

Should http://hg.mozilla.org/mozilla-central/file/tip/build/autoconf/config.status.m4#l103 be moved elsewhere ?

Comment 2

[Landry Breuil (:gaston)]

This now affects aurora too, i work it around by adding --prefix=/usr/local to my .mozconfig but this doesnt feel right.

Mike, on linux how are the depending libs found when linking tests with libxul.so ? /usr/lib is in -L by accident ? The values from pkg-config --libs arent stripped the same ? Here it really seems that mozbuild is doing too much reordering/stripping... and the depending paths are not written in libxul.so.


 Which way should i dig to fix this properly ?

Comment 3

[Mike Hommey [:glandium]]

Just move things such that prefix is set earlier.

Comment 4

[Landry Breuil (:gaston)]

remote: View your changes here:
remote:   https://hg.mozilla.org/try/rev/f59a443dc541
remote:   https://hg.mozilla.org/try/rev/adf8b69c7eb0
remote: 
remote: Follow the progress of your build on Treeherder:
remote:   https://treeherder.mozilla.org/#/jobs?repo=try&revision=adf8b69c7eb0

Comment 5

[Landry Breuil (:gaston)]

Attachment: Move prefix default init earlier

Try was green, so let's risk it...

Comment 6

[Mike Hommey [:glandium]]

Comment on attachment 8700764 [details] [diff] [review]
Move prefix default init earlier

Review of attachment 8700764 [details] [diff] [review]:
-----------------------------------------------------------------

::: configure.in
@@ +936,5 @@
>  MOZ_USER_DIR=".mozilla"
>  
> +test "x$prefix" = xNONE && prefix=$ac_default_prefix
> +# Let make expand exec_prefix.
> +test "x$exec_prefix" = xNONE && exec_prefix='${prefix}'

That's quite a random place to move it to. It would be better even earlier. Also, you're effectively removing it from js/src/configure, since you're moving it from a build/autoconf/*.m4 file to top-level configure.in. It would be better move to AC_INIT_PREPARE in build/autoconf/hooks.m4.

Comment 7

[Landry Breuil (:gaston)]

(In reply to Mike Hommey [:glandium] from comment #6)
> Comment on attachment 8700764 [details] [diff] [review]
> Move prefix default init earlier
> 
> Review of attachment 8700764 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: configure.in
> @@ +936,5 @@
> >  MOZ_USER_DIR=".mozilla"
> >  
> > +test "x$prefix" = xNONE && prefix=$ac_default_prefix
> > +# Let make expand exec_prefix.
> > +test "x$exec_prefix" = xNONE && exec_prefix='${prefix}'
> 
> That's quite a random place to move it to. It would be better even earlier.
> Also, you're effectively removing it from js/src/configure, since you're
> moving it from a build/autoconf/*.m4 file to top-level configure.in. It
> would be better move to AC_INIT_PREPARE in build/autoconf/hooks.m4.

You could have said that right from the start instead of just 'move it earlier' :)

Comment 8

[Landry Breuil (:gaston)]

Attachment: Move prefix default init earlier

With this, prefix is set to ac_default_prefix in line 1145 in the generated configure, which is 5000 lines earlier than my previous patch.

Comment 9

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/fcdaa7c034f4

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/fcdaa7c034f4