Closed Bug 1225874 Opened 9 years ago Closed 8 years ago

Rename PULSE_DATA_INGESTION_CONFIG and use the urlparse result directly

Categories

(Tree Management :: Treeherder: Data Ingestion, defect, P3)

Product:
Tree Management
Component:
Treeherder: Data Ingestion
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED DUPLICATE of bug 1281821

People

(Reporter: emorley, Assigned: emorley)

Details

I think `PULSE_DATA_INGESTION_CONFIG` might be best named like one of the following: * `PULSE_DATA_INGESTION_URI` * `PULSE_INGESTION_URI` Also, its default value is the empty string (rather than `None`), which was necessary prior to https://github.com/joke2k/django-environ/issues/44 , but that's now been fixed. The contents of the variable is then parsed to `urlparse` in ingest_from_pulse.py, whereas we could just use it directly (that's the point of `env.url()`) :-)
Priority: P2 → P3
Assignee: nobody → emorley
Folding this into bug 1281821.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.