1225890 - [l10n] Update searchplugins to latest version

Status: RESOLVED FIXED

(Firefox for iOS :: General, defect)

Description

[Francesco Lodolo [:flod]]

Attachment: Pull request on Github

Today I've received a warning that the searchplugin icon for one of our searchplugins in Dutch was outdated. Indeed, none of the searchplugins have been updated recently, so I tried to run the scripts to scrap searchplugins from Fennec.

Besides updating the shebang to make the scripts portable, I noticed another issue: there are a few locales missing, but more important all Wikipedia icons have been updated (history points to bug 1193421). That makes the script not really useful at this point. Any reason to not use the script's output instead?

Comment 1

[Francesco Lodolo [:flod]]

Added update to nb-NO and nn-NO from bug 1212622.

Stefan, any help in figuring out this bug?

Comment 2

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

This patch looks good. I think we should land it. Is this urgent? Or can it wait until 2.0?

I don't understand the process to do this. But I see people raise concerns about it for a while. So I think we should rethink this. Ideally it is just a simple 'pull from android' kind of thing to keep it all in sync. But I don't know if that is still possible with the customizations that we have been doing for iOS. (Search Codes & China specific?)

Comment 3

[Francesco Lodolo [:flod]]

It's OK to land this in the 2.0 timeframe. As for China (or others), we can think of an exclusion list.

Comment 4

[Brian Nicholson (:bnicholson)]

Comment on attachment 8689040 [details] [review]
Pull request on Github

I think the main reason we've diverged from the Android search engines is that we use different search codes on iOS. I was hoping we could eventually add another step to the import script that does a map/replace of Android->iOS search codes, allowing search engine imports to be automated again.

If that's not an option, we'll have to remember to manually update this repo every time we change the Android engines, which is far from ideal.

Comment 5

[Richard Newman [:rnewman]]

https://github.com/mozilla/firefox-ios/commit/e8f9d74f1118dcd5afeb28917f37a80ca317ff97

Does this need to go into 1.4?

Comment 6

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

How urgent is this? Can this wait a few weeks?

Comment 7

[Francesco Lodolo [:flod]]

It can definitely wait 2.0