Closed Bug 1226005 Opened 9 years ago Closed 6 years ago

Implement RDP methods for searching JavaScript sources

Categories

(DevTools :: Debugger, defect)

40 Branch
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED DUPLICATE of bug 1010288

People

(Reporter: jlong, Unassigned)

References

Details

(Whiteboard: [gaming-tools])

To search JavaScript sources right now we load in the source text for *all* of the sources into the frontend, and then search it there. This makes it really bad when there are a large amount of sources. We should have a protocol method for running a search across all sources currently in existence.
Blocks: 1226007
Jen and Eddy, I just realized something regarding bug 1224726 and bug 1224726. This actually will *not* fix those. Those bugs are talking about (I think) searching a single large file that is already loaded in the frontend. We still need to do what this bug talks about, but if we want to optimize searching a large file that is already loaded in the frontend, we are going to need to optimize how we show contents in the editor itself. Eddy mentioned something like "chunking" the JS source, so we only dump part of the source in the editor, and I get now what he was talking about. This bug was only meant to cover searching *all* files. We might need another bug for optimizing single large files. Unfortunately that gets a lot more complicated... We'll need to look into CodeMirror itself and be clever about how we use it. I'm actually not sure we need anything in the RDP at all to fix the large file issue. It's fine to have the large file client-side, and even do the searching (either way it's just JS doing it, whether it's on the client or server). The issue is how we display it in the editor, which is entirely a frontend concern.
Whiteboard: [gaming-tools]
Product: Firefox → DevTools
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.