1226015 - [SpeechSynthesis] Calling pause/cancel after a short lived utterance causes a race condition in e10s

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Eitan Isaacson [:eeejay]]

An utterance could be short lived if it fails immediately after speak, or if it an empty string that completes "speaking" instantly.

Consider the following js:
speechSynthesis.speak(new SpeechSynthesisUtterance());
speechSynthesis.cancel();

If called from a child content process the protocol will be created and then destroyed before the cancel is sent to the parent process.

Comment 1

[Eitan Isaacson [:eeejay]]

Attachment: Have child send __delete__ in speech synth request protocol, fixes race.

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

I tried and failed to understand where we're crashing and why the patch fixes that.

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8689297 [details] [diff] [review]
Have child send __delete__ in speech synth request protocol, fixes race.

+ if ((flags & eFailAtStart) != 0) {
I would just do
if (flags & eFailAtStart)

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a9f0334501a9

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/a9f0334501a9