1226120 - Write regression test for bug 1040005 (handling of the "open with" list for alwaysAsk files when the default used to be something other than opening)

Status: RESOLVED FIXED

(Core Graveyard :: File Handling, defect)

Description

[:Gijs (he/him)]

See bug 1040005 for problem description. We should write a test, also because I expect we don't have an awful lot of tests of this functionality at the moment.

Comment 1

[:Gijs (he/him)]

Attachment: add test for unknownContentType.xul and file types with a default handler but always ask set,

Comment 2

[:Gijs (he/him)]

Comment on attachment 8699517 [details] [diff] [review]
add test for unknownContentType.xul and file types with a default handler but always ask set,

Gah, meant to just hg export.

Comment 3

[:Gijs (he/him)]

Attachment: MozReview Request: Bug 1226120 - add test for unknownContentType.xul and file types with a default handler but always ask set, r?mconley

Review commit: https://reviewboard.mozilla.org/r/28267/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/28267/

Comment 4

[:Gijs (he/him)]

I verified that this fails on beta and passes locally for me on OSX. Trypush:

remote:   https://treeherder.mozilla.org/#/jobs?repo=try&revision=9d22bf01848d

Comment 5

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8699523 [details]
MozReview Request: Bug 1226120 - add test for unknownContentType.xul and file types with a default handler but always ask set, r?mconley

https://reviewboard.mozilla.org/r/28267/#review25323

::: uriloader/exthandler/tests/mochitest/browser_download_always_ask_preferred_app.js:94
(Diff revision 1)
> +  helperAppDialog.show(launcher, window, "foopy");

Indentation

::: uriloader/exthandler/tests/mochitest/browser_download_always_ask_preferred_app.js:96
(Diff revision 1)
> +    Cu.reportError(ex);

Should we fail here?

::: uriloader/exthandler/tests/mochitest/browser_download_always_ask_preferred_app.js:99
(Diff revision 1)
> +  yield new Promise(resolve => {

Could also use BrowserTestUtils.waitForEvent, no?

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/a8e74b6b0511

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/a8e74b6b0511