1226147 - WorkerPrivate->NowBaseTimeStamp() should not return the parent->GetPerformance()->Now() in dedicated Workers.

Status: RESOLVED FIXED

(Core :: DOM: Workers, defect)

Description

[Andrea Marchesini [:baku]]

This is a follow up of bug 1169068.

Comment 1

[Andrea Marchesini [:baku]]

Attachment: time2.patch

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8689617 [details] [diff] [review]
time2.patch

Why do we still need mNowBaseTimeStamp/mNowBaseTimeHighRes?  Can't we just use the creation timestamp/time instead?  Or do we expect there to be other changes that might cause the "creation" times and the "now base" times to diverge again?

Comment 3

[Andrea Marchesini [:baku]]

Attachment: time2.patch

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8689635 [details] [diff] [review]
time2.patch

r=me.  Thanks!

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3c907bb9ba04

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/3c907bb9ba04

Comment 7

[Chris Mills [:cmills]]

I've added a description of this behaviour in 

https://developer.mozilla.org/en-US/docs/Web/API/Performance/now

Is this ok?

Comment 8

[Boris Zbarsky [:bzbarsky]]

Looks pretty good, though it would be awesome if the part talking about how performance.now() in the worker and window no longer uses the same time base linked to the docs for bug 1169068 (which added Performance.translateTime).

Comment 9

[Kohei Yoshino [:kohei]]

Posted the site compatibility doc: https://www.fxsitecompat.com/en-US/docs/2015/performance-now-in-workers-is-now-based-on-the-workers-creation-time/