Closed Bug 1226147 Opened 4 years ago Closed 4 years ago
Private->Now Base Time Stamp() should not return the parent->Get Performance()->Now() in dedicated Workers .
This is a follow up of bug 1169068.
Comment on attachment 8689617 [details] [diff] [review] time2.patch Why do we still need mNowBaseTimeStamp/mNowBaseTimeHighRes? Can't we just use the creation timestamp/time instead? Or do we expect there to be other changes that might cause the "creation" times and the "now base" times to diverge again?
Attachment #8689617 - Flags: review?(bzbarsky) → review-
Comment on attachment 8689635 [details] [diff] [review] time2.patch r=me. Thanks!
Attachment #8689635 - Flags: review?(bzbarsky) → review+
I've added a description of this behaviour in https://developer.mozilla.org/en-US/docs/Web/API/Performance/now Is this ok?
Looks pretty good, though it would be awesome if the part talking about how performance.now() in the worker and window no longer uses the same time base linked to the docs for bug 1169068 (which added Performance.translateTime).
Posted the site compatibility doc: https://www.fxsitecompat.com/en-US/docs/2015/performance-now-in-workers-is-now-based-on-the-workers-creation-time/
You need to log in before you can comment on or make changes to this bug.