Closed Bug 1226147 Opened 4 years ago Closed 4 years ago

WorkerPrivate->NowBaseTimeStamp() should not return the parent->GetPerformance()->Now() in dedicated Workers.

Categories

(Core :: DOM: Workers, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla45
Tracking Status
firefox45 --- fixed

People

(Reporter: baku, Assigned: baku)

Details

(Keywords: dev-doc-complete, site-compat)

Attachments

(1 file, 1 obsolete file)

This is a follow up of bug 1169068.
Attached patch time2.patch (obsolete) — Splinter Review
Attachment #8689617 - Flags: review?(bzbarsky)
Comment on attachment 8689617 [details] [diff] [review]
time2.patch

Why do we still need mNowBaseTimeStamp/mNowBaseTimeHighRes?  Can't we just use the creation timestamp/time instead?  Or do we expect there to be other changes that might cause the "creation" times and the "now base" times to diverge again?
Attachment #8689617 - Flags: review?(bzbarsky) → review-
Attached patch time2.patchSplinter Review
Attachment #8689617 - Attachment is obsolete: true
Attachment #8689635 - Flags: review?(bzbarsky)
Comment on attachment 8689635 [details] [diff] [review]
time2.patch

r=me.  Thanks!
Attachment #8689635 - Flags: review?(bzbarsky) → review+
https://hg.mozilla.org/mozilla-central/rev/3c907bb9ba04
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
Looks pretty good, though it would be awesome if the part talking about how performance.now() in the worker and window no longer uses the same time base linked to the docs for bug 1169068 (which added Performance.translateTime).
You need to log in before you can comment on or make changes to this bug.