1226175 - update harfbuzz to upstream release 1.1.0

Status: RESOLVED FIXED

(Core :: Graphics: Text, defect)

Description

[NVD]

http://cgit.freedesktop.org/harfbuzz/commit/?id=e1118aeac3b5556df0ce502732df8ac92bdac45a

Overview of changes leading to 1.1.0
Wednesday, November 18, 2015
====================================

- Implement 'stch' stretch feature for Syriac Abbreviation Mark.
  https://github.com/behdad/harfbuzz/issues/141
- Disable use of decompose_compatibility() callback.
- Implement "shaping" of various Unicode space characters, even
  if the font does not support them.
  https://github.com/behdad/harfbuzz/issues/153
- If font does not support U+2011 NO-BREAK HYPHEN, fallback to
  U+2010 HYPHEN.
- Changes resulting from libFuzzer continuous fuzzing:
  * Reject font tables that need more than 8 edits,
  * Bound buffer growth during shaping to 32x,
  * Fix assertions and other issues at OOM / buffer max-growth.
- Misc fixes and optimizations.
- API changes:
  * All fonts created with hb_font_create() now inherit from
    (ie. have parent) hb_font_get_empty().

Comment 1

[Jonathan Kew [:jfkthame]]

Attachment: Update in-tree harfbuzz to release 1.1.0 to pick up Syriac Abbreviation Mark support ('stch' feature)

I've confirmed locally that we get proper SAM rendering with this, using the Segoe UI Historic font. I'm not aware of a free font with appropriate support that we can include for reftest purposes at this time.

Comment 2

[Khaled Hosny]

I can try to prepare such a font if you like, may be something based on Noto fonts.

Comment 3

[Jonathan Kew [:jfkthame]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/815c0c1d5619a4a122108148f303db3ed05c2247
Bug 1226175 - Update in-tree harfbuzz to release 1.1.0 to pick up Syriac Abbreviation Mark support ('stch' feature). r=jdaggett

Comment 4

[Jonathan Kew [:jfkthame]]

(In reply to Khaled Hosny from comment #2)
> I can try to prepare such a font if you like, may be something based on Noto
> fonts.

If you wish, but I don't see it as a high priority. This is primarily a harfbuzz issue, and it's tested there, so I'm comfortable with just having confirmed manually that it appears as expected in Gecko.

Comment 5

[Khaled Hosny]

(In reply to Jonathan Kew (:jfkthame) from comment #4)
> (In reply to Khaled Hosny from comment #2)
> > I can try to prepare such a font if you like, may be something based on Noto
> > fonts.
> 
> If you wish, but I don't see it as a high priority. This is primarily a
> harfbuzz issue, and it's tested there, so I'm comfortable with just having
> confirmed manually that it appears as expected in Gecko.

OK, all good then.

Comment 6

[Pulsebot]

Backout:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f0ecb8d583b4

Comment 7

[Krasnaya Ploshchad’]

(In reply to Pulsebot from comment #6)
> Backout:
> https://hg.mozilla.org/integration/mozilla-inbound/rev/f0ecb8d583b4

What’s wrong exactly?

Comment 8

[Jonathan Kew [:jfkthame]]

/builds/slave/m-in-lx-0000000000000000000000/build/src/gfx/harfbuzz/src/hb-font.cc:304:1: error: missing braces around initializer for 'hb_font_funcs_t::get_t::get_funcs_t' [-Werror=missing-braces]
/builds/slave/m-in-lx-0000000000000000000000/build/src/gfx/harfbuzz/src/hb-font.cc:325:1: error: missing braces around initializer for 'hb_font_funcs_t::get_t::get_funcs_t' [-Werror=missing-braces] 

I'll fix, test, and re-land.

Comment 9

[Jonathan Kew [:jfkthame]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=7eefe642eeb5

Comment 10

[Jonathan Kew [:jfkthame]]

Ugh, I just realized there's another set of errors that showed up on Windows (only):

c:\builds\moz2_slave\m-in-w32-000000000000000000000\build\src\gfx\harfbuzz\src\hb-buffer-private.hh(51) : error C4430: missing type specifier - int assumed. Note: C++ does not support default-int
c:\builds\moz2_slave\m-in-w32-000000000000000000000\build\src\gfx\harfbuzz\src\hb-buffer-private.hh(52) : error C4430: missing type specifier - int assumed. Note: C++ does not support default-int
c:\builds\moz2_slave\m-in-w32-000000000000000000000\build\src\gfx\harfbuzz\src\hb-buffer-private.hh(67) : error C4430: missing type specifier - int assumed. Note: C++ does not support default-int
c:\builds\moz2_slave\m-in-w32-000000000000000000000\build\src\gfx\harfbuzz\src\hb-ot-map-private.hh(162) : error C4430: missing type specifier - int assumed. Note: C++ does not support default-int
c:\builds\moz2_slave\m-in-w32-000000000000000000000\build\src\gfx\harfbuzz\src\hb-ot-layout-private.hh(68) : error C4430: missing type specifier - int assumed. Note: C++ does not support default-int
c:\builds\moz2_slave\m-in-w32-000000000000000000000\build\src\gfx\harfbuzz\src\hb-ot-layout-private.hh(240) : error C4430: missing type specifier - int assumed. Note: C++ does not support default-int
c:\builds\moz2_slave\m-in-w32-000000000000000000000\build\src\gfx\harfbuzz\src\hb-ot-layout-private.hh(252) : error C2676: binary '|=' : 'hb_buffer_scratch_flags_t' does not define this operator or a conversion to a type acceptable to the predefined operator
c:\builds\moz2_slave\m-in-w32-000000000000000000000\build\src\gfx\harfbuzz\src\hb-ot-layout-private.hh(255) : error C2676: binary '|=' : 'hb_buffer_scratch_flags_t' does not define this operator or a conversion to a type acceptable to the predefined operator 

So a bit more cleanup needed, it seems.

Comment 11

[Jonathan Kew [:jfkthame]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=8e445f18b245

Comment 12

[Jonathan Kew [:jfkthame]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=2614ecffefff

Comment 13

[Behdad Esfahbod]

(In reply to Jonathan Kew (:jfkthame) from comment #10)
> Ugh, I just realized there's another set of errors that showed up on Windows
> (only):
> 
> c:\builds\moz2_slave\m-in-w32-
> 000000000000000000000\build\src\gfx\harfbuzz\src\hb-buffer-private.hh(51) :
> error C4430: missing type specifier - int assumed. Note: C++ does not
> support default-int
> c:\builds\moz2_slave\m-in-w32-
> 000000000000000000000\build\src\gfx\harfbuzz\src\hb-buffer-private.hh(52) :
> error C4430: missing type specifier - int assumed. Note: C++ does not
> support default-int
> c:\builds\moz2_slave\m-in-w32-
> 000000000000000000000\build\src\gfx\harfbuzz\src\hb-buffer-private.hh(67) :
> error C4430: missing type specifier - int assumed. Note: C++ does not
> support default-int
> c:\builds\moz2_slave\m-in-w32-
> 000000000000000000000\build\src\gfx\harfbuzz\src\hb-ot-map-private.hh(162) :
> error C4430: missing type specifier - int assumed. Note: C++ does not
> support default-int
> c:\builds\moz2_slave\m-in-w32-
> 000000000000000000000\build\src\gfx\harfbuzz\src\hb-ot-layout-private.hh(68)
> : error C4430: missing type specifier - int assumed. Note: C++ does not
> support default-int
> c:\builds\moz2_slave\m-in-w32-
> 000000000000000000000\build\src\gfx\harfbuzz\src\hb-ot-layout-private.
> hh(240) : error C4430: missing type specifier - int assumed. Note: C++ does
> not support default-int
> c:\builds\moz2_slave\m-in-w32-
> 000000000000000000000\build\src\gfx\harfbuzz\src\hb-ot-layout-private.
> hh(252) : error C2676: binary '|=' : 'hb_buffer_scratch_flags_t' does not
> define this operator or a conversion to a type acceptable to the predefined
> operator
> c:\builds\moz2_slave\m-in-w32-
> 000000000000000000000\build\src\gfx\harfbuzz\src\hb-ot-layout-private.
> hh(255) : error C2676: binary '|=' : 'hb_buffer_scratch_flags_t' does not
> define this operator or a conversion to a type acceptable to the predefined
> operator 
> 
> So a bit more cleanup needed, it seems.

I replaced the template use for these with non-template.  See if that helps?

Comment 14

[Jonathan Kew [:jfkthame]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7de63224e7b9e3fb7169dff6dcb601df771dfb25
Bug 1226175 - Update in-tree harfbuzz to release 1.1.0 to pick up Syriac Abbreviation Mark support ('stch' feature). r=jdaggett

Comment 15

[Jonathan Kew [:jfkthame]]

(In reply to Behdad Esfahbod from comment #13)
> I replaced the template use for these with non-template.  See if that helps?

I expect so (will test in a while, or whenever the next release comes); for getting 1.1.0 landed now, I just added the #include to keep the build happy on Windows.

Comment 16

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/7de63224e7b9