1226209 - Update order of "Clear private data" checkboxes so that default unchecked boxes are at the bottom

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Settings and Preferences, defect)

Description

[:Margaret Leibovic]

Follow-up to bug 1221290.

Comment 1

[swaroop.rao]

I'd like to take this up. How can I get started? I have a build up and running.

Comment 2

[Richard Newman [:rnewman]]

It should be as simple as reordering the various arrays in this file:

https://dxr.mozilla.org/mozilla-central/source/mobile/android/base/resources/values/arrays.xml#96

Comment 3

[swaroop.rao]

Attachment: name.patch

It's been a long time since I submitted a patch for review. I followed the instructions and hopefully got it right. Please review and let me know if it looks OK or not.

Comment 4

[Chenxia Liu [:liuche]]

Comment on attachment 8698509 [details] [diff] [review]
name.patch

Review of attachment 8698509 [details] [diff] [review]:
-----------------------------------------------------------------

This is the right place to look, but if you'll notice, you're only updating the default values, but not the corresponding string values. This patch is actually changing the default value of the last item to be false, which is not what we want. We want the items that are unchecked/false by default to be on the bottom.

Comment 5

[swaroop.rao]

Attachment: name.patch

Ah, I see that now. I didn't realize that they all went together. I saw 4 <string-array> elements that had names starting with "pref_private_data", so I modified all of them so that they stay lined up correctly.

Comment 6

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8698763 [details] [diff] [review]
name.patch

Review of attachment 8698763 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm!

Comment 7

[swaroop.rao]

Is there anything else needed from me for this bug? Try server log can be viewed at https://treeherder.mozilla.org/logviewer.html#?job_id=14750951&repo=try.

Comment 8

[Nick Alexander :nalexander [he/him]]

(In reply to swaroop.rao from comment #7)
> Is there anything else needed from me for this bug? Try server log can be
> viewed at
> https://treeherder.mozilla.org/logviewer.html#?job_id=14750951&repo=try.

Nope!  Try looks green, and you have r+, so I'll set checkin-needed.  Next time, you should be able to set that yourself.

Comment 9

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/506b5a07ebdf

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/506b5a07ebdf

Comment 11

[Teodora Vermesan (:TeoVermesan)]

Attachment: Screenshot_2016-01-07-11-12-24.png

Verified as fixed using:
Device: Nexus 7 (Android 5.1.1)
Build: Firefox for Android 46.0a1 (2015-12-27)