1226308 - Users do not receive confirmation or denial messages when using SIM control codes for pin change in dialer

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[Adam Alldredge [:AdamA][Inactive]]

Attachment: logcat

Description:
if the user attempts to change their sim pin using the control codes in the dialer app they will not receive a confirmation message that says that the sim pin has changed. There is also no message that the sim pin is incorrect which can lead to people locking sim cards.

Notes:
**04*1234*6789*6789# would change your PIN code from "1234" to "6789".

Repro Steps:
1) Update a Aries to 20151119162551
2) Open dialer app
3) Enter in control codes to change sim pin(see notes for example)
4) Press call button in dialer
5) Observe screen

Actual:
User does not receive a message to inform them if the control codes worked or failed

Expected:
It is expected that the user receives a message informing of the results of the sime control codes

Environmental Variables:
Device: Aries 2.6 [Full flash]
Build ID: 20151119162551
Gaia: ffaade435bb9c3005fd6c9b7ee1cd17b90e08cbf
Gecko: a523d4c7efe2f43dd6b25a176c07b729918d550f
Gonk: a19052e4389c3ae2d8fc3e7a74a475401baacc56
Version: 45.0a1 (2.6)
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:45.0) Gecko/45.0 Firefox/45.0

Repro frequency: 10/10
Link to failed test case: https://moztrap.mozilla.org/manage/case/14361/
See attached: video clip(https://youtu.be/Y2cmlX38sTU), logcat

Comment 1

[KTucker [:KTucker][Inactive 3/4/2016]]

The user can easily lock their SIM by tapping the call button 4 times since there is not a confirmation message to indicate that the PIN was changed successfully. For this reason, we are calling this a smoke test blocker.

Comment 2

[Adam Alldredge [:AdamA][Inactive]]

This issue DOES occur on Flame 2.6.

Environmental Variables:
Device: Flame 2.6 [Full Flash][512mb]
BuildID: 20151119065326
Gaia: ffaade435bb9c3005fd6c9b7ee1cd17b90e08cbf
Gecko: a523d4c7efe2f43dd6b25a176c07b729918d550f
Gonk: 205ac4204bbbb2098a8046444acba551ba5dc75a
Version: 45.0a1 (2.6) 
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:45.0) Gecko/45.0 Firefox/45.0

Result:
User does not receive a message to inform them if the control codes worked or failed
---------------------------------------------
This issue DOES NOT occur on Flame 2.5.

Environmental Variables:
Device: Aries 2.5 [Full Flash]
BuildID: 20151109004552
Gaia: cf646c52bb947af28329b0a100df91d1b1f2a907
Gecko: 4eafef5b80f8985c94c4a067f130d37513e1a581
Gonk: 205ac4204bbbb2098a8046444acba551ba5dc75a
Version: 44.0a2 (2.5) 
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:44.0) Gecko/44.0 Firefox/44.0

Result:
User receives confirmation and error messages when changing sim.

Comment 3

[Pi Wei Cheng [:piwei] (inactive)]

b2g inbound regression window:

Last Working
Device: Flame
BuildID: 20151118022531
Gaia: cba7e4b86361af31b153cfebaf99900e0b860f7b
Gecko: fc29bf8b72a0d1712a051cb549694471f495bfd1
Version: 45.0a1 (2.6 Master) 
Firmware Version: v18Dv4
User Agent: Mozilla/5.0 (Mobile; rv:45.0) Gecko/45.0 Firefox/45.0

First Broken
Device: Flame
BuildID: 20151118144936
Gaia: 0a7619882362737562e79fc87226e08632d0c3d9
Gecko: 0ffb4ebae2e5fd36fc6a3bd5385c8911dc5250d9
Version: 45.0a1 (2.6 Master) 
Firmware Version: v18Dv4
User Agent: Mozilla/5.0 (Mobile; rv:45.0) Gecko/45.0 Firefox/45.0

Last Working Gaia First Broken Gecko - no repro
Gaia: cba7e4b86361af31b153cfebaf99900e0b860f7b
Gecko: 0ffb4ebae2e5fd36fc6a3bd5385c8911dc5250d9

Last Working Gecko First Broken Gaia - repro
Gaia: 0a7619882362737562e79fc87226e08632d0c3d9
Gecko: fc29bf8b72a0d1712a051cb549694471f495bfd1

Gaia pushlog:
https://github.com/mozilla-b2g/gaia/compare/cba7e4b86361af31b153cfebaf99900e0b860f7b...0a7619882362737562e79fc87226e08632d0c3d9

Caused by changes made in Bug 1225047.

Comment 4

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

Kevin this issue seems to have been caused by the changes for bug 1225047.  Can you please take a look?

Comment 5

[Kevin Grandon :kgrandon]

I see the following error in logcat: E/Communications( 1861): [JavaScript Error: "TypeError: SuggestionBar.hideOverlay is not a function" {file: "app://communications.gaiamobile.org/dialer/js/dialer.js" line: 352}]

Comment 6

[Kevin Grandon :kgrandon]

Reverted bug 1225047 in order to fix it in a single commit. This should be fixed now.

https://github.com/mozilla-b2g/gaia/commit/20f140d8b0142a151ff58f726782526c6b2354c9

Comment 7

[Adam Alldredge [:AdamA][Inactive]]

This issue is verified fixed on Flame 2.6 and Aries 2.6.

Environmental Variables:
Device: Aries 2.6 [Full Flash]
BuildID: 20151123143009
Gaia: bae13c9ac6a91beecd7c94384e2aef25ed1a3214
Gecko: d3d286102ba7f8801e9dfe12d534f49554ba50c0
Gonk: a19052e4389c3ae2d8fc3e7a74a475401baacc56
Version: 45.0a1 (2.6) 
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:45.0) Gecko/45.0 Firefox/45.0

Device: Flame 2.6 [Full Flash][512mb]
BuildID: 20151123142444
Gaia: bae13c9ac6a91beecd7c94384e2aef25ed1a3214
Gecko: d3d286102ba7f8801e9dfe12d534f49554ba50c0
Gonk: 205ac4204bbbb2098a8046444acba551ba5dc75a
Version: 45.0a1 (2.6) 
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:45.0) Gecko/45.0 Firefox/45.0

Result:
the user receives a message when attempting to change the sim pin using control codes.