ServiceWorkerRegistration.update() should abort if uninstalling

RESOLVED FIXED in Firefox 46

Status

()

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: bkelly, Assigned: Ehsan)

Tracking

(Blocks: 1 bug)

unspecified
mozilla46
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox46 fixed)

Details

Attachments

(1 attachment)

(Reporter)

Description

3 years ago
Step 2 of update() is:

  If registration's uninstalling flag is set, abort these steps.

We don't currently do that.  Its unclear, though, what the promise should be rejected with in this case.  I'll open a spec issue.
(Reporter)

Updated

3 years ago
Blocks: 1226983
(Assignee)

Updated

3 years ago
Assignee: nobody → ehsan
(Assignee)

Comment 2

3 years ago
Created attachment 8703736 [details] [diff] [review]
Reject the promise returned from ServiceWorkerRegistration.update() if the registration is being uninstalled
Attachment #8703736 - Flags: review?(bkelly)
(Reporter)

Comment 3

3 years ago
Comment on attachment 8703736 [details] [diff] [review]
Reject the promise returned from ServiceWorkerRegistration.update() if the registration is being uninstalled

Review of attachment 8703736 [details] [diff] [review]:
-----------------------------------------------------------------

Awesome, thanks!  Do you think the current spec is consistent with this implementation?
Attachment #8703736 - Flags: review?(bkelly) → review+
(Assignee)

Comment 4

3 years ago
No.  I filed a spec issue: https://github.com/slightlyoff/ServiceWorker/issues/807

Comment 6

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/1fa4d2e7c163
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox46: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
You need to log in before you can comment on or make changes to this bug.