Closed
Bug 1226384
Opened 9 years ago
Closed 9 years ago
ServiceWorkerRegistration.update() should abort if uninstalling
Categories
(Core :: DOM: Service Workers, defect)
Core
DOM: Service Workers
Tracking
()
RESOLVED
FIXED
mozilla46
Tracking | Status | |
---|---|---|
firefox46 | --- | fixed |
People
(Reporter: bkelly, Assigned: ehsan.akhgari)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
Step 2 of update() is:
If registration's uninstalling flag is set, abort these steps.
We don't currently do that. Its unclear, though, what the promise should be rejected with in this case. I'll open a spec issue.
Reporter | ||
Comment 1•9 years ago
|
||
Reporter | ||
Updated•9 years ago
|
Blocks: ServiceWorkers-compat
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → ehsan
Assignee | ||
Comment 2•9 years ago
|
||
Attachment #8703736 -
Flags: review?(bkelly)
Reporter | ||
Comment 3•9 years ago
|
||
Comment on attachment 8703736 [details] [diff] [review]
Reject the promise returned from ServiceWorkerRegistration.update() if the registration is being uninstalled
Review of attachment 8703736 [details] [diff] [review]:
-----------------------------------------------------------------
Awesome, thanks! Do you think the current spec is consistent with this implementation?
Attachment #8703736 -
Flags: review?(bkelly) → review+
Assignee | ||
Comment 4•9 years ago
|
||
No. I filed a spec issue: https://github.com/slightlyoff/ServiceWorker/issues/807
Comment 6•9 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox46:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
You need to log in
before you can comment on or make changes to this bug.
Description
•