1226384 - ServiceWorkerRegistration.update() should abort if uninstalling

Status: RESOLVED FIXED

(Core :: DOM: Service Workers, defect)

Description

[Ben Kelly [:bkelly, not reviewing]]

Step 2 of update() is:

  If registration's uninstalling flag is set, abort these steps.

We don't currently do that.  Its unclear, though, what the promise should be rejected with in this case.  I'll open a spec issue.

Comment 1

[Ben Kelly [:bkelly, not reviewing]]

https://github.com/slightlyoff/ServiceWorker/issues/784

Comment 2

[(no longer active)]

Attachment: Reject the promise returned from ServiceWorkerRegistration.update() if the registration is being uninstalled

Comment 3

[Ben Kelly [:bkelly, not reviewing]]

Comment on attachment 8703736 [details] [diff] [review]
Reject the promise returned from ServiceWorkerRegistration.update() if the registration is being uninstalled

Review of attachment 8703736 [details] [diff] [review]:
-----------------------------------------------------------------

Awesome, thanks!  Do you think the current spec is consistent with this implementation?

Comment 4

[(no longer active)]

No.  I filed a spec issue: https://github.com/slightlyoff/ServiceWorker/issues/807

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1fa4d2e7c163

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/1fa4d2e7c163