1226431 - Toggling find in page match case removes focus from the find text box

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Kevin Brosnan [Ex-Mozilla]]

On Firefox for Android nightly 
* Load a page
* open the find bar
* tap on the Aa button

Expected: focus remains in the find in page bar, keyboard remains open, find in page mode toggles the match case state

Actual: focus is removed from the find in page bar, keyboard closes, find in page mode toggles the match case state

Nexus 5 running Android 6.0 w/ Google keyboard

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

The "Actual" in comment 0 seems to match what happens when "Next" or "Previous" buttons are pressed. Should those be changed as well?

I seem to recall a previous bug filed about those buttons...

Comment 2

[Mark Capella [:capella]]

The code [0] was set to mimic desktop behaviour. It would seem a simple state-change of the button needn't trigger a new find, which of-course, the user can perform via an explicit-click.

fyi, I think there's an issue there with the underlying Finder.jsm, such that changing case and simultaneously changing find direction hickups.

(without an intervening fastFind() call to "begin" a "new search").

[0] http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/FindInPageBar.java?rev=4f939aa499b0&mark=156-156#147

Comment 3

[Mark Capella [:capella]]

Attachment: bug1226431.diff

Though maybe I over-complicated it above ... if you just don't want the keyboard hide on toggle, it's a one line patch.

The Next/Prev buttons minimize the keyboard assuming you've now typed the thing you're searching for, and value additional screen for review.

Comment 4

[Mark Capella [:capella]]

Push to try; https://treeherder.mozilla.org/#/jobs?repo=try&revision=41b70bc28d6d

I can't clear the orange on Linux Debug dt1 nor android-4-0-armv7-api11-p opt build. Assuming TRY infra.

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/df507dc13e43

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/df507dc13e43