Toggling find in page match case removes focus from the find text box

RESOLVED FIXED in Firefox 45

Status

()

Firefox for Android
General
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: kbrosnan, Assigned: capella)

Tracking

Trunk
Firefox 45
All
Android
Points:
---

Firefox Tracking Flags

(firefox45 fixed, fennecNightly+)

Details

Attachments

(1 attachment)

(Reporter)

Description

2 years ago
On Firefox for Android nightly 
* Load a page
* open the find bar
* tap on the Aa button

Expected: focus remains in the find in page bar, keyboard remains open, find in page mode toggles the match case state

Actual: focus is removed from the find in page bar, keyboard closes, find in page mode toggles the match case state

Nexus 5 running Android 6.0 w/ Google keyboard
The "Actual" in comment 0 seems to match what happens when "Next" or "Previous" buttons are pressed. Should those be changed as well?

I seem to recall a previous bug filed about those buttons...
(Assignee)

Comment 2

2 years ago
The code [0] was set to mimic desktop behaviour. It would seem a simple state-change of the button needn't trigger a new find, which of-course, the user can perform via an explicit-click.

fyi, I think there's an issue there with the underlying Finder.jsm, such that changing case and simultaneously changing find direction hickups.

(without an intervening fastFind() call to "begin" a "new search").

[0] http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/FindInPageBar.java?rev=4f939aa499b0&mark=156-156#147
(Assignee)

Comment 3

2 years ago
Created attachment 8690444 [details] [diff] [review]
bug1226431.diff

Though maybe I over-complicated it above ... if you just don't want the keyboard hide on toggle, it's a one line patch.

The Next/Prev buttons minimize the keyboard assuming you've now typed the thing you're searching for, and value additional screen for review.
Attachment #8690444 - Flags: review?(kbrosnan)

Updated

2 years ago
tracking-fennec: ? → Nightly+
Attachment #8690444 - Flags: review?(kbrosnan) → review?(margaret.leibovic)

Updated

2 years ago
Attachment #8690444 - Flags: review?(margaret.leibovic) → review+
(Assignee)

Comment 4

2 years ago
Push to try; https://treeherder.mozilla.org/#/jobs?repo=try&revision=41b70bc28d6d

I can't clear the orange on Linux Debug dt1 nor android-4-0-armv7-api11-p opt build. Assuming TRY infra.
(Assignee)

Updated

2 years ago
Assignee: nobody → markcapella
Status: NEW → ASSIGNED

Comment 6

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/df507dc13e43
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox45: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 45
You need to log in before you can comment on or make changes to this bug.