1226513 - Inconsistent RGBA color component ordering when drawing ticks and DOMContentLoaded / load markers in _drawWaterfallBackground()

Status: NEW

(DevTools :: Netmonitor, defect, P3)

Description

[Sami Jaktholm]

The gray ticks are drawn using the following code [1]:
> view32bit[position] = (alphaComponent << 24) | (b << 16) | (g << 8) | r;

The DOMContentLoaded and load markers are drawn using the following code [2]:
> view32bit[delta] = (a << 24) | (r << 16) | (g << 8) | b;

Thus the bytes for the ticks are ordered as ABGR and for the other markers as ARGB. I don't know which is correct but both of them can't be right at the same time.

My guess is that the DOMContentLoaded and load events are drawn incorrectly as DOMContentLoaded marker should be red [3] but it shows up in blue.

[1] https://hg.mozilla.org/mozilla-central/annotate/a2f83cbe53ac4009afa4cb2b0b8f549289b23eeb/devtools/client/netmonitor/netmonitor-view.js#l1962

[2] https://hg.mozilla.org/mozilla-central/annotate/a2f83cbe53ac4009afa4cb2b0b8f549289b23eeb/devtools/client/netmonitor/netmonitor-view.js#l1972

[3] https://hg.mozilla.org/mozilla-central/annotate/a2f83cbe53ac4009afa4cb2b0b8f549289b23eeb/devtools/client/netmonitor/netmonitor-view.js#l33

Comment 2

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Pasted from bug 1233325 comment #0

(In reply to Sebastian Zartner [:sebo] from comment #0)
> The two lines for the 'load' and 'DOMContentLoaded' events are displayed the
> other way round within the Network panel.
> 
> Within the Performance the 'DOMContentLoaded' event is shown with a red
> marker and the 'load' event with a blue marker later in time.
> Though within the Network panel you see the blue line at the left (earlier
> in time) of the red one. So, obviously they are mixed up.
> 
> Also, to be conformal with Firebug, the colors should be switched, so that
> the 'DOMContentLoaded' event is blue and the 'load' event is red.
> 
> Sebastian

Comment 3

[Jan Honza Odvarko [:Honza] (always need-info? me)]

> Also, to be conformal with Firebug, the colors should be switched, so that
> the 'DOMContentLoaded' event is blue and the 'load' event is red.
Also, Chrome is using this color combo.

Honza

Comment 4

[Tim Nguyen :ntim]

Honza, I'm guessing this is no longer relevant.

Comment 5

[Jan Honza Odvarko [:Honza] (always need-info? me)]

(In reply to Tim Nguyen :ntim from comment #4)
> Honza, I'm guessing this is no longer relevant.
Not sure

The related code has been moved to this file:
http://searchfox.org/mozilla-central/source/devtools/client/netmonitor/src/waterfall-background.js
(rendering of the waterfall graph)


(In reply to Sami Jaktholm from comment #0)
> My guess is that the DOMContentLoaded and load events are drawn incorrectly
> as DOMContentLoaded marker should be red [3] but it shows up in blue.
DOMContentLoaded marker should be blue
load marker should be red

Which is exactly how it's done now.

Sami, what's wrong here?

Honza

Comment 6

[Sami Jaktholm]

I don't think this is relevant anymore. The code has changed quite a lot since the I made my initial observation.