1226557 - [Static Analysis][Called C++ object pointer is null] GetPluginForContentProcess from dom/plugins/base/nsPluginHost.cpp called a C++ object pointer is null

Status: RESOLVED INVALID

(Core Graveyard :: Plug-ins, defect)

Description

[Andi [:andi]]

The Static Analysis tool Scan-Build added a null pointer error in GetPluginForContentProcess from dom/plugins/base/nsPluginHost.cpp, Variable aPlugin is thought to be null when dereferenced.

Comment 1

[Andi [:andi]]

Attachment: Bug 1226557.diff

Comment 2

[Andi [:andi]]

Attachment: Bug 1226557.diff

Updated previous version since the last one contained a deleted file.

Comment 3

[Benjamin Smedberg]

Comment on attachment 8690031 [details] [diff] [review]
Bug 1226557.diff

hard-tab nit

Whatever scan-build is, this is a false warning and you should fix the analysis tool. In our tree you are allowed to assume that outparams pointers are non-null. Do you have more details about what scan-build is and how you've configured it?

So I don't think we should accept this kind of assertion just to silence a buggy tool.

Comment 4

[Andi [:andi]]

Scan-Build is a static analyzer tool from llvm that. You can read more here: http://clang-analyzer.llvm.org/scan-build.html

Clang version used: Debian clang version 3.8.0-svn252921-1~exp1 (trunk) (based on LLVM 3.8.0)

It has been ran with the following arguments:
./mach --log-no-times build -v

Honestly i don't think that having an assert will damage the code specially when the asserts are defined only on debug but you know best so it's your call.

let me know if you need more info.