1226584 - [Static Analysis][Called function pointer is null (null dereference)] Function nssCKFWMechanism_Destroy from security/nss/lib/ckfw/mechanism.c potentially causes a pointer to function null dereference

Status: RESOLVED INVALID

(NSS :: Libraries, defect, P3)

Description

[Andi [:andi]]

The Static Analysis tool Scan-Build added a potentially null pointer dereference on pointer fwMechanism->mdMechanism->Destroy.

Comment 1

[Andi [:andi]]

Attachment: Bug 1226584.diff

Comment 2

[Andi [:andi]]

Attachment: Bug 1226584.diff

Hello Bob,

Could you please take a look other this patch in security\nss\lib\ckfw\mechanism.c ? I've tried to fix an issue that scan-build (clang analyzer) pointed out that dereferencing fwMechanism->mdMechanism->Destroy causes a null pointer dereference in:

NSS_IMPLEMENT void
nssCKFWMechanism_Destroy
(
  NSSCKFWMechanism *fwMechanism
)

In this patch i've completly removed the if condition but maybe if fwMechanism->mdMechanism->Destroy is a valud pointer should we call the function to witch it points?

Many thanks

Comment 3

[Andi [:andi]]

Closing this as the code is no longer in accordance with the patch.