Closed Bug 1226754 Opened 4 years ago Closed 4 years ago
sdk/base64 fails to encode long strings
Trying to encode a long string, e.g. using require('sdk/base64').encode('f'.repeat(1e6)) results in the following error: Message: RangeError: too many function arguments
Hi Andy, I moved the patch from Github as requested. Could you review the patch, or select a responsive reviewer? The one I selected for my previous patch never replied.
I suck I don't know how to change the r? to be jsantell, so cheating and using ni.
Comment on attachment 8728634 [details] [diff] [review] Enable base64 encoding of long strings Review of attachment 8728634 [details] [diff] [review]: ----------------------------------------------------------------- LGTM!
Attachment #8728634 - Flags: review?(amckay) → review+
Thanks jsantell, rob.
has problems to apply: renamed 1226754 -> 0001-Bug-1226754-Enable-base64-encoding-of-long-strings.patch applying 0001-Bug-1226754-Enable-base64-encoding-of-long-strings.patch unable to find 'lib/sdk/base64.js' for patching 2 out of 2 hunks FAILED -- saving rejects to file lib/sdk/base64.js.rej unable to find 'test/test-base64.js' for patching 2 out of 2 hunks FAILED -- saving rejects to file test/test-base64.js.rej patch failed, unable to continue (try -v) patch failed, rejects left in working directory errors during apply, please fix and qrefresh 0001-Bug-1226754-Enable-base64-encoding-of-long-strings.patch
I reformatted the patch. Previously it was an export from the addon-sdk repo on Github, now it is based on the mozilla-central repo: $ cd addon-sdk/source $ git apply 0001-Bug-1226754-Enable-base64-encoding-of-long-strings.patch $ hg com -m 'Bug 1226754 - Enable base64-encoding of long strings' $ hg export -o Bug-1226754-Enable-base64-encoding-of-long-strings-hg.patch
I pushed this patch to try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=2ac462058213 the mochitest-jetpack tests are green, so I'm applying the checkin-needed keyword.
You need to log in before you can comment on or make changes to this bug.