Closed Bug 1226822 Opened 10 years ago Closed 10 years ago

|make pkg| fails with Error : suite/installer/removed-files.in:755: Removal of packaged file(s): extensions/{972ce4c6-7e08-4474-a285-3208198ce6fd}.xpi

Categories

(SeaMonkey :: Build Config, defect, P1)

Product:
SeaMonkey
Component:
Build Config
Type:
defect

Tracking

(seamonkey2.42+ affected)

Status:
RESOLVED FIXED
Milestone:
seamonkey2.42
Tracking Flags:
Tracking Status
seamonkey2.42 + affected

People

(Reporter: ewong, Assigned: philip.chee)

References

Details

Attachments

(1 file)

Patch v1 Backout parts of Bug 1125689, Pack Classic, Fix fallout from Bug 1216371
3.93 KB, patch
iannbugzilla
: review+
glandium
: review-
Details | Diff | Splinter Review
Current bustage on trunk: make[2]: Leaving directory `/builds/slave/c-cen-t-lnx/build/objdir/suite/installer' make[2]: Entering directory `/builds/slave/c-cen-t-lnx/build/objdir/suite/installer' make make-package-internal make[3]: Entering directory `/builds/slave/c-cen-t-lnx/build/objdir/suite/installer' /builds/slave/c-cen-t-lnx/build/objdir/_virtualenv/bin/python -m mozbuild.action.preprocessor -DMOZ_APP_NAME=seamonkey -DPREF_DIR=defaults/pref -DJAREXT= -DENABLE_TESTS=1 -DMOZ_ENABLE_GNOME_COMPONENT=1 -DMOZ_GTK=1 -DMOZ_GTK3=1 -DMOZ_PACKAGE_DEBUGQA=1 -DMOZ_URL_CLASSIFIER=1 -DMOZ_UPDATER=1 -DMOZ_MOVEMAIL=1 -DNECKO_WIFI=1 -DMOZ_CHILD_PROCESS_NAME=plugin-container -DDLL_PREFIX=lib -DDLL_SUFFIX=.so -DBIN_SUFFIX= -DDIR_MACOS= -DDIR_RESOURCES= -DBINPATH=bin -DRESPATH=bin -DLPROJ_ROOT=en -DMOZ_ICU_VERSION=56 -DMOZ_ICU_DBG_SUFFIX= -DMOZ_ENABLE_PROFILER_SPS='1' -DMOZ_PROFILING='1' -DMOZILLA_VERSION='"45.0a1"' -DMOZILLA_VERSION_U='45.0a1' -DMOZILLA_UAVERSION='"45.0"' -DXP_LINUX='1' -DD_INO='d_ino' -DMOZ_DEBUG_SYMBOLS='1' -DSTDC_HEADERS='1' -DHAVE_VISIBILITY_HIDDEN_ATTRIBUTE='1' -DHAVE_VISIBILITY_ATTRIBUTE='1' -DHAVE_DIRENT_H='1' -DHAVE_GETOPT_H='1' -DHAVE_SYS_BITYPES_H='1' -DHAVE_MEMORY_H='1' -DHAVE_UNISTD_H='1' -DHAVE_GNU_LIBC_VERSION_H='1' -DHAVE_NL_TYPES_H='1' -DHAVE_MALLOC_H='1' -DHAVE_X11_XKBLIB_H='1' -DHAVE_CPUID_H='1' -DHAVE_SYS_QUOTA_H='1' -DHAVE_SYS_SYSMACROS_H='1' -DHAVE_LINUX_QUOTA_H='1' -DHAVE_LINUX_IF_ADDR_H='1' -DHAVE_LINUX_RTNETLINK_H='1' -DHAVE_SYS_QUEUE_H='1' -DHAVE_SYS_TYPES_H='1' -DHAVE_NETINET_IN_H='1' -DHAVE_BYTESWAP_H='1' -DHAVE_DLOPEN='1' -DHAVE_DLADDR='1' -DHAVE_MEMMEM='1' -DFUNCPROTO='15' -D_REENTRANT='1' -DHAVE_PTHREAD_H='1' -DHAVE_STAT64='1' -DHAVE_LSTAT64='1' -DHAVE_TRUNCATE64='1' -DHAVE_GMTIME_R='1' -DHAVE_LOCALTIME_R='1' -DHAVE_CLOCK_MONOTONIC='1' -DHAVE_RES_NINIT='1' -DHAVE_LANGINFO_CODESET='1' -DVA_COPY='va_copy' -DHAVE_VA_COPY='1' -DHAVE_THREAD_TLS_KEYWORD='1' -DHAVE_I18N_LC_MESSAGES='1' -DHAVE_LOCALECONV='1' -DMALLOC_H='<malloc.h>' -DHAVE_ALLOCA_H='1' -DHAVE_STRNDUP='1' -DHAVE_POSIX_MEMALIGN='1' -DHAVE_MEMALIGN='1' -DHAVE_MALLOC_USABLE_SIZE='1' -DHAVE_MALLOC_H='1' -DMALLOC_USABLE_SIZE_CONST_PTR='' -DHAVE_VALLOC='1' -DTARGET_XPCOM_ABI='"x86-gcc3"' -DNIGHTLY_BUILD='1' -DE10S_TESTING_ONLY='1' -DMOZ_UPDATE_CHANNEL='default' -DEARLY_BETA_OR_EARLIER='1' -DMOZ_BUILD_APP='../suite' -DMOZ_X11='1' -DMOZ_WIDGET_GTK='3' -DMOZ_PDF_PRINTING='1' -DMOZ_ENABLE_XREMOTE='1' -DMOZ_INSTRUMENT_EVENT_LOOP='1' -DGDK_VERSION_MIN_REQUIRED='GDK_VERSION_3_4' -DGDK_VERSION_MAX_ALLOWED='GDK_VERSION_3_4' -DGLIB_VERSION_MIN_REQUIRED='GLIB_VERSION_2_26' -DGLIB_VERSION_MAX_ALLOWED='GLIB_VERSION_2_32' -DNS_PRINTING='1' -DNS_PRINT_PREVIEW='1' -DMOZ_DISTRIBUTION_ID='"org.mozilla"' -DMOZ_ENABLE_GIO='1' -DMOZ_ENABLE_GCONF='1' -DMOZ_ENABLE_DBUS='1' -DACCESSIBILITY='1' -DMOZ_WEBRTC='1' -DMOZ_WEBRTC_ASSERT_ALWAYS='1' -DMOZ_WEBRTC_SIGNALING='1' -DMOZ_PEERCONNECTION='1' -DMOZ_SCTP='1' -DMOZ_SRTP='1' -DMOZ_SAMPLE_TYPE_FLOAT32='1' -DMOZ_WEBSPEECH='1' -DMOZ_WEBSPEECH_TEST_BACKEND='1' -DMOZ_RAW='1' -DATTRIBUTE_ALIGNED_MAX='64' -DMOZ_WEBM='1' -DMOZ_FFMPEG='1' -DMOZ_FMP4='1' -DMOZ_EME='1' -DMOZ_MEDIA_NAVIGATOR='1' -DMOZ_VPX='1' -DMOZ_VPX_ERROR_CONCEALMENT='1' -DVPX_X86_ASM='1' -DMOZ_VPX_NO_MEM_REPORTING='1' -DMOZ_WAVE='1' -DMOZ_VORBIS='1' -DMOZ_WEBM_ENCODER='1' -DMOZ_GSTREAMER='1' -DGST_API_VERSION='"0.10"' -DMOZ_PERMISSIONS='1' -DENABLE_SYSTEM_EXTENSION_DIRS='1' -DMOZ_WEBGL_CONFORMANT='1' -DMOZ_GAMEPAD='1' -DMOZ_CRASHREPORTER='1' -DMOZ_CRASHREPORTER_ENABLE_PERCENT='100' -DMOZ_UPDATER='1' -DENABLE_TESTS='1' -DGTEST_HAS_RTTI='0' -DMOZ_GMP_SANDBOX='1' -DMOZ_SANDBOX='1' -DMOZ_FEEDS='1' -DMOZ_HELP_VIEWER='1' -DMOZ_SAFE_BROWSING='1' -DMOZ_URL_CLASSIFIER='1' -DGL_PROVIDER_GLX='1' -DMOZ_STACKWALKING='1' -DMOZ_LOGGING='1' -DFORCE_PR_LOG='1' -DMOZ_GLUE_IN_PROGRAM='1' -DMOZ_REPLACE_MALLOC='1' -DMOZ_MEMORY='1' -DMOZ_MEMORY_LINUX='1' -DMOZ_SUITE='1' -DMOZ_MORK='1' -DHAVE_MOVEMAIL='1' -DMOZ_PAY='1' -DMOZ_SECUREELEMENT='1' -DHAVE___CXA_DEMANGLE='1' -DHAVE__UNWIND_BACKTRACE='1' -DJS_DEFAULT_JITREPORT_GRANULARITY='3' -DMOZ_OMNIJAR='1' -DMOZ_USER_DIR='".mozilla"' -DHAVE_FT_BITMAP_SIZE_Y_PPEM='1' -DHAVE_FT_GLYPHSLOT_EMBOLDEN='1' -DHAVE_FT_LOAD_SFNT_TABLE='1' -DHAVE_FONTCONFIG_FCFREETYPE_H='1' -DMOZ_TREE_PIXMAN='1' -DHAVE_STDINT_H='1' -DHAVE_INTTYPES_H='1' -DMOZ_TREE_CAIRO='1' -DMOZ_ENABLE_SKIA='1' -DUSE_SKIA='1' -DUSE_SKIA_GPU='1' -DMOZ_XUL='1' -DMOZ_PROFILELOCKING='1' -DENABLE_MARIONETTE='1' -DBUILD_CTYPES='1' -DMOZ_PLACES='1' -DMOZ_SOCIAL='1' -DMOZ_SERVICES_COMMON='1' -DMOZ_SERVICES_CRYPTO='1' -DMOZ_SERVICES_SYNC='1' -DMOZ_SERVICES_CLOUDSYNC='1' -DMOZ_BINARY_EXTENSIONS='1' -DMOZ_MACBUNDLE_ID='org.mozilla.seamonkey' -DMOZ_B2G_VERSION='"1.0.0"' -DMOZ_B2G_OS_NAME='""' -DMOZ_APP_UA_NAME='""' -DMOZ_APP_UA_VERSION='"2.42a1"' -DFIREFOX_VERSION='45.0a1' -DMOZILLA_OFFICIAL='1' -DMOZ_TELEMETRY_DISPLAY_REV='2' -DMOZ_DATA_REPORTING='1' -DMOZ_DLL_SUFFIX='".so"' -DHAVE_POSIX_FADVISE='1' -DHAVE_POSIX_FALLOCATE='1' -DXP_UNIX='1' -DMOZ_ACCESSIBILITY_ATK='1' -DATK_MAJOR_VERSION='2' -DATK_MINOR_VERSION='2' -DATK_REV_VERSION='0' -DA11Y_LOG='1' -DEXPOSE_INTL_API='1' -DENABLE_INTL_API='1' -DU_STATIC_IMPLEMENTATION='1' -DU_USING_ICU_NAMESPACE='0' -DMOZ_STATIC_JS='1' -DNO_NSPR_10_SUPPORT='1' -DAB_CD=en-US /builds/slave/c-cen-t-lnx/build/suite/installer/package-manifest.in -o package-manifest OMNIJAR_NAME=omni.ja \ NO_PKG_FILES="core bsdecho js js-config jscpucfg nsinstall viewer TestGtkEmbed elf-dynstr-gc mangle* maptsv* mfc* msdump* msmap* nm2tsv* nsinstall* res/samples res/throbber shlibsign* certutil* pk12util* BadCertServer* OCSPStaplingServer* GenerateOCSPResponse* chrome/chrome.rdf chrome/app-chrome.manifest chrome/overlayinfo components/compreg.dat components/xpti.dat content_unit_tests necko_unit_tests *.dSYM " \ /builds/slave/c-cen-t-lnx/build/objdir/_virtualenv/bin/python /builds/slave/c-cen-t-lnx/build/mozilla/toolkit/mozapps/installer/packager.py -DMOZ_APP_NAME=seamonkey -DPREF_DIR=defaults/pref -DJAREXT= -DENABLE_TESTS=1 -DMOZ_ENABLE_GNOME_COMPONENT=1 -DMOZ_GTK=1 -DMOZ_GTK3=1 -DMOZ_PACKAGE_DEBUGQA=1 -DMOZ_URL_CLASSIFIER=1 -DMOZ_UPDATER=1 -DMOZ_MOVEMAIL=1 -DNECKO_WIFI=1 -DMOZ_CHILD_PROCESS_NAME=plugin-container -DDLL_PREFIX=lib -DDLL_SUFFIX=.so -DBIN_SUFFIX= -DDIR_MACOS= -DDIR_RESOURCES= -DBINPATH=bin -DRESPATH=bin -DLPROJ_ROOT=en -DMOZ_ICU_VERSION=56 -DMOZ_ICU_DBG_SUFFIX= -DMOZ_ENABLE_PROFILER_SPS='1' -DMOZ_PROFILING='1' -DMOZILLA_VERSION='"45.0a1"' -DMOZILLA_VERSION_U='45.0a1' -DMOZILLA_UAVERSION='"45.0"' -DXP_LINUX='1' -DD_INO='d_ino' -DMOZ_DEBUG_SYMBOLS='1' -DSTDC_HEADERS='1' -DHAVE_VISIBILITY_HIDDEN_ATTRIBUTE='1' -DHAVE_VISIBILITY_ATTRIBUTE='1' -DHAVE_DIRENT_H='1' -DHAVE_GETOPT_H='1' -DHAVE_SYS_BITYPES_H='1' -DHAVE_MEMORY_H='1' -DHAVE_UNISTD_H='1' -DHAVE_GNU_LIBC_VERSION_H='1' -DHAVE_NL_TYPES_H='1' -DHAVE_MALLOC_H='1' -DHAVE_X11_XKBLIB_H='1' -DHAVE_CPUID_H='1' -DHAVE_SYS_QUOTA_H='1' -DHAVE_SYS_SYSMACROS_H='1' -DHAVE_LINUX_QUOTA_H='1' -DHAVE_LINUX_IF_ADDR_H='1' -DHAVE_LINUX_RTNETLINK_H='1' -DHAVE_SYS_QUEUE_H='1' -DHAVE_SYS_TYPES_H='1' -DHAVE_NETINET_IN_H='1' -DHAVE_BYTESWAP_H='1' -DHAVE_DLOPEN='1' -DHAVE_DLADDR='1' -DHAVE_MEMMEM='1' -DFUNCPROTO='15' -D_REENTRANT='1' -DHAVE_PTHREAD_H='1' -DHAVE_STAT64='1' -DHAVE_LSTAT64='1' -DHAVE_TRUNCATE64='1' -DHAVE_GMTIME_R='1' -DHAVE_LOCALTIME_R='1' -DHAVE_CLOCK_MONOTONIC='1' -DHAVE_RES_NINIT='1' -DHAVE_LANGINFO_CODESET='1' -DVA_COPY='va_copy' -DHAVE_VA_COPY='1' -DHAVE_THREAD_TLS_KEYWORD='1' -DHAVE_I18N_LC_MESSAGES='1' -DHAVE_LOCALECONV='1' -DMALLOC_H='<malloc.h>' -DHAVE_ALLOCA_H='1' -DHAVE_STRNDUP='1' -DHAVE_POSIX_MEMALIGN='1' -DHAVE_MEMALIGN='1' -DHAVE_MALLOC_USABLE_SIZE='1' -DHAVE_MALLOC_H='1' -DMALLOC_USABLE_SIZE_CONST_PTR='' -DHAVE_VALLOC='1' -DTARGET_XPCOM_ABI='"x86-gcc3"' -DNIGHTLY_BUILD='1' -DE10S_TESTING_ONLY='1' -DMOZ_UPDATE_CHANNEL='default' -DEARLY_BETA_OR_EARLIER='1' -DMOZ_BUILD_APP='../suite' -DMOZ_X11='1' -DMOZ_WIDGET_GTK='3' -DMOZ_PDF_PRINTING='1' -DMOZ_ENABLE_XREMOTE='1' -DMOZ_INSTRUMENT_EVENT_LOOP='1' -DGDK_VERSION_MIN_REQUIRED='GDK_VERSION_3_4' -DGDK_VERSION_MAX_ALLOWED='GDK_VERSION_3_4' -DGLIB_VERSION_MIN_REQUIRED='GLIB_VERSION_2_26' -DGLIB_VERSION_MAX_ALLOWED='GLIB_VERSION_2_32' -DNS_PRINTING='1' -DNS_PRINT_PREVIEW='1' -DMOZ_DISTRIBUTION_ID='"org.mozilla"' -DMOZ_ENABLE_GIO='1' -DMOZ_ENABLE_GCONF='1' -DMOZ_ENABLE_DBUS='1' -DACCESSIBILITY='1' -DMOZ_WEBRTC='1' -DMOZ_WEBRTC_ASSERT_ALWAYS='1' -DMOZ_WEBRTC_SIGNALING='1' -DMOZ_PEERCONNECTION='1' -DMOZ_SCTP='1' -DMOZ_SRTP='1' -DMOZ_SAMPLE_TYPE_FLOAT32='1' -DMOZ_WEBSPEECH='1' -DMOZ_WEBSPEECH_TEST_BACKEND='1' -DMOZ_RAW='1' -DATTRIBUTE_ALIGNED_MAX='64' -DMOZ_WEBM='1' -DMOZ_FFMPEG='1' -DMOZ_FMP4='1' -DMOZ_EME='1' -DMOZ_MEDIA_NAVIGATOR='1' -DMOZ_VPX='1' -DMOZ_VPX_ERROR_CONCEALMENT='1' -DVPX_X86_ASM='1' -DMOZ_VPX_NO_MEM_REPORTING='1' -DMOZ_WAVE='1' -DMOZ_VORBIS='1' -DMOZ_WEBM_ENCODER='1' -DMOZ_GSTREAMER='1' -DGST_API_VERSION='"0.10"' -DMOZ_PERMISSIONS='1' -DENABLE_SYSTEM_EXTENSION_DIRS='1' -DMOZ_WEBGL_CONFORMANT='1' -DMOZ_GAMEPAD='1' -DMOZ_CRASHREPORTER='1' -DMOZ_CRASHREPORTER_ENABLE_PERCENT='100' -DMOZ_UPDATER='1' -DENABLE_TESTS='1' -DGTEST_HAS_RTTI='0' -DMOZ_GMP_SANDBOX='1' -DMOZ_SANDBOX='1' -DMOZ_FEEDS='1' -DMOZ_HELP_VIEWER='1' -DMOZ_SAFE_BROWSING='1' -DMOZ_URL_CLASSIFIER='1' -DGL_PROVIDER_GLX='1' -DMOZ_STACKWALKING='1' -DMOZ_LOGGING='1' -DFORCE_PR_LOG='1' -DMOZ_GLUE_IN_PROGRAM='1' -DMOZ_REPLACE_MALLOC='1' -DMOZ_MEMORY='1' -DMOZ_MEMORY_LINUX='1' -DMOZ_SUITE='1' -DMOZ_MORK='1' -DHAVE_MOVEMAIL='1' -DMOZ_PAY='1' -DMOZ_SECUREELEMENT='1' -DHAVE___CXA_DEMANGLE='1' -DHAVE__UNWIND_BACKTRACE='1' -DJS_DEFAULT_JITREPORT_GRANULARITY='3' -DMOZ_OMNIJAR='1' -DMOZ_USER_DIR='".mozilla"' -DHAVE_FT_BITMAP_SIZE_Y_PPEM='1' -DHAVE_FT_GLYPHSLOT_EMBOLDEN='1' -DHAVE_FT_LOAD_SFNT_TABLE='1' -DHAVE_FONTCONFIG_FCFREETYPE_H='1' -DMOZ_TREE_PIXMAN='1' -DHAVE_STDINT_H='1' -DHAVE_INTTYPES_H='1' -DMOZ_TREE_CAIRO='1' -DMOZ_ENABLE_SKIA='1' -DUSE_SKIA='1' -DUSE_SKIA_GPU='1' -DMOZ_XUL='1' -DMOZ_PROFILELOCKING='1' -DENABLE_MARIONETTE='1' -DBUILD_CTYPES='1' -DMOZ_PLACES='1' -DMOZ_SOCIAL='1' -DMOZ_SERVICES_COMMON='1' -DMOZ_SERVICES_CRYPTO='1' -DMOZ_SERVICES_SYNC='1' -DMOZ_SERVICES_CLOUDSYNC='1' -DMOZ_BINARY_EXTENSIONS='1' -DMOZ_MACBUNDLE_ID='org.mozilla.seamonkey' -DMOZ_B2G_VERSION='"1.0.0"' -DMOZ_B2G_OS_NAME='""' -DMOZ_APP_UA_NAME='""' -DMOZ_APP_UA_VERSION='"2.42a1"' -DFIREFOX_VERSION='45.0a1' -DMOZILLA_OFFICIAL='1' -DMOZ_TELEMETRY_DISPLAY_REV='2' -DMOZ_DATA_REPORTING='1' -DMOZ_DLL_SUFFIX='".so"' -DHAVE_POSIX_FADVISE='1' -DHAVE_POSIX_FALLOCATE='1' -DXP_UNIX='1' -DMOZ_ACCESSIBILITY_ATK='1' -DATK_MAJOR_VERSION='2' -DATK_MINOR_VERSION='2' -DATK_REV_VERSION='0' -DA11Y_LOG='1' -DEXPOSE_INTL_API='1' -DENABLE_INTL_API='1' -DU_STATIC_IMPLEMENTATION='1' -DU_USING_ICU_NAMESPACE='0' -DMOZ_STATIC_JS='1' -DNO_NSPR_10_SUPPORT='1' -DAB_CD=en-US \ --format omni \ --removals /builds/slave/c-cen-t-lnx/build/suite/installer/removed-files.in \ \ \ \ \ --optimizejars \ \ package-manifest ../../dist ../../dist/seamonkey \ --non-resource defaults/messenger/mailViews.dat defaults/profile/panels.rdf defaults/profile/mimeTypes.rdf defaults/profile/chrome/userChrome-example.css defaults/profile/chrome/userContent-example.css Error: /builds/slave/c-cen-t-lnx/build/suite/installer/removed-files.in:755: Removal of packaged file(s): extensions/{972ce4c6-7e08-4474-a285-3208198ce6fd}.xpi Traceback (most recent call last): File "/builds/slave/c-cen-t-lnx/build/mozilla/toolkit/mozapps/installer/packager.py", line 406, in <module> main() File "/builds/slave/c-cen-t-lnx/build/mozilla/toolkit/mozapps/installer/packager.py", line 358, in main copier.add(mozpath.join(respath, 'removed-files'), removals) File "/tools/python27/lib/python2.7/contextlib.py", line 24, in __exit__ self.gen.next() File "/builds/slave/c-cen-t-lnx/build/mozilla/python/mozbuild/mozpack/errors.py", line 131, in accumulate raise AccumulatedErrors() mozpack.errors.AccumulatedErrors make[3]: *** [stage-package] Error 1 make[2]: *** [make-package] Error 2 make[3]: Leaving directory `/builds/slave/c-cen-t-lnx/build/objdir/suite/installer' make[2]: Leaving directory `/builds/slave/c-cen-t-lnx/build/objdir/suite/installer' make[1]: *** [default] Error 2 make[1]: Leaving directory `/builds/slave/c-cen-t-lnx/build/objdir/suite/installer' make: *** [package] Error 2 DEBUG: shell: unmounting all filesystems DEBUG: Executing command: umount -n /builds/mock_mozilla/mozilla-centos6-x86_64/root/dev/shm DEBUG: Child return code was: 0 DEBUG: Executing command: umount -n /builds/mock_mozilla/mozilla-centos6-x86_64/root/dev/pts DEBUG: Child return code was: 0 DEBUG: Executing command: umount -n /builds/mock_mozilla/mozilla-centos6-x86_64/root/tmp/ccache DEBUG: Child return code was: 0 DEBUG: Executing command: umount -n /builds/mock_mozilla/mozilla-centos6-x86_64/root/targetdata/ DEBUG: Child return code was: 0 DEBUG: Executing command: umount -n /builds/mock_mozilla/mozilla-centos6-x86_64/root/tmp/.X11-unix DEBUG: Child return code was: 0 DEBUG: Executing command: umount -n /builds/mock_mozilla/mozilla-centos6-x86_64/root/builds/git-shared DEBUG: Child retu
Looks like a fallout from bug 1216371
Bug 1216371 made it so that if MOZ_OMNIJAR is specified then the extensions in dist/bin/extensions are packed, except for those that have binary components. Bug 1216371 also made the default theme manifest loadable from a packed XPI in safe mode so Bug 1125689 isn't needed any more.
Assignee: nobody → philip.chee
Status: NEW → ASSIGNED
Attachment #8690365 - Flags: review?(iann_bugzilla)
status-seamonkey2.42: --- → affected
tracking-seamonkey2.42: --- → +
Depends on: 1216371
I can confirm that Seamonkey compiles fine with VS2013 and VS2015 using the patch. User agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:45.0) Gecko/20100101 Firefox/45.0 SeaMonkey/2.42a1 Build identifier: 20151121122151
(In reply to Frank-Rainer Grahl from comment #3) > I can confirm that Seamonkey compiles fine with VS2013 and VS2015 using the > patch. This patch is for make package or make installer, not make build
Severity: normal → blocker
Priority: -- → P1
>> This patch is for make package or make installer, not make build Ok, that's what I meant :) Standalone installer package builds fine with 'mozmake installer' FRG
(In reply to Philip Chee from comment #2) > Bug 1216371 also made the default theme manifest loadable from a packed XPI > in safe mode so Bug 1125689 isn't needed any more. Though that change might be reversed once they get rid of "heavyweight" theme support!
Attachment #8690365 - Flags: review?(iann_bugzilla) → review+
status-firefox45: affected → ---
Comment on attachment 8690365 [details] [diff] [review] Patch v1 Backout parts of Bug 1125689, Pack Classic, Fix fallout from Bug 1216371 Pushed to comm-central: https://hg.mozilla.org/comm-central/rev/8d13bd3c9e2d
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.42
Comment on attachment 8690365 [details] [diff] [review] Patch v1 Backout parts of Bug 1125689, Pack Classic, Fix fallout from Bug 1216371 Review of attachment 8690365 [details] [diff] [review]: ----------------------------------------------------------------- ::: suite/app/Makefile.in @@ +94,4 @@ > > pack-ext: $(STAGEDIST) > @echo "Packaging extensions..." > $(foreach dir,$(filter-out $(DONOTPACK),$(subst $(STAGEDIST)/,,$(wildcard $(STAGEDIST)/*))),$(_PACKAGE_EXTENSIONS)) Seems to me this part needs to be removed, since the packager now deals with creating the XPIs. ::: suite/installer/removed-files.in @@ +759,5 @@ > + @DIR_MACOS@extensions/{972ce4c6-7e08-4474-a285-3208198ce6fd}/chrome.manifest > + @DIR_MACOS@extensions/{972ce4c6-7e08-4474-a285-3208198ce6fd}/icon.png > + @DIR_MACOS@extensions/{972ce4c6-7e08-4474-a285-3208198ce6fd}/install.rdf > + @DIR_MACOS@extensions/{972ce4c6-7e08-4474-a285-3208198ce6fd}/preview.png > +#endif Note that removed-files can skip a lot of things these days. You probably don't need this change.
Attachment #8690365 - Flags: review-
(In reply to Mike Hommey [:glandium] from comment #8) > Seems to me this part needs to be removed, since the packager now deals with > creating the XPIs. Yes but the python packager uses the same funky algorithm that creates the omni.ja which normal zip utilities have difficulty with. Therefore we overwrite and repack using the standard GNUZip.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: