122683 - [rfe] Edit the QuickLaunch Installer Wizard Screen to spec

Status: VERIFIED FIXED

(SeaMonkey :: Installer, enhancement)

Description

[Gregg Landskov (gone)]

From the content spec posted at: 
http://client.mcom.com/machv/xpinstall/WizardContent.html

Screen 4 is the Quick Launch Screen.  The messaging UI should be updated to look
mostly like the image posted at:
http://www.mozilla.org/projects/ui/communicator/framework/quicklaunch/installer.png

Additional changes to the image...

The version shown (6.1b1) needs to be taken out, should just say:
'Netscape 6 Setup - Quick Launch'  

At the bottom, we will need the existing
<Back,  Next>, & Cancel buttons instead of the Close button shown on screenshot.

Comment 1

[Gregg Landskov (gone)]

reassigning to curt

Comment 2

[Curt Patrick (gone)]

Blake, rumor has it that you might be the person to get me a bitmap for the
dialog box which is mocked up in the link above.  The example is Netscape
specific but I'll need an equivalent bitmap for mozilla also.  Can you put this
together for me?

Comment 3

[Blake Ross]

The one to use for commercial is
http://lxr/commercial/source/themes/classic/communicator/icons/turbo-systray.gif
(can't be viewed with lxr, though).  I don't think Mozilla currently has an
image, but I can take a screenshot when I get a moment.

Comment 4

[Curt Patrick (gone)]

I found it and it looks good except:
- Windows dialogs like graphics to in .bmp format (unless Sean tells me
different).  Is that something you can fix for me?  There is some whizzy
conversion tool around but I'm not much into that and maybe you are?
- I need a similiar bmp for mozilla.

Comment 5

[Curt Patrick (gone)]

Attachment: Text changes for mozilla

We can go ahead and get the text changes checked in since the work without the
graphic and that is whole different bit of code anyway.

Comment 6

[Curt Patrick (gone)]

Attachment: Text changes for ns

Comment 7

[dprice (gone)]

r=dprice

Comment 8

[Daniel Veditz [:dveditz]]

Comment on attachment 69201 [details] [diff] [review]
Text changes for mozilla

>-IDC Turbo Mode=&Use Quick Launch for faster startup times
>+IDC Turbo Mode=When possible, &use Quick Launch to start Netscape faster
>+

I liked it better in the screen shot that had "when possible" at
the end. Putting it first, and especially with that comma, makes
the feature sound really dicey.

And of course you can't say "start Netscape" in the Mozilla build.
I'm pretty sure that's what resulted in the generic "for faster startup"
in the first place.

Comment 9

[Curt Patrick (gone)]

Well Duh to the Netscape reference in the mozilla patch!  The two config files
are completely independant of each other.  I can either use the ProductName
variable in either or both cases, which would end up being "Netscape 6" and
"Mozilla", or just hardcode whatever we want for each.

As to Dan's observations about the comma and placement of the "when possible"
substring, Jatin and/or Gregg, could I get a definitive decision on that?

BTW, while I'm looking this bug over again, Blake, I still need the two graphics
in bitmap format.  Thanks.

Comment 10

[Lori Kaplan]

Blake and Curt-has Marlon seen and processed the graphics? We should make sure
that  they have the right color palette, optimization etc. 

Comment 11

[Jatin Billimoria]

I agree with Dan's comment number #8.

Comment 12

[Curt Patrick (gone)]

So that means we go back to the original:

"Use Quick Launch for faster startup times when possible."

without any use of the product name?

Comment 13

[Curt Patrick (gone)]

Blake, what is the status on getting that mozilla version of this graphic?  I've
gotten the ns graphic converted to a bmp, but I cannot wrap this bug up until I
have a mozilla graphic.  I'll take it as a gif also, if that is what works for
you...

And I haven't seen any response from Marlon regarding Lori's comments.  If I can
get get this mozilla graphic from Blake I'm going to drive on with what I've got
and we can always check in improved graphics easily enough once weve got the
dialog written to use them.

Comment 14

[marlon bishop]

lori, curt - the image that blake provided is fine.   for the mozilla version i am not sure what to use, they seem to be going through legal 
problems with logo usage, so we should probably check with Dawn Endico on that end. 

Comment 15

[Curt Patrick (gone)]

Attachment: 0.1 for mozilla

I've also got a bitmap to checkin, but I don't think bugzilla likes you to
attach bmp's.  Do you need to see it?  If so, where shall I put it.

BTW, I noticed that VC wants to use DIALOGEX instead of DIALOG in the rc file. 
A bit of research turned up the fact that Microsoft says DIALOG is obsolete. 
Should we start using DIALOGEX instead?

Comment 16

[Curt Patrick (gone)]

Attachment: 0.1 for ns

Just text changes (and the same deal regarding the bmp as for mozilla).

Comment 17

[Daniel Veditz [:dveditz]]

Talk to sean about DIALOGEX -- there's some localization tool reason he
meticulously changes all the generated DIALOGEX back to DIALOG.

Comment 18

[Sean Su]

Comment on attachment 71619 [details] [diff] [review]
0.1 for mozilla

r=ssu

Comment 19

[Sean Su]

Comment on attachment 71620 [details] [diff] [review]
0.1 for ns

you need to update setuprsc/makefile.mak to copy the new bitmap
(turbo-systray.bmp) over to the ns tree.

Take a look at setuprsc\makefile.mak in the ns tree.

Comment 20

[Curt Patrick (gone)]

mozilla and ns are using different bmp's so I don't really want to copy the
mozilla bmp over, do I?

Comment 21

[Sean Su]

Comment on attachment 71620 [details] [diff] [review]
0.1 for ns

sorry, I assumed they were the same.  You are correct.	the bmp file does not
need to be copied over since they are different.

r=ssu

Comment 22

[Daniel Veditz [:dveditz]]

Comment on attachment 71619 [details] [diff] [review]
0.1 for mozilla

sr=dveditz

Comment 23

[Daniel Veditz [:dveditz]]

Comment on attachment 71620 [details] [diff] [review]
0.1 for ns

sr=dveditz

Comment 24

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Comment on attachment 71619 [details] [diff] [review]
0.1 for mozilla

a=dbaron for trunk checkin

Comment 25

[Curt Patrick (gone)]

Checked in the mozilla patch.  Still need a= for the ns patch, though.

Comment 26

[Daniel Veditz [:dveditz]]

AFAIK the ns tree has not gone into "approval-required" mode, the "nsbeta1+" 
assigned by a manager type is approval enough until we get closer to the 
deadline. But "a=dveditz" for the ns patch if it makes you feel better ;-)

Comment 27

[Curt Patrick (gone)]

I do feel better, and more in informed as well...which is probably more
important.  I've checked in all patches now.

Comment 28

[Grace Bush]

The Mozilla installer looks fine but commercial image is broken- see bug 129123
Waiting for N6 to be fixed before verifying

Comment 29

[Grace Bush]

broken N6 image bug logged in bugscape bug 12382
verifying moz fixed

Comment 30

[Curt Patrick (gone)]

I failed to check in the bmps as binary files (i.e. -kb).  So I just cvs rm'ed
both of the new bitmaps and did a "cvs add -kb" on both.  They both appear to be
correct after checking them out again so I think this will fix the bad image for
ns.  Mozilla should be rechecked to make sure I did screw that up by "fixing"
the problem.

Comment 31

[Brant Gurganus]

[RFE] is deprecated in favor of severity: enhancement.  They have the same meaning.