Closed
Bug 1226875
Opened 10 years ago
Closed 10 years ago
Remove nsIFrame::GetFirstChild() and nsIFrame::GetLastChild()
Categories
(Core :: Layout, defect)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla45
| Tracking | Status | |
|---|---|---|
| firefox45 | --- | fixed |
People
(Reporter: TYLin, Assigned: TYLin)
References
Details
Attachments
(2 files)
See the comment [1] from bz and mats for removing nsIFrame::GetFirstChild() and nsIFrame::GetLastChild(). Hence this bug.
[1] https://dxr.mozilla.org/mozilla-central/source/layout/generic/nsIFrame.h?from=nsIFrame%3A%3AGetFirstChild#1070,1074
|
Assignee | |
Comment 1•10 years ago
|
||
Bug 1226875 - Remove nsIFrame::GetFirstChild(). r=mats
Attachment #8690423 -
Flags: review?(mats)
|
|
Assignee | |
Comment 2•10 years ago
|
||
Bug 1226875 - Remove nsIFrame::GetLastChild(). r=mats
Attachment #8690424 -
Flags: review?(mats)
|
||
Comment 3•10 years ago
|
||
Comment on attachment 8690423 [details]
MozReview Request: Bug 1226875 - Remove nsIFrame::GetFirstChild(). r=mats
https://reviewboard.mozilla.org/r/25857/#review23571
Attachment #8690423 -
Flags: review?(mats) → review+
|
|
||
Comment 4•10 years ago
|
||
Comment on attachment 8690424 [details]
MozReview Request: Bug 1226875 - Remove nsIFrame::GetLastChild(). r=mats
https://reviewboard.mozilla.org/r/25859/#review23573
Attachment #8690424 -
Flags: review?(mats) → review+
|
|
||
Comment 5•10 years ago
|
||
I think we should remove GetFirstPrincipalChild() too, btw.
|
|
Assignee | |
Comment 6•10 years ago
|
||
mats, thank you for the review. Filed bug 1227927 for comment 5.
Keywords: checkin-needed
|
||
Comment 7•10 years ago
|
||
Hi, this failed to apply:
applying a6c462a0f118
patching file layout/generic/nsIFrame.h
Hunk #1 FAILED at 1061
1 out of 1 hunks FAILED -- saving rejects to file layout/generic/nsIFrame.h.rej
patch failed to apply
abort: fix up the merge and run hg transplant --continue
could you take a look, thanks!
Flags: needinfo?(tlin)
Keywords: checkin-needed
|
|
Assignee | |
Comment 9•10 years ago
|
||
Tomcat, I've rebased the patches and land it myself. Thanks.
Flags: needinfo?(tlin)
|
|
||
Comment 10•10 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/ad83a815314e
https://hg.mozilla.org/mozilla-central/rev/298051dbb67c
Status: NEW → RESOLVED
Closed: 10 years ago
status-firefox45:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
You need to log in
before you can comment on or make changes to this bug.
Description
•