Closed Bug 1226875 Opened 4 years ago Closed 4 years ago

Remove nsIFrame::GetFirstChild() and nsIFrame::GetLastChild()

Categories

(Core :: Layout, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla45
Tracking Status
firefox45 --- fixed

People

(Reporter: TYLin, Assigned: TYLin)

References

Details

Attachments

(2 files)

See the comment [1] from bz and mats for removing nsIFrame::GetFirstChild() and nsIFrame::GetLastChild(). Hence this bug.

[1] https://dxr.mozilla.org/mozilla-central/source/layout/generic/nsIFrame.h?from=nsIFrame%3A%3AGetFirstChild#1070,1074
Bug 1226875 - Remove nsIFrame::GetFirstChild(). r=mats
Attachment #8690423 - Flags: review?(mats)
Bug 1226875 - Remove nsIFrame::GetLastChild(). r=mats
Attachment #8690424 - Flags: review?(mats)
Comment on attachment 8690423 [details]
MozReview Request: Bug 1226875 - Remove nsIFrame::GetFirstChild(). r=mats

https://reviewboard.mozilla.org/r/25857/#review23571
Attachment #8690423 - Flags: review?(mats) → review+
Comment on attachment 8690424 [details]
MozReview Request: Bug 1226875 - Remove nsIFrame::GetLastChild(). r=mats

https://reviewboard.mozilla.org/r/25859/#review23573
Attachment #8690424 - Flags: review?(mats) → review+
I think we should remove GetFirstPrincipalChild() too, btw.
Blocks: 1227927
mats, thank you for the review. Filed bug 1227927 for comment 5.
Keywords: checkin-needed
Hi, this failed to apply:

applying a6c462a0f118
patching file layout/generic/nsIFrame.h
Hunk #1 FAILED at 1061
1 out of 1 hunks FAILED -- saving rejects to file layout/generic/nsIFrame.h.rej
patch failed to apply
abort: fix up the merge and run hg transplant --continue

could you take a look, thanks!
Flags: needinfo?(tlin)
Keywords: checkin-needed
Tomcat, I've rebased the patches and land it myself. Thanks.
Flags: needinfo?(tlin)
https://hg.mozilla.org/mozilla-central/rev/ad83a815314e
https://hg.mozilla.org/mozilla-central/rev/298051dbb67c
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
You need to log in before you can comment on or make changes to this bug.