1227080 - [NGA Contacts] When launching a pick activity we get the ice group and no close button

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Isabel Rios[:isabel_rios]]

Attachment: 2015-11-23-12-04-54.png

Pre-requisites: have at least 500 contacts

[Procedure]
Go to contacts Settings -> Set ICE Contacts -> Toggle on
Tap on Select a contact

[Actual]
1. Nothing happens when tapping on Select a contact option
2. The contact list is shown with already the ice contact icon on the top (see screenshot attached)

[Expected]
1. The contact list should be shown so that a contact can be picked as ICE contact
2. Since no contact has been selected yet, the contact icon should not appear

Comment 1

[Isabel Rios[:isabel_rios]]

Attachment: Empty ICE contact list

Comment 2

[GitHub Autolander Bot]

Attachment: [gaia] arcturus:bug-1227080 > mozilla-b2g:nga

Comment 3

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8692600 [details] [review]
[gaia] arcturus:bug-1227080 > mozilla-b2g:nga

We were not using the ActivityHandler class, since the activity is handled now in the ListController.

I'll open a bug to get ride of the ActivityHandler in the new views.

Comment 4

[Maria Angeles Oteo (:oteo)]

> I'll open a bug to get ride of the ActivityHandler in the new views.

Opened bug 1228394

Comment 5

[Fernando Jiménez Moreno [:ferjm]]

nga: https://github.com/mozilla-b2g/gaia/commit/19af19e09a494fc8cbf30d037face358d625c73e

Comment 6

[Isabel Rios[:isabel_rios]]

Attachment: set_ice_log.txt

Comment 7

[Isabel Rios[:isabel_rios]]

Something is not working fine. I cannot select a contact to be an ICE contact. When tapping on the Select a contact, once the ICE contact 1 toggle is ON, the contact list is not shown.

Attached a log file. Hope it helps.

Comment 8

[Isabel Rios[:isabel_rios]]

Attachment: set_ice_log.txt

Comment 9

[Isabel Rios[:isabel_rios]]

I flash my flame with latest master and the make install-gaia, and this is what I saw, BUT flashing it and then make reset-gaia, then this bug is not present and would be solved.

I would expect the same behavior but seems that the branch is not correctly applied only with the install.

Francisco, I am sorry for the noise. Will check the other bugs an update them.