1227116 - [e10s] Cmd+click is not working on links in inline SVG

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[Cornel Ionce [:noni]]

This is a follow-up issue for bug 1025568.

Attempting to open the link inside the inline SVG in a new tab with Cmd+click is not working.

This is e10s specific, it does not reproduce with e10s off.

Comment 1

[:Gijs (he/him)]

(In reply to Cornel Ionce [QA] from comment #0)
> This is a follow-up issue for bug 1025568.
> 
> Attempting to open the link inside the inline SVG in a new tab with
> Cmd+click is not working.
> 
> This is e10s specific, it does not reproduce with e10s off.

Gah. This doesn't make sense, bug 1025568 comment 1 implied this didn't happen with e10s enabled.

Ryan, can you find a new regression window? If I broke this on e10s then maybe bug 1025568 needs to be backed out...

Comment 2

[Robert Longson [:longsonr]]

Is this connected to bug 1218249

Comment 3

[:Gijs (he/him)]

(In reply to Robert Longson from comment #2)
> Is this connected to bug 1218249

So comment #0 linked to the wrong bug and this is a leftover from bug 1217586 which looks like a dupe of bug 1218249 (or rather, vice versa). I don't understand offhand why bug 1217586 would have fixed the cmd-enter case but not the cmd-click case.

Comment 4

[:Gijs (he/him)]

Attachment: MozReview Request: Bug 1227116 - fix cmd-click on links as well, r?felipe

Bug 1227116 - fix cmd-click on links as well, r?felipe

Comment 5

[:Gijs (he/him)]

I haven't yet verified this, but from debugging I'm pretty sure I just broke this by not putting this in the actual nested if block. :-(

(In reply to :Gijs Kruitbosch from comment #3)
> (In reply to Robert Longson from comment #2)
> > Is this connected to bug 1218249
> 
> So comment #0 linked to the wrong bug and this is a leftover from bug
> 1217586 which looks like a dupe of bug 1218249 (or rather, vice versa). I
> don't understand offhand why bug 1217586 would have fixed the cmd-enter case
> but not the cmd-click case.

At this point we should probably dupe bug 1218249 here.

Comment 7

[:Felipe Gomes (needinfo for replies!)]

Comment on attachment 8690987 [details]
MozReview Request: Bug 1227116 - fix cmd-click on links as well, r?felipe

https://reviewboard.mozilla.org/r/26041/#review23413

Ah I noticed this on the original but for some odd reason thought it was intentional :(

Comment 8

[:Gijs (he/him)]

(In reply to :Gijs Kruitbosch from comment #5)
> (In reply to :Gijs Kruitbosch from comment #3)
> > (In reply to Robert Longson from comment #2)
> > > Is this connected to bug 1218249
> > 
> > So comment #0 linked to the wrong bug and this is a leftover from bug
> > 1217586 which looks like a dupe of bug 1218249 (or rather, vice versa). I
> > don't understand offhand why bug 1217586 would have fixed the cmd-enter case
> > but not the cmd-click case.
> 
> At this point we should probably dupe bug 1218249 here.

Egh, I got confused by some of the comments there. I think this bug is the bug implied by bug 1218249 comment 3 and bug 1218249 comment 4. I expect the fix would involve changing the loop I'm modifying here to be more picky about which elements' xlink:href attributes it interprets as a link to somewhere.

Comment 9

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/9d1be94ff95a

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/9d1be94ff95a

Comment 11

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Cornel, could you please verify this fix works as expected on a latest Nightly build? Thanks!

Comment 12

[Mihai Boldan, Desktop QA [:mboldan]]

Managed to reproduce this issue on Mac OS X 10.11 using Firefox 43.0a1 (27-08-2015).
This issue is no longer reproducible on Mac OS X 10.11 using Latest Nightly 45.0a1 (2015-12-04).