Closed Bug 1227117 Opened 4 years ago Closed 4 years ago

Show Images > 'Never' does not convey the 'on-demand' nature of the setting

Categories

(Firefox for Android :: Settings and Preferences, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 45
Tracking Status
firefox45 --- fixed
firefox46 --- verified

People

(Reporter: mfinkle, Assigned: jonalmeida)

References

Details

Attachments

(1 file)

We changed the copy and style of the setting for the Tap-to-view feature. We now use "Show image" with (Always, Only on Wi-Fi, Never) options.

The problem is "Never" is not really never. "Never" is really "Long press to show" or "Blocked".

"Never" does give me any indication that I can manually choose to view the image.
NI'ing Anthony to noodle on it. I think "Blocked" may be a good choice.
Flags: needinfo?(alam)
Hm, that's true. We also mentioned this as a drawback when changing the copy to better suite a "tri-state".

I think "Always" and "Never" fits in better with the other prefs and also reads better in the same sentence though. 

E.g. "Show images? Never" as opposed to "Show images? Blocked". But, I can see how "Show images, Blocked" would be OK too.

Could you clarify what you mean by "on-demand nature"?
Flags: needinfo?(alam) → needinfo?(mark.finkle)
(In reply to Anthony Lam (:antlam) from comment #2)

> Could you clarify what you mean by "on-demand nature"?

"on-demand" means a person can choose to view the blocked image after the page loads, when they feel it's relevant. "on-demand" was shorter to type than "long press and pick 'show image'"
Flags: needinfo?(mark.finkle)
(In reply to Anthony Lam (:antlam) from comment #2)
> Hm, that's true. We also mentioned this as a drawback when changing the copy
> to better suite a "tri-state".
> 
> I think "Always" and "Never" fits in better with the other prefs and also
> reads better in the same sentence though.

I don't mind having "Never", but never means never. I say "Never" would mean "We hide images and don't give you a way to unblock them". That is what Mozilla China does right now. Gecko does have a preference for never showing images.

In our case "Never" does not mean never. Let's not call it "Never".

> E.g. "Show images? Never" as opposed to "Show images? Blocked". But, I can
> see how "Show images, Blocked" would be OK too.

We could use "Block"
(In reply to Mark Finkle (:mfinkle) from comment #4)
> I don't mind having "Never", but never means never. I say "Never" would mean
> "We hide images and don't give you a way to unblock them". That is what
> Mozilla China does right now. Gecko does have a preference for never showing
> images.

Yeah that's a fair point, perhaps we should never say "never". But that's out of scope

> In our case "Never" does not mean never. Let's not call it "Never".
> 
> > E.g. "Show images? Never" as opposed to "Show images? Blocked". But, I can
> > see how "Show images, Blocked" would be OK too.
> 
> We could use "Block"

Show image
 - Always
 - Only on Wi-Fi
 - Blocked

Works for me!
Assignee: nobody → jonalmeida942
(In reply to Anthony Lam (:antlam) from comment #5)
> (In reply to Mark Finkle (:mfinkle) from comment #4)
> > I don't mind having "Never", but never means never. I say "Never" would mean
> > "We hide images and don't give you a way to unblock them". That is what
> > Mozilla China does right now. Gecko does have a preference for never showing
> > images.
> 
> Yeah that's a fair point, perhaps we should never say "never". But that's
> out of scope
> 
> > In our case "Never" does not mean never. Let's not call it "Never".
> > 
> > > E.g. "Show images? Never" as opposed to "Show images? Blocked". But, I can
> > > see how "Show images, Blocked" would be OK too.
> > 
> > We could use "Block"
> 
> Show image
>  - Always
>  - Only on Wi-Fi
>  - Blocked
> 
> Works for me!

Anthony, just wanted to make sure if you meant for "Only on Wi-Fi" to be "Only over Wi-Fi" since the latter is what we're currently using.
Flags: needinfo?(alam)
Bug 1227117 - 'Never' -> 'Blocked' for Show Images option r?mfinkle
Attachment #8696313 - Flags: review?(mark.finkle)
Attachment #8696313 - Flags: review?(mark.finkle) → review+
Comment on attachment 8696313 [details]
MozReview Request: Bug 1227117 - 'Never' -> 'Blocked' for Show Images option r?mfinkle

https://reviewboard.mozilla.org/r/27311/#review24701

LGTM

And "Only over Wi-Fi" seems to be what we use in other places, so we are OK:
http://mxr.mozilla.org/mozilla-central/search?string=%22Only%2Bover%2BWi-Fi%22
https://hg.mozilla.org/mozilla-central/rev/2af820818699
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 45
Flags: needinfo?(alam)
Show images has three options:
 - Always
 - Only on Wi-Fi
 - Blocked

Verified as fixed using:
Device: Nexus 6 (Android 6.0)
Build: Firefox for Android 46.0a1 (2015-12-22)
You need to log in before you can comment on or make changes to this bug.