Closed Bug 1227184 Opened 9 years ago Closed 9 years ago

[gatt] Fail on the wrong version of node.

Categories

(Testing Graveyard :: JSMarionette, defect)

Product:
Testing Graveyard
Component:
JSMarionette
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: hub, Assigned: aus)

References

Details

Attachments

(1 file)

[gaia] nullaus:bug1227184 > mozilla-b2g:master
46 bytes, text/x-github-pull-request
hub
: review+
Details | Review 
When installing all the node dependencies to run MarionetteJS, we should hard fail if the wrong version of Node is being used. It took me a bit this morning to figure out that stuff failed because I still ran 0.10.36.... And I already had clues about that kind of error.

So imagine a new contributor...
Assignee: nobody → aus
Blocks: 1161727
Status: NEW → ASSIGNED
Summary: Fail on the wrong version of node. → [gatt] Fail on the wrong version of node.
Attachment #8691536 - Flags: review?(hub)
Comment on attachment 8691536 [details] [review]
[gaia] nullaus:bug1227184 > mozilla-b2g:master

ship it!
Attachment #8691536 - Flags: review?(hub) → review+
Commit (master): https://github.com/mozilla-b2g/gaia/commit/07cac3b26ee06c7dd30eeac43571c5f2dfc18947

Fixed.
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Product: Testing → Testing Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: