Autophone - use new browser start logcat message to determine start time

RESOLVED FIXED

Status

Testing
Autophone
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: bc, Assigned: bc)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/db9e19d4bbb9 provides a means of determining when Fennec has started. We should begin using this on trunk and fall back to the older methods if it is not found.
(Assignee)

Comment 1

2 years ago
taking
Assignee: nobody → bob
Status: NEW → ASSIGNED
(Assignee)

Comment 2

2 years ago
The current message appears after Throbber start so it isn't useful. See bug 1214810 comment 5
(Assignee)

Updated

2 years ago
Blocks: 1233025
(Assignee)

Comment 3

2 years ago
Created attachment 8699602 [details] [diff] [review]
bug-1227188-v1.patch

Adds support for the new Fennec application start message. This will increase the detected start time leading to a apparent improvement in Throbber start, stop which is solely due to this change in measurement.

Note, I also included a fix for detecting Start proc on Android 5.1 where the pid and user are included in the Start proc message. Example: Start proc 3682:org.mozilla.fennec_bclary/u0a54 for activity org.mozilla.fennec_bclary/org.mozilla.gecko.webapp.Dispatcher
Attachment #8699602 - Flags: review?(gbrown)
Comment on attachment 8699602 [details] [diff] [review]
bug-1227188-v1.patch

Review of attachment 8699602 [details] [diff] [review]:
-----------------------------------------------------------------

::: tests/s1s2test.py
@@ +283,5 @@
>                                              (logcat_prefix, throbber_prefix))
>          re_throbber_stop_time = re.compile('%s %s stop' %
>                                             (logcat_prefix, throbber_prefix))
> +        self.loggerdeco.debug(
> +            'analyze_logcat: re_start_time: %s' % re_start_time.pattern)

This seems like a low-value thing to log.
Attachment #8699602 - Flags: review?(gbrown) → review+
(Assignee)

Comment 5

2 years ago
Ok. removed the low value log messages.

https://github.com/mozilla/autophone/commit/90a7885549f32facffd6bb2829c679dc534dd5c2
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.