1227277 - Disabling b2g builds on project branches other than pine

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Selena Deckelmann :selenamarie :selena]

We need to disable b2g builds on the following branches unless there's some B2G-specific reason for running them: 

alder
ash
cedar
cypress
fx-team
gum
jamun
larch
maple
oak

Based on feedback in https://public.etherpad-mozilla.org/p/b2g-build-audit B2G is only using pine.

This reduces our build storage requirements by about 80 GB/day.

Comment 1

[Alin Selagea [:aselagea]]

Attachment: bug_1227277.patch

Comment 2

[Alin Selagea [:aselagea]]

Attachment: builder_diff.txt

Comment 3

[Kim Moir [:kmoir] ET]

Comment on attachment 8692027 [details] [diff] [review]
bug_1227277.patch

This is works, however, I think a better solution would be to iterate over the values in ACTIVE_PROJECT_BRANCHES and if it's not in pine, disable it.  This way we don't have two sources of truth if the list of  ACTIVE_PROJECT_BRANCHES  changes from the list you have defined.

Comment 4

[Alin Selagea [:aselagea]]

Attachment: bug_1227277.patch

Updated patch. 

Thanks for suggestions Kim!

Comment 5

[Alin Selagea [:aselagea]]

Attachment: builder_diff.txt

Comment 6

[Kim Moir [:kmoir] ET]

Comment on attachment 8692963 [details] [diff] [review]
bug_1227277.patch

The build failed

https://travis-ci.org/mozilla/build-buildbot-configs/jobs/93530737

The reason is that there are still test builders associated with these builds and they need to be removed.  So this patch is okay but we also need a patch to remove the associated test builders.

Comment 7

[Alin Selagea [:aselagea]]

Attachment: bug_1227277.patch

okay, let's see if this works :)

Comment 8

[Alin Selagea [:aselagea]]

Attachment: builder_diff.txt

Comment 9

[Alin Selagea [:aselagea]]

Attachment: tester_diff.txt

Comment 10

[Kim Moir [:kmoir] ET]

Comment on attachment 8693016 [details] [diff] [review]
bug_1227277.patch

mozilla-inbound and b2g-inbound are not listed among the branches where you want to remove the builders 

https://bugzilla.mozilla.org/show_bug.cgi?id=1227277#c0

Also you can remove the bits like this 
+# Disabled for bug 1227277
+# BRANCHES['alder']['branch_name'] = "Alder"
+# BRANCHES['alder']['repo_path'] = "projects/alder"... entirely instead of just commenting them out.  If we ever need to add them back we can just look at this bug.

Comment 11

[Kim Moir [:kmoir] ET]

You are correct ACTIVE_PROJECT_BRANCHES specifies mozilla-inbound, fx-team and b2g-inbound.  However, according to comment #0, we don't want to disable on b2g-inbound or mozilla-inbound.

So you could do something like this
B2GTWIGS = [x for x in ACTIVE_PROJECT_BRANCHES if x not in ('mozilla-inbound', 'b2g-inbound', 'pine')]

as is here
http://hg.mozilla.org/build/buildbot-configs/file/tip/mozilla-tests/config.py#l65

to further reduce the list of branches from the ACTIVE_BRANCHES that you want to disable

Comment 12

[Alin Selagea [:aselagea]]

Attachment: bug_1227277.patch

Updated patch.

Comment 13

[Alin Selagea [:aselagea]]

Attachment: tester_diff.txt

Comment 14

[Alin Selagea [:aselagea]]

Attachment: builder_diff.txt

Comment 15

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

These need to be turned back on for fx-team, as it is NOT a project branch, but instead a co-equal branch with mozilla-inbound and b2g-inbound.

Comment 16

[Phil Ringnalda (:philor)]

fx-team is closed, since nothing landed there can merge to m-c now.

Comment 17

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

I've backed out the offending patch and cherry-picked it to production to get things reopened over the weekend. I'm almost positive https://pastebin.mozilla.org/8853890 is all that would be needed (on top of the original patch) to get things successfully resolved here.

Comment 18

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Attachment: Original patch but don't disable fx-team

And that unified patch would be this.

Comment 19

[Nick Thomas [:nthomas] (UTC+12)]

I'm likely to need them back on ash this week, will take care of that when I need it.

Comment 20

[Kim Moir [:kmoir] ET]

Comment on attachment 8696135 [details] [diff] [review]
Original patch but don't disable fx-team

This was landed here 
http://hg.mozilla.org/build/buildbot-configs/rev/6bac4fc6f593
and merged to production a week or so ago