12273 - GtkMozilla widget won't build in separate build tree

Status: VERIFIED FIXED

(SeaMonkey :: Build Config, defect, P3)

Description

[Kenneth Herron]

The GtkMozilla embedded mozilla widget doesn't configure properly when building
in a separate directory from the source.  The Makefile in mozilla/webshell/embed
presumes that there will be a subdirectory called 'gtk' and that this subdir
will contain the gtkmozilla configure script; neither of these are true after
mozilla's configure process completes.  Attached are two diffs and one file
which corrects this:

1) mozilla.mk.in: Goes in mozilla/webshell/embed/gtk.  Used by the makefile
   in .../embed to run gtkmozilla's configure correctly.
2) Makefile.in patch:  To be applied to mozilla/webshell/embed/Makefile.in.
3) allmakefiles.sh patch: Adds mozilla.mk to the list of files configured by
   mozilla, also forcing the .../embed/gtk directory to be created.  While
   dinking with allmakefiles.sh, I also discovered that a few files were
   listed twice; the patch removes them.

Comment 1

[Kenneth Herron]

Attachment: mozilla/webshell/embed/gtk/mozilla.mk.in

Comment 2

[Kenneth Herron]

Attachment: mozilla/webshell/embed/Makefile.in patch

Comment 3

[Kenneth Herron]

Attachment: mozilla/allmakefiles.sh patch

Comment 4

[ramiro]

Thats a good idea, using mozilla.mk.  Ill check it in soon.

thanks

Comment 5

[ramiro]

Looks like [e-mail] checked in some fixes.  I also checked in some
linking fixes for this.  Marking fixed.