1227305 - ReferenceError: can't access lexical declaration `max' before initialization causes "DOM Inspector" to stop working

Status: RESOLVED FIXED

(Other Applications :: DOM Inspector, defect)

Description

[Alice0775 White]

Steps To Reproduce:
1. Disabled e10s
2. Install "Dom Inspector" and restart
3. Open with "Dom Inspector"
   --- observe Browser Console
4. Optionally, Right click on a element in Dom Tree
   "Delete" context menu is not enabled.

Actual Results:
ReferenceError: can't access lexical declaration `max' before initialization
DVr_GetSelectedIndexes() dom.js:1589
DVr_GetSelectedNodes() dom.js:1570
DVr_IsCommandEnabled() dom.js:236
updateCommand() inspector.xml:159
updateAllCommands() inspector.xml:140
onxblfocus() inspector.xml:386
notifyViewerReady() inspector.xml:577
DVr_initialize() dom.js:177
DOMViewer_initialize() dom.js:45
1 dom.js:1589:31


Expected Results:
No error,
"Delete" context menu should be enabled at step4.


Regression window:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=ea3f6bb82e6c69f514fab728ed2be8e38ccfd256&tochange=ce0741b494a7

Regressed by: Bug 1216623

Comment 1

[Philip Chee]

Attachment: Patch v1.0 Possible fix.

Comment 2

[Philip Chee]

https://hg.mozilla.org/dom-inspector/rev/ef9c663f4e6d

Comment 3

[:aceman]

Hi, how does this landing align with the Inspector releases? Where can we expect this to be shipped in a relase?

Comment 4

[Philip Chee]

(In reply to :aceman from comment #3)
> Hi, how does this landing align with the Inspector releases? Where can we
> expect this to be shipped in a release?
Usually we release a new version when:
1. We have enough changes to justify a new release, or
2. We have one or more compatibility fixes due to Gecko changes in newer Firefoxes.

I guess this bug would qualify as #2.

Comment 6

[Axel Grude [:realRaven]]

Can somebody attach a working build of the xpi please? I wasn't able to build one (stripping META-inf and zipping as usual did not do the job and caused the tool menu to vanish)

Comment 7

[Axel Grude [:realRaven]]

(In reply to Axel Grude [:realRaven] from comment #6)
> Can somebody attach a working build of the xpi please? I wasn't able to
> build one (stripping META-inf and zipping as usual did not do the job and
> caused the tool menu to vanish)

Sorry I meant tool menu entry for the DOM inspector.

Comment 8

[Philip Chee]

Attachment: [e-mail]

(In reply to Axel Grude [:realRaven] from comment #6)
> Can somebody attach a working build of the xpi please? I wasn't able to
> build one (stripping META-inf and zipping as usual did not do the job and
> caused the tool menu to vanish)

Comment 9

[Axel Grude [:realRaven]]

1) Works in Release Version of Firefox
   result: success

2a) I cannot test in Fx beta 47.0b3 because we cannot bypass Addons with missing signatures anymore so it refused to install :( - unfortunately the promised unbranded versions are no available online
    result: N/A  no test result available.

2b) Tested in Thunderbird 45.1 beta - it fixes the "max" problem and I am able to cut/paste DOM nodes. 
   result: SUCCESS

3) Trying to test in developer edition  v 48.0a2
  there seems to be a fresh bug there which leads to the DOM inspector not being shown. I will raise that one separately when I get time.
    result: N/A - no test result available.

TypeError: content is null
oncommand()browser.xul:1
1browser.xul:1:1

Comment 10

[Axel Grude [:realRaven]]

I keep getting needinfo feedback request mails although I cleared the dlag. can somebody advise what to do about this?

Comment 11

[:aceman]

You still have feedback request on attachment https://bugzilla.mozilla.org/attachment.cgi?id=8750733 . Set in comment 8. You only cleared the needinfo flag.

Comment 12

[Axel Grude [:realRaven]]

Comment on attachment 8750733 [details]
[e-mail]

Looks good to me. When are you releasing?