Closed Bug 1227347 Opened 5 years ago Closed 4 years ago

Remove whitelisting of CompositorChild leaks for XPCOM and LSan leak checkers

Categories

(Testing :: Mochitest, defect)

defect
Not set
normal

Tracking

(firefox48 fixed, firefox49 fixed)

RESOLVED FIXED
mozilla49
Tracking Status
firefox48 --- fixed
firefox49 --- fixed

People

(Reporter: mccr8, Assigned: mccr8)

References

(Blocks 1 open bug)

Details

Attachments

(3 files)

Once bug 1215265 is fixed, we should be able to remove a number of whitelisted leaks from the XPCOM and LSan leak checkers.
Depends on: 1262898
I'm not sure how to do this but we should be able to do it now!
Flags: needinfo?(continuation)
(In reply to Bas Schouten (:bas.schouten) from comment #1)
> I'm not sure how to do this but we should be able to do it now!

Great! I'll see what the Windows leak situation looks like. Thanks to everybody who worked on this. I know it was a big pain to fix.
Flags: needinfo?(continuation)
It seems like these were fixed by making graphics IPC shut down properly.

try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=b485093f55bd
Attachment #8745082 - Flags: review?(erahm)
Blocks: LSan
Comment on attachment 8745082 [details] [diff] [review]
part 1 - Remove IPC-related LSan suppressions.

Review of attachment 8745082 [details] [diff] [review]:
-----------------------------------------------------------------

r=me
Attachment #8745082 - Flags: review?(erahm) → review+
This patch removes all object-based leak suppressions, but leaves the infrastructure in place.

The next patch removes the infrastructure. I don't want to leave it in place, both because it is weird to leave around and to discourage people from using it. But I am landing it in a separate patch to make it easier to add back if needed in the future.

Linux and Windows try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=bb76c6392eeb
Attachment #8745382 - Flags: review?(erahm)
This is just constant folding expectedLeaks.
Attachment #8745383 - Flags: review?(erahm)
Comment on attachment 8745382 [details] [diff] [review]
part 2 - Remove leak suppressions for content processes.

Review of attachment 8745382 [details] [diff] [review]:
-----------------------------------------------------------------

This is great! r=me
Attachment #8745382 - Flags: review?(erahm) → review+
Comment on attachment 8745383 [details] [diff] [review]
part 3 - Remove object-count leak suppression infrastructure.

Review of attachment 8745383 [details] [diff] [review]:
-----------------------------------------------------------------

r=me.
Attachment #8745383 - Flags: review?(erahm) → review+
I'm just going to land this and hope that Ash is okay.
Ryan, does this look okay on Ash? Also, I know you aren't normally doing uplifts, but would you mind uplifting this to Aurora? It is test-only so I don't think it needs an uplift request. Thanks.
Flags: needinfo?(ryanvm)
Ryan said this looks fine on Ash. Wes, maybe you could uplift this to Aurora? Thanks.
Flags: needinfo?(wkocher)
Flags: needinfo?(wkocher)
Flags: needinfo?(ryanvm)
Whiteboard: [checkin-needed-aurora]
You need to log in before you can comment on or make changes to this bug.