Closed
Bug 1227347
Opened 8 years ago
Closed 8 years ago
Remove whitelisting of CompositorChild leaks for XPCOM and LSan leak checkers
Categories
(Testing :: Mochitest, defect)
Testing
Mochitest
Tracking
(firefox48 fixed, firefox49 fixed)
RESOLVED
FIXED
mozilla49
People
(Reporter: mccr8, Assigned: mccr8)
References
(Blocks 1 open bug)
Details
Attachments
(3 files)
1.13 KB,
patch
|
erahm
:
review+
|
Details | Diff | Splinter Review |
5.96 KB,
patch
|
erahm
:
review+
|
Details | Diff | Splinter Review |
3.49 KB,
patch
|
erahm
:
review+
|
Details | Diff | Splinter Review |
Once bug 1215265 is fixed, we should be able to remove a number of whitelisted leaks from the XPCOM and LSan leak checkers.
Comment 1•8 years ago
|
||
I'm not sure how to do this but we should be able to do it now!
Flags: needinfo?(continuation)
Assignee | ||
Comment 2•8 years ago
|
||
(In reply to Bas Schouten (:bas.schouten) from comment #1) > I'm not sure how to do this but we should be able to do it now! Great! I'll see what the Windows leak situation looks like. Thanks to everybody who worked on this. I know it was a big pain to fix.
Flags: needinfo?(continuation)
Assignee | ||
Comment 3•8 years ago
|
||
It seems like these were fixed by making graphics IPC shut down properly. try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=b485093f55bd
Attachment #8745082 -
Flags: review?(erahm)
Comment 4•8 years ago
|
||
Comment on attachment 8745082 [details] [diff] [review] part 1 - Remove IPC-related LSan suppressions. Review of attachment 8745082 [details] [diff] [review]: ----------------------------------------------------------------- r=me
Attachment #8745082 -
Flags: review?(erahm) → review+
Assignee | ||
Comment 5•8 years ago
|
||
This patch removes all object-based leak suppressions, but leaves the infrastructure in place. The next patch removes the infrastructure. I don't want to leave it in place, both because it is weird to leave around and to discourage people from using it. But I am landing it in a separate patch to make it easier to add back if needed in the future. Linux and Windows try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=bb76c6392eeb
Attachment #8745382 -
Flags: review?(erahm)
Assignee | ||
Comment 6•8 years ago
|
||
This is just constant folding expectedLeaks.
Attachment #8745383 -
Flags: review?(erahm)
Comment 7•8 years ago
|
||
Comment on attachment 8745382 [details] [diff] [review] part 2 - Remove leak suppressions for content processes. Review of attachment 8745382 [details] [diff] [review]: ----------------------------------------------------------------- This is great! r=me
Attachment #8745382 -
Flags: review?(erahm) → review+
Comment 8•8 years ago
|
||
Comment on attachment 8745383 [details] [diff] [review] part 3 - Remove object-count leak suppression infrastructure. Review of attachment 8745383 [details] [diff] [review]: ----------------------------------------------------------------- r=me.
Attachment #8745383 -
Flags: review?(erahm) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/da831b35c6b5 https://hg.mozilla.org/integration/mozilla-inbound/rev/02fa2d4f18d1 https://hg.mozilla.org/integration/mozilla-inbound/rev/9fe5bb27f91c
Assignee | ||
Comment 10•8 years ago
|
||
I'm just going to land this and hope that Ash is okay.
Comment 11•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/da831b35c6b5 https://hg.mozilla.org/mozilla-central/rev/02fa2d4f18d1 https://hg.mozilla.org/mozilla-central/rev/9fe5bb27f91c
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox49:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
Assignee | ||
Comment 12•8 years ago
|
||
Ryan, does this look okay on Ash? Also, I know you aren't normally doing uplifts, but would you mind uplifting this to Aurora? It is test-only so I don't think it needs an uplift request. Thanks.
Flags: needinfo?(ryanvm)
Assignee | ||
Comment 13•8 years ago
|
||
Ryan said this looks fine on Ash. Wes, maybe you could uplift this to Aurora? Thanks.
status-firefox48:
--- → affected
Flags: needinfo?(wkocher)
Updated•8 years ago
|
Flags: needinfo?(wkocher)
Flags: needinfo?(ryanvm)
Whiteboard: [checkin-needed-aurora]
Comment 14•8 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-aurora/rev/d664dd496ba2 https://hg.mozilla.org/releases/mozilla-aurora/rev/d1e136c93c6d https://hg.mozilla.org/releases/mozilla-aurora/rev/623e6b615195
Whiteboard: [checkin-needed-aurora]
You need to log in
before you can comment on or make changes to this bug.
Description
•