Closed Bug 1227424 Opened 9 years ago Closed 8 years ago

[Messages] Replace custom made dialogs with fxos-dialog web component

Categories

(Firefox OS Graveyard :: Gaia::SMS, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::SMS
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED WONTFIX

People

(Reporter: nigelb, Unassigned, Mentored)

References

(
URL
)

Details

(Keywords: papercut, Whiteboard: [lang=js])

Attachments

(1 obsolete file)

https://treeherder.mozilla.org/logviewer.html#?job_id=17740412&repo=mozilla-inbound 07:38:05 INFO - TEST-START | apps/sms/test/marionette/message_received_test.js | Incoming messages tests SMS received Incoming message notification is displayed correctly 07:38:05 INFO - TEST-PASS | apps/sms/test/marionette/message_received_test.js | Incoming messages tests SMS received Incoming message notification is displayed correctly 07:38:05 INFO - TEST-END | apps/sms/test/marionette/message_received_test.js | Incoming messages tests SMS received Incoming message notification is displayed correctly took 7606 ms 07:38:05 INFO - TEST-START | apps/sms/test/marionette/message_received_test.js | Incoming messages tests Flash message received Flash message is displayed correctly 07:38:05 INFO - Screenshot: data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAUAAAAHCCAYAAACe6BB5AAAgAElEQVR4nO2d+VdbV4Ln+79xUtXVM73UmZnq6ZnuPl11TndPn546Xd09Xd1zRtgsBkwwcWwrNoQtGAo7wTiEmDjGwQtxTNmOfQKxE8c4gG0BNsZmE6tsdhCgfV++8wNGkdATSCDpSbrfzznfH/x0Jb0n3/fh3nfvu+8P9qg6wDAMI2L+QO4dYBiGkSsUIMMwwoYCZBhG2FCADMMIGwqQYRhhQwEyDCNsKECGYYQNBcgwjLChABmGETYUIMMwwoYCZBhG2FCADMMIGwqQYQRK+csJDFvMqJnR4CfdnbLvz0Z+0t2JtJEB/J+h/qDX/m2oH2kjA/hpDPaXAmQYQfLBtAb+3FtbwZsJsF/FU+NYcNgBAMMWM37x9LHvtV88fYxhixkAsOx0oFQzHtXvpgAZJknzs54u/HHvw7ByZuYlpIi2UHaSH3RrAfvkAbDgsGPBYYdn0/4+0K1G9bspQIZJwvxm4BlMbrek1CKhQ7cm+7HcWdWGvb/frGqj+t0UIMMkWX7a3YmGuWlcXZrfNosOR0iZuLxeZKkHZT2WDPVAUCtvKzwAMtQDUft+CjBFcm9tBQDw9vhIyDJZ6kEA69dS5N5fJvapejW5pfxyRodk2a/fDvXjp92deHdyFHZPoP7cXi96DHqfwHsMeri93oAydo8HxyZH8dPuTvz70PNd7QsFmAJ5U9UBg8uFZacD5+ZnQpZ7ajRg3mGHxmaVfZ+ZyPPz3kdhl/3dq6mQ8vMCyJZJfv800OdryW3mu7UV/GVfd9B7/upZN+6vrUq2BgHgXwaf7Xh/KMAUyD++eAqHx4OGuWl06aWv6fx2qB9WjxsNc9MYMptk32cmsvzrYD++0i6FVbZ6C/kBgMPjke04vl5ZltynL5bm8cYW73tD1YFrSwuS772zi+uCFGAK5P2XE+gzGpA9OoRVp1OyIrXrVtE4P4P62VfoMepDftavB/rw9coyFhx2ODwevLRZUT/7Cv+552FAuZ+87sI8MxmgczmhcznRY9Dj2ORo0NSKSMpu5O+fP8H15UXM2m1weDyYd9jx2KBD0dQY/qT3Ycj3/H55ETN+71G9fs+fhnhPLI43Fpm223BvbWXbcqemQ8vP5fViymaVTYB/2N0Js8TAjdpiDmtO4k+7OzFmNQe93+px4496una0TxRgCuTbVS3Oz8/gf/Z1AwD+ok8V8Po/vG4h/kWfCpcX59AeYiqBcnIULq8XzYvz+M3AM/xlXzdyRoew4LDj65XlgLLXlhaw6HDgyIQav+zvxd89f4KjE6OYtttQNDW247J7VB0oGB+B3ePBbe0SfjvUj//+VIW/e/4EpZpxAMChcXXQe96ZUMPh8eCmdgn/5vee4qn19xyeCH5PrI43Fll0OLYV4OZ5fpvld2B0CC3LC7K2AP9l8BkMblfAvkn9f4bK4Ql1wHsNbhe7wCLnTVUH1lxOHBgdwhuqDqw6nUEje7e0S7i6NI89qg58pV1C66aTe49qvWK6vV7Jk7loagwur9c3E/8v+lQAgH0jwaNxP+vpCmgRRVJ2j2q9Reb0evG7V1NB5f/yteB/PdAXsP2fX+97+cuJoPf8+dP17//nTSdJrI43VtlOgB+GIb89qg7ZBbhH1YEvluYD9s9/4vN2+cXr/88Nvnhdr3caCjDJ87+ePwUA/PnT9VZfp34Np2de+l7/62c9cHg8+JtnPdij6sD3aytoWV4I+pzv11ZCtgyrX03B6Hb5utZ///wJAOA/hrcfgYuk7B5VB+6uavHEaJDsxqeNDABAUPf0+7UVPDboJN/zH8PPAQA/f/Io6D2xON5YZSsBng4xyXmz/PaoEkOA/tcoPUBE731D1REwgFIt8YcyklCASZ4yzQRm7DbfvxvmpnHX76Lw5cU53PK7eN5j1KNpYTbgM37V3wsvgN9K3IepGH4BvcuFutlXvm1vqjrw2KDDvMOO96bGg4Tkn0jK/vWzHngQeipP+csJzNntkvueNzYs+Z73psax5nLG7XhjlVACDHWHh5T89qgSQ4B1s68C9vOPQ1yflcqf9D4MeO9Wsx7CCQWY5PlmVYubfoJ7a2wY06+F+N+ePobN48HfP3/ie33IbEK938m9R9WBwqkx2Dwe/LS7E3/Y3Ylf9vfi+OQYvl9bgc3jwUczL4O6eX/U04X62VdYczlhcLtwaWEOv+rvldzHcMsWT43D6fXiZyEuaF9ZnEfnplHuMs0E7K/3Xeo9FxZm0Wc0xPV4YxEpAX4Uofz2qOQX4B/1dGHIbArYV8Xwi7Dfv9EL2GDabtvVHyQKMInzhqoDK04Hjk2O+rb9zbMeAMCf9T5C/ewrfLfppHlps+LUdGC3oWFuGk6vF/OvR0Kn7Ta0rSzj7fER/Nk2c8/+sLsTB8aGoTLoYPd4JE+6cMt+Nj+DV1vMUXxs0OHzTa3XCwuzW85rfKBbxU3toizHG81ICfDiwlxE8tujkleAP+vpwrIz+M6UbyOYxrIx4d+fVacz5Cj/dqEAkzh/+/ra1C/9WiJvqDpgdLuQqR6EweXCbwYCL/4vOx0o0wQOFlxbWsCoxYy/eta94yWS3lB14MulBay5pKfhhFP2tnYJTze11vyz5HAEDVq0rixv+Z5XNhs+nNbIerzRyGYBblznvbwYKMGt5LdHJX8LsMegl5T2VncwbeTIphHgDfpNxh3vDwWYxCmeGsey0xF0AqoMOmhsVjyUmBRtdrtxdGI0YFvNjAZLjt3fHrd/dP1Wu//6ZPtRPamy5+dnQrbmNmT/H5tufWrcotX4y/5eeADkb7o+KMfx7jabBejweFA/+wpvqH4cVd1OfntU8gvw7fGRkK3WEs245B+TN1Trlzo23xK3web6HEkowCTO1yvLQfPV9qjWpQAA/3fTqOUbqg54ARzYJIR/H1ofKd0bYpqH/wn+X548Dnntq3F+Blo/IUdSdo+qA/ljw/AC+Du/a5Z7VB34H30qzNptABB0q9RbY8MAEHCdc49qferKzOv3/OOLp3E53lhGSoAAfBK8sjgfVndcbgG+qerAR7OvkK4eQKvEXSGjrxdrzRsbRt7YMGpmNBi1BE9+/m5tBRnqAXwyO72rhV0pwCTNG6r17myJxHpuf/5UhX8efBZ0Yv6nnq6QJ/7XK8swuFwo1YzjH188xW+H+lHxchLzDnvAdbeqV1Owv77tbt/IAH7V34t/H3qOy4tz8AB4y0+ukZTdo1q/22LYYsa41QLF8Av89bMe5I8NY8Jq8U1o3jwX701VBwbNJkzZrEgbWX/PwfERDJlNvmtkUhfJY3G8scxmAb6y2bDocGDRIV0HQkVuAW7Op3Mzkq26rbi8OBe176cAkzS/6u+VbPlslV88fQwAksuO/6S7E1WvJjFkNsHqcWPObke7btU3wdq/7P8bfoEHulWsOp1web2Ysdtwd1UrOSM/krJ7VOs3/F9fXsS8ww6L242H+jVf2ZoZDb5cCp7D+Ke9D/Hl0gLm7HZYPW481Ovw64E+VL6cxGKIrm6sjjdWCedOkHCSaAJ8Q9WBfpMxbPmNWy1RXcqfAmRSNre0S/g+CtJIhCw6HJLXdCPN1yvLCSXAPaoO3NQuhi3Ab6P8/0kBMimZN1XrU4Tem5J/yfdo5JXNCgAwu90wul07DrB+/6zcx+Mf/2uBepcL702N4zcDz/DrgT4cnxzDmsvpe303K79IhQJkkjqh7iKofjUFs9sdtDBEsiZdPYCb2iXc3mW+0i4FDYIlQv73i6donJ8JeW/2hYXZoHvAoxEKkEna/Lz3EQwuF24sL6JgfAT/8OIp/m2oH5cX5+D2elEQxtwyRuxQgExS558G+vD75UWMWMywetxYdjrQoVvDvw4GD/QwzOZQgAzDCBsKkGEYYUMBMgwjbChAhmGEDQXIMIywoQAZhhE2FCDDMMKGAmQYRthQgAzDCBsKkGEYYUMBMgwjbChAhmGEzR+EvRIhIYSkGBQgIURYKEBCiLBQgIQQYaEACSHCQgESQoSFAiSECAsFSAgRFgqQECIsFCAhRFgoQEKIsFCAhBBhoQAJIcJCARJChIUCJIQICwVICBEWCpAQIiwUICFEWChAQoiwUICEEGGhAAkhwkIBEkKEhQIkhAgLBUgIERYKkBAiLBQgIURYKEBCiLBQgIQQYaEACSHCQgESQoSFAiSECAsFSAgRFgqQECIsFCAhRFgoQEKIsFCAhBBhoQAJIcJCARJChIUCJIQICwVICBEWCpAQIiwUICFEWChAQoiwUICEEGGhAAkhwkIBEkKEhQIkhAgLBUgIERYKkBAiLBQgIURYKEBCiLBQgIQQYaEACSHCQgESQoSFAiSECAsFSAgRFgqQECIsFCAhRFgoQEKIsFCAhBBhoQAJIcJCARJChIUCJIQICwVICBEWCpAQIiwUICFEWChAQoiwUICEEGGhAAkhwkIBEkKEhQIkhAgLBUgIERYKkBAiLBQgIURYKEBCiLBQgIQQYaEACSHCQgESQoSFAiSECAsFSAgRFgqQECIsFCAhRFgoQEKIsFCAhBBhoQAJIcJCARJChIUCJIQICwVICBEWCpAQIiwUICFEWChAQoiwUICEEGGhAAkhwkIBEkKEhQIkhAgLBUgIERYKkBAiLBQgIURYKEBCiLBQgIQQYaEACSHCQgESQoSFAiSECAsFSAgRFgqQRAWv1wu32w2n0wm73Q6bzQaLxQKz2QyTyQSj0QiDweCLXq8PysZrRqMRJpMJZrMZFosFVqsVdrsdDocDLpcLHo9H7sMlKQIFSCJiQ3QOhwNWqxVmszmk0GIdk8kEi8UCu90Ol8sFr9cr989DkgwKkGyJx+OB0+mEzWaDyWSSRXSRxGg0wmKxwOFwwO12y/3zkQSHAiQBeL1euFyupBHedjEYDD4hsutMNkMBEni9XjidTlgsFtm6s/GKyWSC3W6nDAkAClBY/KUnt5QoQyIXFKBgeDwe2Gy2lG/pRRqLxcKBFAGhAAVgo7VnNptlF02ix2g0wmazsVUoCBRgCuP1emG322E0GmUXSzLGarVShCkOBZiCeL1ednOjGIvFwik1KQoFmEJQfBQhiQwKMAXY6OpSfPETIbvGqQEFmOQ4nU5e45MpNpuNo8ZJDgWYpLjdbo7qJkAMBgMcDgdFmKRQgEnGxnU+uU98JjAmk4nXB5MQCjCJcLlc7O4meOx2O1uDSUTUBXjz5k0mBmlpacHVq1eZJMiXX36JGzduyF5nUjHRhi3ABMftdrPVl6RhazDxoQATlI2pLXKfxMzuYjabOWUmgaEAExCv18sR3hSKwWCAy+WSu1oRCSjABINd3tSN3W6Xu3qRTVCACYTD4ZD9JGViG4vFwuuCCQQFmABwbp9YMZlMvC6YIFCAMsPrfWLGYDBw4nQCQAHKiMfjSYkHDzE7DwdH5IUClAmPx8PBDgZ6vR5Op1Pu6igsFKAMeDweLl3FBMThcMhdLYWEAowzbreb8mMkQwnGHwowjrDlx2wXSjC+UIBxgtf8mHBDCcYPCjAOUH5MpOHASHygAGOM1+ul/JgdhVNkYg8FGEO8Xi/n+TG7CidLxxYKMIZYrVbZTyAmuWMwGHjbXAyhAGME7+1lohWj0cgFFGIEBRgDnE6n7CcNk1rhKjKxgQKMMm63W/aThUnN2Gw2uat3ykEBRhGO+DKxDkeGowsFGEUsFovsJwiT2uGgSHShAKMEV3Nm4hWz2czrgVGCAowCHo9H9pOCESt8vkh0oAB3CSc7M3KFk6R3DwW4S/jsXkaucH7g7qEAdwGnvDByh1NjdgcFuEPY9WUSJewK75y4CvDKlStQKBRob28PWaagoACPHj2K307tEI76MokSk8nErvAOibsAc3NzcfDgwZCLPiaDADnqyyRauIjqzoi7AJuamnDw4EG0tbVJlkkGAabKhOe1tTXMz89jYmICz549Q0tLC27cuCH7fjGRx2AwsBW4A2QR4P3795Gbmwur1RpUZisB6vV6NDY24tixY8jOzkZFRQXu3r0b8X98XV0dWltbYbVacfHiRbz11lvIycnBZ5995vtL2tfXh5KSEmRmZqKkpARjY2MApAc+JiYmUFtbi/z8fOTl5aGqqgq9vb2SFXVwcBCnTp1CXl4e9u/fj9LSUty4cQMrKys7KtfZ2Yna2locOnQIGRkZyM/PR01NDSYmJiS/f3FxEZ9//jkKCwuhVCqRnp6O9PR0VFVV4ZNPPsHt27djfmxMbMIBkciJuwDPnTsHl8uFw4cP48aNG0FlQglwZmYGBw8exJkzZzAwMIDZ2Vl0dnYiPz8ftbW1EUmwrq4Ozc3NKCkpQWtrK5aXlzE2NoZDhw7h0qVLuH//PioqKjA6OoqVlRU0Nzdj//79MJlMQQMfg4ODyMvLw5UrVzA8PAy1Wo3bt29j//79+O677wLKDg8PIyMjA42NjRgZGcHExAQ6OztRVlaG8+fPR1xOr9ejubkZ169fR19fH8bHx9Hb24vy8nIUFBRAq9UGlNVqtVAqlWhqasLq6qpvW0NDA+rr66HT6WJ+bExsw9vkIiPuAvz4448BAI8ePUJWVhYMBkNAmVACrK6uRl1dXZDoVlZWkJmZie7u7rD3o66uDvv27cP9+/cDtre3tyMzMxPFxcUBf03dbjcOHDiA+/fvB1W48vJyXL16NWj7Dz/8gLy8PCwvL/u2NTY2orS0NEg0Op0uQFbhlguVubk5pKeno6OjI2D7zZs3oVQqgz53ZWUF+fn5ePDgQcyPjYltLBZL2OcBkUGANTU1ANYHEo4fP44rV64ElJESoEajgUKhwPT0tOTnNjU1oaSkJOz9qKurw4cffhi0fXR0FAqFAjMzM0Gvvf/++7hy5UpAZRsYGEBaWhoWFxeDKqJOp0NOTg4eP37s29bQ0IDy8vJtK3G45bbKkSNHgq7n1dTU4OzZs5Llq6urce7cuZgfGxP7cFpM+MgmQGD9Olt6ejpWVlZ826QE+MMPPyAnJyfk5z569AiZmZlhd4Pr6urQ2NgYtH1DtCaTKei1qqoqNDU1BVS0b775Bu+8807IilhYWIjW1lbfv/v7+7F3716cPXsWw8PDId8XbrmtUlRUhGvXrgVsq6qqQl1dnWT5ysrKgK5qrI6NiX3MZnNY5wGRWYBerxdlZWX47LPPfNukBNjS0oLjx4+H/Fy1Wg2FQgG9Xh/WfkQqQK/Xi8rKyiABbsxr3CqbJTQwMIDKykqkpaWhqKgIN2/exNzcXFAlDrfc3Nwcrl69isLCQuTk5PgGNaS+++rVq8jPzw/qki4sLCA7Ozvgul4sj42JfdgKDA9ZBQgAQ0NDSEtLw/z8PADg0KFDQQK8du0aCgsLQ37uyMgIFAoFjEZjWPsRqQCdTidOnDgRJMCmpiYcOXJkRxV0ZmYGbW1teO+995CTkxNyZHWrcnNzczh06BCqqqrQ19eHhYUF3zU4qRbgwsIClEolTp48ibGxMayurkKtVuPEiRMoLi7G2tpaXI+NiV3YCgwP2QUI/DjAAQDvvvtukADb29uRm5sb8nO7urqQlZUVsy6wyWSSFGBrayv27t3rG1HdSXQ6Hc6ePYuCgoKgAYTtyl2+fBnvvPOO5DQTKQHq9XpMTk4iMzMTSqUSOTk5OH78OJqbm4NahfE8NiY2YStwexJCgJOTk1AoFNBoNCguLg4S4Pj4OBQKBWZnZyU/t7GxERUVFWHvRyQCdLlc0Ov1kgJ8+vQpFArFrls43d3dUCgU23YXN5errq7GRx99JFk2lABPnDiBW7dubbtP8T42JvrhiPD2JIQAAaC2thanTp1CRUVFkAC9Xi8qKipQX18f1MpbWlpCeno6+vv7w96PSARoNpt94tgsQJ1Oh+LiYpSWlgZ0HzdeGxsbC9g2OTkp2RK6desWcnJyfK+FW66+vh7FxcWS8/fS09OD9ler1WLv3r1Qq9XbnjyxOjYmvuG8wK1JGAHOzMwgLS0Nubm5kvMANRoN8vLyUFdXh6GhIczOzqKjowN5eXloaGiIeCJ0OAL0v+tDSoB6vR7Pnz9HTk4O3n//fTx+/BhqtRoPHjxAeXk5SkpKfCf+6uoqjh07htLSUnz//fcYGhrCyMgIbt26hYyMDF+rLNxyev36yGtaWhouXbqEiYkJTE1Noa2tDYcPH8aFCxdw7NgxLC0tBYgrNzcXFy9eDGtuXrSPjYl/eHfI1iSMAAGgoaEBCoUi5K1wq6ur+PTTT6FUKpGdnY3Kykrcv39/R7fChSNA/4ebhxKgXq+HRqNBXV0djhw5gqysLJSWluLatWuSd2J8+eWXUCqVyMjIQE5ODsrKyvDgwYOAFlK45fT69S7mxi17OTk5qK2txeTkJBYXF/HBBx+gq6sroPzjx4+Rl5cHhULhGzEuKCjA6dOnJVuG0T42Jr7hPcJbw/UAQ+D1emEwGGSvwLGITqeDRqPB6Ogo1Go1enp6UFNTg+zsbGg0Gtn3j4lunE6n3KdTwkIBhsDpdMpecaMZrVaLycnJkK/rdDrk5+cHLYbAJH84JSY0FGAINgY/UiVqtTrkrW16/fr9wLm5uUGLHDCpEQ6GSEMBSpCKC56ura2hqKgIZWVlePjwIcbHx/Hq1SuMjo6io6MD5eXlUCqVWFhYkH1fmeiHj9GUhgKUIFWf9DY7O4vm5mYolUrk5uZi7969yMvLQ1FREVpaWjhXL4UjdX87oQAl4cOOmFQMu8HBUICbSMXuL8Po9ewGS0EBbiJVu78Mw25wMBTgJlJt9Jdh/MNucCAUoB9er1f2CsowsQwfnxkIBehHqk1+ZpjN4QoxgVCAflitVtkrKMPEMrw3OBAK0A+j0Sh7BWWYWIcLpf4IBfgaXv9LzFRUVKC2tlb2/UjU/dlJOB3mRyjA1/D6X2JmY+kyufcjUfdnJ+HiCD8SVwG6XC58++23KCkpQXZ2Nvbv34+SkhLcu3dPcnj+0qVLuHz5clz2zWaz4fz580lfuZndRYQ6YDAY4nJOJQNxE6DH48EHH3yAgwcP4t69e5icnMTw8DDu3r2Lt99+GxUVFUFD9KEWLo0FZrN5yweHM2JElDrA+YDrxE2AfX19SEtLw8LCQtBrdrsdAwMDQdvjKUCDwSBM5WdCR646sLa2hvn5eUxMTODZs2doaWnBjRs3YvZ9XCR1nbgJ8KuvvsLRo0fDKtvY2Cj5IO6bN28GlHv69Cnq6+tx+PBhZGRkoKCgAHV1dVhaWpL83Lq6OrS1tUGn0+HMmTPIysrC0aNHcf78ecnvu3r1atgVanZ2Fg0NDVAqlcjMzERhYSFu374d9ECh6elpnD17FkqlEvv370dpaSlu3boVctn4mpoaXL9+HYuLi/jss8+Ql5eH7Oxs1NfX+5al7+rqQlFRETIyMlBUVIRnz57F/LOKi4tD/j4FBQVobW0N+f1arRZffPEFDh065Puenp6eiIUUzm/e2dmJ2tpa33fl5+ejpqYGExMTAZ919uzZsOpAqP3ZybEtLi7i888/R2FhIZRKpe8RBVVVVfjkk0/CWpx2J9+r1+uxvLyMxsZGHDt2DNnZ2aioqMDdu3eDpsh0d3cjIyMDLpcrYPva2hoUCgWampqCzrMrV67g9OnTYZ3rchM3AXZ2diIrKwtWq3Xbsg6HAxaLBadPn0ZDQwMsFgssFkvQf8L169fR2tqK0dFRLC4uYnh4GJWVlTh06JDkjPe6ujrcvHkTpaWl+Pzzz9Hf3w+1Wg2z2YyFhQWcPHkSdXV1WFhYwMLCguTzdqUyNjaGgoICVFRUoKurCyMjI2hvb0dhYWFAJRwZGUF+fj4++OADqFQqqNVqfPvtt3jrrbdw6tQpSQnW1NTgwoULKCoqwvXr1zE5OYm+vj4UFBTg/PnzaG1tRWlpKfr6+qDRaHDhwgVkZWVJLm0Vzc/aqQAvXLiA0tJSNDY2Ynh4GFNTU7h8+TLS09MlV6wOJZxwf/Pm5mZcv34dfX19GB8fR29vL8rLy1FQUBDwXBOtVhtWHdhKgJEcm1arhVKpRFNTk+/Zy1qtFg0NDaivrw/7OSo7+U036uGZM2cwMDCA2dlZdHZ2Ij8/H7W1tQES1Ol0UCgUmJycDDiXHj16hMOHD+P48eNB51lpaSna2trCVYOsxE2AdrsdSqUSVVVVWFxcDOs9O+kCm0wmpKen48mTJ5Kft/Eg8M37tl1rY6ucPHkSlZWVQQ8R31yJT5w4gZqamqDtGo0GGRkZaG9vl6zg+/btCxJKW1sbMjIyUFhYGPDkt9XVVeTm5uLOnTsx/aydCnDfvn1oaWkJ+p3eeecd/P73vw9bgOH+5lKZm5tDeno6Ojo6wv6+cAQYybHdvHkTSqUyaH9XVlaQn5+PBw8ehC3ASH/TEydO4PTp00GtvZWVFWRmZqK7uztg+9GjR/Htt98GbLtw4QLu3r2LzMzMgEUWHA4H9u7di/Hx8YjOW7mI6yiwwWDAp59+in379qGqqgrt7e1bDsnv9BqgUqmU/AtUV1eHffv2BX2nxWLZsQCHh4ehUCjQ39+/ZbmBgQEoFAoMDw9Lvn7u3DkUFRVJVvDq6uqg7X19fVAoFBgZGQl6rbS0FJcvX47pZ+1UgL/73e8kJXXy5Ek0NDSEJZxwf/OtcuTIEclrbLsRYCTHttX3VFdX49y5c2ELMJLv9a+HUneENDU1oaSkJGDb+fPnUV9fH3SOzc7OoqqqCn19fb7tY2Njkl3mREWWeYAGg8E3HWbjAd5SItypAEtKSnD79m3Jzzt16lTQ9o0FUHciwI2/gtu1PO7cuYPs7OyQr9+7dw8ZGRlBnxNqnzYqslT3NNQjPKP5WTsVYKjft7a2Fh9//HFY7wn3N98qRUVFuHbtWkT7uNXrkR5bVVUV6urqJMtXVlbi/PnzYR1HpN/rXw+lRoIfPXqEzMzMADl2dXXh7bff9v1br9cjNzcXXq8XN27cwBdffOF7ra2tDZWVlRGfs3Ih+0RojUaDkpISHD9+PBGh8GIAAA7VSURBVOJpMCaTCTdv3kRxcTFyc3N9F5EVCkVIAUp93sbjL3ciwCtXrkCpVG5b7vLly1uWe/r0KRQKBaanp2MmrVQRYLi/uV6/3t29evUqCgsLkZOTE1BH5BTg1atXkZ+fH/R85YWFBWRnZ4f9cKpIv9e/Hkq10tRqNRQKBfR6vW/b8vIyFAoF1tbWAKwPjNTW1gIABgcHUVpa6iv70Ucf4fr169uc9YmD7AIE1kWWm5uLe/fuBWzfSoAmkwmHDx/GqVOnMDo6CovF4vurtVULcPPn+d8CtxMBXrx4Ee++++625S5durRluSdPnkChUGB2dpYC3OY94f7mc3NzOHTokK+btrCw4Gs1yt0CXFhYgFKpxMmTJzE2NobV1VWo1WqcOHECxcXFQbMHoiVA/3ooNVA4MjIChUIBo9EYcI4UFBSgt7cXAHDx4kV88803ANavn6enp8Nut8Pr9eLgwYN48eJFBGe/vCSEAAGguro6SE5bCbClpQVHjhyR/CsWiQD9l8DfiQDb2tqwf//+sMrl5OSEfP27776T7NZRgMHvCfc3v3z5Mt555x3J0Xy5BajX6zE5OYnMzEwolUrk5OT4Bug2twq3SqTf618PbTZb0DnS1dWFrKysoOuDn3zyia+re/z4cUxNTQWcb4ODg1hZWUFaWlpYMz0ShYQR4PHjx9HS0hKwra6uDufPn5cs/+GHH+Ls2bOSr0UiQJfLFVCZPvnkk7Arn16vx7Nnz7Yc3NhcTq1WS75+9uxZlJWVxVRa0fyssrIyXLp0KWi7VqtFTk5OTAUY7m9eXV2Njz76SPK1rQS4VR2IpgBPnDiBW7duRVTfdvu9/vVQSlSNjY2oqKgI2n7//n2Ul5fDZDIhKysr4PrhxlQjlUqF9957T/KcTFTiIkCv14s7d+5gZmZG8vXnz58jLS0Nw8PDAdubmppCTqj87LPPUFZWFvSX6uXLl0hPT8fVq1eD3iMlQP9FEM6dO4eTJ09GVAF1Oh3Kyspw8uTJoG7LysqKr0Wn0+lQWlqK2traoFbexMQE0tPT8fDhw6QR4Mcffxz0W+l0Opw/fx4ZGRkxFWC4v3l9fT2Ki4uDfu/BwUHf4Nvm79uuDkRLgFqtFnv37g35BzFWAvSvh5ufEbK0tIT09HT09/cHnTuzs7NIT0+HSqXCyZMnA1578uQJKisrceXKFVy6dEnyfE1U4iJAt9uNa9euISMjA01NTejq6oJGo8Hg4CCam5uRnp4eMJK0wZMnT7Bv3z50d3djdnYW9+/fx9zcHABgYmICaWlpuHbtGpaWlqDVatHe3o6jR4+iubkZRUVFQU18KQE6HA5f5ejo6MC+ffvQ3t4OtVqN1tbWsCro4OAgDhw4gBMnTqCjowMvXrzAnTt3cOTIkYC5fQMDAzhw4ABqamrQ09MDtVqNu3fv4sCBA6irqws5EToRBdjb2+sbbJqcnMTz589x5swZNDQ0oKKiIqYCDPc37+/vR1paGi5duoSJiQlMTU2hra0Nhw8fxoULF3Ds2LGAeY/h1IFoCVCn0yE3NxcXL16MqMsbjd90ox6ePn0aQ0NDmJ2dRUdHB/Ly8tDQ0CA5Pcbr9eLAgQMoKysL6l0ZjUbf3Seb5xAmOnHtAk9NTaG+vh4HDx5Eeno6Dh06hFOnTmFgYCDkj/7VV1/h4MGD2L9/P6qqqqDRaHyvDw4Oory8HFlZWcjNzUV9fT2Wl5dhtVpx5syZgPlJgLQA/Z8Cp9PpfKNzWVlZeP/99zEwMBBWRZyensbHH3+MI0eOIDMzE8XFxfj666+DWigvX770ldu/fz/Ky8vR2tq65a1wiShAvX79uqVSqURGRgaOHDmCr776CjqdDtXV1TEXYLi/eXd3N0pKSpCZmYmcnBzU1tZicnISi4uL+OCDD9DV1RUkpq3qQDS7wI8fP0ZeXh4UCoVvdLqgoACnT58Ou2W4k+/1r4dKpRLZ2dmorKzE/fv3t1wt+syZM77u82befffdgJHiZCFhrgHKBZfBZ+SMTqeDRqPB6Ogo1Go1enp6UFNTg+zsbGg0mph+N5fFogApQCbu0Wq1kvfobkSn0yE/Pz+sxRB2G9GhAClAJs5Rq9VIS0vD4uKi5OsrKyvIzc0NezL0biI6wgtw4z5gholX1tbWUFRUhLKyMjx8+BDj4+N49eoVRkdH0dHRgfLyciiVSiwsLMR8X0R/QhwFSAEyMmR2dhbNzc1QKpXIzc3F3r17kZeXh6KiIrS0tEgOSMUiFKDgmM1m2U8GhpErFKDgUICMyKEABYddYEbkUICCQwEyIocCFBxOg2FEjuhQgBQgI3BER3gB2mw22Sshw8gR3gpHAQYshsAwIsV/1WdREV6A/sthMYxI2bweoIgIL0D/BVEZRqRs9UhaURBegP5L4jOMSEmmZ3fECuEF6P9QJIYRKXa7Xe7TT3aEF6D/YzEZRqQ4nU65Tz/ZEV6AwPozDeSujAwT77jdbrlPPdmhAMEFERgx4/9oS1GhAMG7QRgxQyhAAJwLyIgXzgFchwIEp8Iw4sVisch92iUEFCA4EsyIF06BWYcCfA1HghmR4nK55D7lEgIK8DUcCWZEiugLoW5AAb6Gq8IwooSrwPwIBfgaDoQwooQDID9CAb6GAyGMKHE4HHKfbgkDBeiHyWSSvXIyTKzDO0B+hAL0g8vjM6keXv8LhAL0w+12y15BGSaW4RqAgVCAfni9XhgMBtkrKcPEKlwCKxAKcBN8UDqTyuH8v0AowE3wGSFMqobPAAmGAtwEp8MwqRpOfwmGApSA3WAmFcPubzAUoATsBjOpFnZ/paEAJWA3mEm1sPsrDQUYAnaDmVQKu7/SUIAh4OIITKqEix+EhgLcAi6SyqRCuPhpaCjALeAagUyyhw8/2hoKcAs4GMIkezj4sTUU4DbwmcFMssZgMHDwYxsowG3gCjFMssZms8l9+iQ8FGAYcEoMk4xh6297KMAwYCuQSbZw3b/woADDhI/NZJIpXPY+PCjAMGErkEmWsPUXPhRgBLAVyCRD2PoLHwowAtgKZBI9HPmNDAowQjgvkEnUcN5f5FCAEeLxePjgJCYhw7s+IocC3AG8R5hJtJhMJrb+dgAFuAO8Xi9XimESKlzxZWdQgDuE6wUyiRJOe9k5FOAu4C1yjNzhwMfuoAB3gdfr5YAII2ucTqfcp0FSQwHuEk6OZuQKl7rfPRTgLvB4PLKfBIyYMRgMvOMjClCAu4DTYRi5wq5vdKAAdwGnwjByhLe7RQ8KcIdwGgwjRzjhObpQgDuE9wQz8Q6v+0UfCnAH8GlxjBzh3R7RhwLcAQ6HQ/aTgRErdrtd7mqfklCAO8BkMsl+QjDihPP9YgcFGCFcFJWJZzjoEVsowAix2WyynxSMGDEajZRfjKEAI4D3/jLxCkd84wMFGAFOp1P2E4NJ/RgMBrjdbrmruxBQgBHAhQ+YWIfyiy8UYJhw4QMm1qH84g8FGCZc+ICJZSg/eaAAw4QLHzCxCuUnHxRgGHDhAyZWMRqNHO2VEQowDLjwAROLmEwmyk9mKMBt4MIHTCxiNps5yTkBoAC3gQsfMNGO1Wql/BIECnAbuPABE804HA65qzTxgwLcAi58wEQrHOlNTCjALeDCB0w0YjabOdiRoFCAIeDCB0w0Yrfbeb0vgaEAQ8CFD5jdxGg0ssubBFCAIUi0hQ8sFgtbpEkSjvImDxSgBImy8IHJZILD4fCdTF6vl5OyEzhs9SUfFKAEci58YDAYYLVatzyRXC4X701OsPBaX3JCAUogh1zMZjOcTmfYJ5HX6+UKNQkQi8XCEd4khgLcRDwXPjAajbDb7bs6gTweD7vFMsRoNPI5vSkABbiJeMjEYrHA5XJFtcvkdrsTbuAmFWM0GgOuy5LkhgL0I5YLH2we0IgVFGFsYjAYKL4UhAL0I9oLH4QzoBErXC4XRRiFsMWX2lCAfkRr4YNIBzRiidvt5jXCHcRkMiXM/yGJHRTga3a78EE0BjRiicfjgd1u5/SZbWKxWDiXTyAowNfsdOGDWAxoxBKv1wuXywWLxSK7bBIl8bo+SxIPChCRL3yQKieM1+uFw+EQ8lqh0WiEzWZja09wKECEt/CBnAMa8WBDhql8z7HJZKL0SAAUILZe+CCRBjTixUY32WazJfWK2EajERaLRbj/PxI+wgtQauGDRB/QiDcbQrTb7TCbzQnbQjSZTLBarXA6nfy/I2EhvAD976dNtgENOfF4PD4pWiwWmEymuI0wG41GmM1m2Gw2OJ1OuN1u/p+RHSG8AC0WS0oMaCQKXq/XJ0en0wm73Q6bzQar1Qqr1QqLxQKLxQKz2RyQje0WiwVWqxU2mw12ux0Oh4OSIzFDeAESQsSFAiSECAsFSAgRFgqQECIsFCAhRFgoQEKIsFCAhBBhoQAJIcJCARJChIUCJIQICwVICBEWCpAQIiwUICFEWChAQoiwUICEEGGhAAkhwkIBEkKEhQIkhAgLBUgIERYKkBAiLBQgIURYKEBCiLBQgIQQYaEACSHCQgESQoSFAiSECAsFSAgRFgqQECIsFCAhRFgoQEKIsFCAhBBhoQAJIcJCARJChIUCJIQICwVICBEWCpAQIiwUICFEWChAQoiwUICEEGGhAAkhwkIBEkKEhQIkhAgLBUgIERYKkBAiLBQgIURYKEBCiLBQgIQQYaEACSHCQgESQoSFAiSECAsFSAgRFgqQECIsFCAhRFgoQEKIsFCAhBBhoQAJIcJCARJChIUCJIQICwVICBEWCpAQIiwUICFEWChAQoiwUICEEGGhAAkhwkIBEkKEhQIkhAgLBUgIERYKkBAiLBQgIURYKEBCiLBQgIQQYaEACSHCQgESQoSFAiSECAsFSAgRFgqQECIsFCAhRFgoQEKIsFCAhBBhoQAJIcJCARJChIUCJIQICwVICBEWCpAQIiwUICFEWChAQoiwUICEEGGhAAkhwkIBEkKEhQIkhAgLBUgIERYKkBAiLBQgIURYKEBCiLBQgIQQYaEACSHCQgESQoSFAiSECAsFSAgRFgqQECIsFCAhRFgoQEKIsFCAhBBhoQAJIcLy/wEZgGkhhk7/2AAAAABJRU5ErkJggg== 07:38:05 INFO - TEST-UNEXPECTED-FAIL | apps/sms/test/marionette/message_received_test.js | Incoming messages tests Flash message received Flash message is displayed correctly 07:38:05 INFO - Error: timeout exceeded! 07:38:05 INFO - at Object.Client.waitForSync (/home/worker/gaia/node_modules/marionette-client/lib/marionette/client.js:759:16) 07:38:05 INFO - at Object.Client.waitFor (/home/worker/gaia/node_modules/marionette-client/lib/marionette/client.js:725:60) 07:38:05 INFO - at Object.MarionetteHelper.waitForElement (/home/worker/gaia/node_modules/marionette-helper/index.js:142:12) 07:38:05 INFO - at Object.container (/home/worker/gaia/apps/sms/test/marionette/lib/views/dialog/accessors.js:19:31) 07:38:05 INFO - at Object.<anonymous> (/home/worker/gaia/apps/sms/test/marionette/lib/views/dialog/accessors.js:38:18) 07:38:05 INFO - at modifiedTest (/home/worker/gaia/node_modules/marionette-client/lib/marionette/client.js:721:22) 07:38:05 INFO - at Object.Client.waitForSync (/home/worker/gaia/node_modules/marionette-client/lib/marionette/client.js:753:9) 07:38:05 INFO - at Object.Client.waitFor (/home/worker/gaia/node_modules/marionette-client/lib/marionette/client.js:725:60) 07:38:05 INFO - at Object.DialogAccessor.waitToAppear (/home/worker/gaia/apps/sms/test/marionette/lib/views/dialog/accessors.js:35:17) 07:38:05 INFO - at Object.DialogView (/home/worker/gaia/apps/sms/test/marionette/lib/views/dialog/view.js:11:18) 07:38:05 INFO - at Context.<anonymous> (/home/worker/gaia/apps/sms/test/marionette/message_received_test.js:117:20) 07:38:05 INFO - at callFn (/home/worker/gaia/node_modules/mocha/lib/runnable.js:250:21) 07:38:05 INFO - at Test.Runnable.run (/home/worker/gaia/node_modules/mocha/lib/runnable.js:243:7) 07:38:05 INFO - at Test.MarionetteTest.run (/home/worker/gaia/node_modules/marionette-js-runner/lib/ui.js:25:31) 07:38:05 INFO - at Runner.runTest (/home/worker/gaia/node_modules/mocha/lib/runner.js:373:10) 07:38:05 INFO - at /home/worker/gaia/node_modules/mocha/lib/runner.js:451:12 07:38:05 INFO - at next (/home/worker/gaia/node_modules/mocha/lib/runner.js:298:14) 07:38:05 INFO - at /home/worker/gaia/node_modules/mocha/lib/runner.js:308:7 07:38:05 INFO - at next (/home/worker/gaia/node_modules/mocha/lib/runner.js:246:23) 07:38:05 INFO - at /home/worker/gaia/node_modules/mocha/lib/runner.js:270:7 07:38:05 INFO - at done (/home/worker/gaia/node_modules/mocha/lib/runnable.js:206:5) 07:38:05 INFO - at callFn (/home/worker/gaia/node_modules/mocha/lib/runnable.js:261:7) 07:38:05 INFO - at Hook.Runnable.run (/home/worker/gaia/node_modules/mocha/lib/runnable.js:243:7) 07:38:05 INFO - at next (/home/worker/gaia/node_modules/mocha/lib/runner.js:258:10) 07:38:05 INFO - at Immediate._onImmediate (/home/worker/gaia/node_modules/mocha/lib/runner.js:275:5) 07:38:05 INFO - at processImmediate [as _immediateCallback] (timers.js:383:17) 07:38:05 INFO - TEST-END | apps/sms/test/marionette/message_received_test.js | Incoming messages tests Flash message received Flash message is displayed correctly took 25030 ms 07:38:05 INFO - Exit code 1
See Also: → 1227425
Hey folks, as you're the module owners/peers for this module, could you please urgently glance at this bug? I'm hiding this failing chunk at the moment so you can investigate further.
Flags: needinfo?(schung)
Flags: needinfo?(felash)
Flags: needinfo?(azasypkin)
I can't reproduce locally, even slowing down my computer. Oleg, maybe you'll have more luck with your slow vagrant setup ?
Flags: needinfo?(felash)
Note I'm very open to disabling this test only just to be able to reenable the full file.
Yes, let's disable this test instead, Gij 16 is quite important, I'll try to figure out what is happening. (In reply to Julien Wajsberg [:julienw] from comment #2) > I can't reproduce locally, even slowing down my computer. > Have you tried Mulet from the Treeherder itself?
Mmm no but I tried with latest one from m-c.
I have more help to narrow this down. Try m-i tip. I have a feeling I know when we started to fail here.
https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&fromchange=e7bb0b869016&filter-searchStr=ce1c819f6e0e23c7c3f0d508b0af94777447c3a6&exclusion_profile=false&selectedJob=17742041 This test seems unhappy with this change. I suspect you guys need to make a call on what needs to be done here, re-land the patch that was backed out which gives more performance or fix the test and have that merged around. https://hg.mozilla.org/integration/mozilla-inbound/rev/5d0bf692472248d6dedd790e17a223e855114e17
See Also: → 1059014
It seems fine after removing pausing and resuming painting. No quite sure if there's any corresponding action we should take after pausing/resuming painting relanded. We might need some discussion offline.
Flags: needinfo?(schung)
See Also: → 1212321
So yeah, the failure is reproducible with the Mulet from Treeherder. See how weird app launch looks like there: https://www.youtube.com/watch?v=4Gy_el4GwNM&feature=youtu.be From the Messages code point of view - everything is done correctly, but app.launch seems to be broken. I guess Julien and Vivien has already found out the reason.
Flags: needinfo?(azasypkin)
So what you show in the video is something that Vivien saw also with this patch, when launching the Settings app from the Quicksettings panel (in the Utility tray). Now I also think there is something to fix on our side. We rely on "transitionend" events in dialog.js but they're not always sent when the app is in background. See for example my testcase in [1]: when the tab is in background we don't get the "transitionend" events... So I think we could add a setTimeout fallback in dialog.js. [1] https://everlong.org/mozilla/testcase-animation.html
see also /shared/js/event_safety.js we could use?
Or migrate to a common web component for the dialog.
Mentor: felash
Whiteboard: [lang=js]
Comment on attachment 8693356 [details] [review] [gaia] KevinGrandon:bug_1227424_sms_dialog_use_event_safety > mozilla-b2g:master Julien, I didn't run any massive test runs on this or anything, but it seems like a simple enough fix. Have time for a review?
Attachment #8693356 - Flags: review?(felash)
Comment on attachment 8693356 [details] [review] [gaia] KevinGrandon:bug_1227424_sms_dialog_use_event_safety > mozilla-b2g:master Hey Kevin, thanks a lot for your patch ! I left comments on the PR. Ideally I'd prefer to migrate to the web component gaia-dialog because we'll have to do it eventually and I think (hope ?) that it has the same timeout. But if you prefer to finish with this approach I'm fine with this too. Please add your changes in a separate commit and request a new review once you're ready !
Attachment #8693356 - Flags: review?(felash)
Comment on attachment 8693356 [details] [review] [gaia] KevinGrandon:bug_1227424_sms_dialog_use_event_safety > mozilla-b2g:master > I left comments on the PR. Ideally I'd prefer to migrate to the web component gaia-dialog because we'll have to do it eventually and I think (hope ?) that it has the same timeout. Ok, let's switch to a component! I'll give it a shot when I have time.
Attachment #8693356 - Attachment is obsolete: true
Giving this bug the right name :) See [1] for fxos-dialog details. [1] https://github.com/fxos-components/fxos-dialog
Keywords: intermittent-failure → papercut
Summary: Intermittent apps/sms/test/marionette/message_received_test.js | Incoming messages tests Flash message received Flash message is displayed correctly → [Messages] Replace custom made dialogs with fxos-dialog web component
Mass closing of Gaia::SMS bugs. End of an era :(
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → WONTFIX
Mass closing of Gaia::SMS bugs. End of an era :(
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: