If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Multiselect parameters (type 'm') are not read correctly from the new JSON storage format

RESOLVED FIXED in Bugzilla 5.0

Status

()

Bugzilla
Administration
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: Pami Ketolainen, Assigned: Pami Ketolainen)

Tracking

Bugzilla 5.0
Bug Flags:
approval5.0 +

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
Created attachment 8691308 [details] [diff] [review]
fix-m-param.diff

When the params are read from the JSON file, it uses trick_taint on the values. In case of multiselect parameters, the value is stored as an array in the JSON and when trick_taint is used on the array reference it turns into string "ARRAY(...)".

Attached is a patch, which fixes the reading of multiselect parameters.
It also fixes the check_multi function in Bugzilla/Config/Common.pm, which I think has not worked with multiselect parameters even before Bugzilla 5.0 and introduction of the JSON storage format.
Attachment #8691308 - Flags: review?(dkl)
Comment on attachment 8691308 [details] [diff] [review]
fix-m-param.diff

Review of attachment 8691308 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. r=dkl
Attachment #8691308 - Flags: review?(dkl) → review+

Updated

2 years ago
Flags: approval5.0+

Updated

2 years ago
Assignee: administration → pami.ketolainen

Updated

2 years ago
Target Milestone: --- → Bugzilla 5.0
To ssh://gitolite3@git.mozilla.org/bugzilla/bugzilla.git
   24a6c0e..7027d79  master -> master

To ssh://gitolite3@git.mozilla.org/bugzilla/bugzilla.git
   a42b958..3dbd99b  5.0 -> 5.0
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.