Closed
Bug 1227455
Opened 9 years ago
Closed 9 years ago
Multiselect parameters (type 'm') are not read correctly from the new JSON storage format
Categories
(Bugzilla :: Administration, task)
Tracking
()
RESOLVED
FIXED
Bugzilla 5.0
People
(Reporter: pami.ketolainen, Assigned: pami.ketolainen)
Details
Attachments
(1 file)
|
1.32 KB,
patch
|
dkl
:
review+
|
Details | Diff | Splinter Review |
When the params are read from the JSON file, it uses trick_taint on the values. In case of multiselect parameters, the value is stored as an array in the JSON and when trick_taint is used on the array reference it turns into string "ARRAY(...)".
Attached is a patch, which fixes the reading of multiselect parameters.
It also fixes the check_multi function in Bugzilla/Config/Common.pm, which I think has not worked with multiselect parameters even before Bugzilla 5.0 and introduction of the JSON storage format.
Attachment #8691308 -
Flags: review?(dkl)
|
||
Comment 1•9 years ago
|
||
Comment on attachment 8691308 [details] [diff] [review]
fix-m-param.diff
Review of attachment 8691308 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good. r=dkl
Attachment #8691308 -
Flags: review?(dkl) → review+
|
|
||
Updated•9 years ago
|
Flags: approval5.0+
|
|
||
Updated•9 years ago
|
Assignee: administration → pami.ketolainen
|
||
Updated•9 years ago
|
Target Milestone: --- → Bugzilla 5.0
|
|
||
Comment 2•9 years ago
|
||
To ssh://gitolite3@git.mozilla.org/bugzilla/bugzilla.git
24a6c0e..7027d79 master -> master
To ssh://gitolite3@git.mozilla.org/bugzilla/bugzilla.git
a42b958..3dbd99b 5.0 -> 5.0
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•