Closed Bug 1227560 Opened 9 years ago Closed 8 years ago

[Static Analysis][Uninitialized argument value] In function m_pulldown from netwerk/sctp/src/user_mbuf.c can cause to variable o->m_data

Categories

(Core :: Networking, defect)

Product:
Core
Component:
Networking
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED WONTFIX
Tracking Flags:
Tracking Status
firefox45 --- affected

People

(Reporter: andi, Assigned: andi)

References

(Blocks 1 open bug)

Details

(Keywords: clang-analyzer)

Attachments

(1 file)

Bug 1227560 .diff
992 bytes, patch
Details | Diff | Splinter Review 
The Static Analysis tool Scan-Build added that variable o->m_data can be uninitialized when used in context: 

m_copydata(n->m_next, 0, tlen, mtod(o, caddr_t) + o->m_len);

This can be fixed my adding a memset with 0 in function m_get right after the memory for this variable is allocated:

	mret = SCTP_ZONE_GET(zone_mbuf, struct mbuf);
	memset(mret, 0, sizeof(struct mbuf));

    
    

    
  
we import that library.. please report upstream
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → WONTFIX

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: