Closed Bug 1227570 Opened 9 years ago Closed 8 years ago

Remove support of the --installer command line option

Categories

(Testing :: Firefox UI Tests, defect)

45 Branch
defect
Not set
normal

Tracking

(firefox43 fixed, firefox44 fixed, firefox45 fixed, firefox-esr38 wontfix)

RESOLVED FIXED
mozilla45
Tracking Status
firefox43 --- fixed
firefox44 --- fixed
firefox45 --- fixed
firefox-esr38 --- wontfix

People

(Reporter: whimboo, Assigned: whimboo)

References

Details

Attachments

(2 files)

To be in sync with Marionette proper we want to get rid of the --installer option for our firefox-ui-tests. That means consumers have to take care of installing and uninstalling Firefox, and passing the path to the binary.
Depends on: 1227571
This has to wait until bug 1227571 is fixed.
Whiteboard: [blocked by bug 1227571]
Attached file Patch v1
Attachment #8692510 - Flags: review?(mjzffr)
The patch for bug 1227571 (mozharness) will land soon on mozilla-central. So its no longer a real blocker for this patch. But we definitely have to wait with that removal until mozharness is used on production.
Whiteboard: [blocked by bug 1227571] → [don't land until mozharness is used on mozmill-ci production]
mozharness is on production now and works perfectly. That means I will land this patch later today.
Whiteboard: [don't land until mozharness is used on mozmill-ci production]
Merged the PR to mozilla-central:
https://github.com/mozilla/firefox-ui-tests/commit/0121c2a7d4fd3cf914b3e031a6b69145e5fe9ace

In case we need other things to fix across branches it would be good to get this backported.
Target Milestone: --- → Firefox 45
It turned out yesterday while merging the branches for the new Firefox 43.0 release, this change will cause us a bit of pain for branches as beta, and release. It will require a significant change in the Travis CI configuration to not run other locales for tinderbox builds (which wont exist). Maybe we should revert the build type to candidate again and let the tests fail until the first real build will be available for version N+1. That means an easy cherry-pick is not possible.
Cherry-picked patch with updates for the mozilla-beta branch. Possible Travis failures are not related to those changes and most likely occur due to ui changes in Aurora and will be fixed with the next beta release.
Attachment #8698479 - Flags: review?(mjzffr)
Comment on attachment 8698479 [details] [review]
Github PR (beta branch)

r+wc: looks good assuming the eventual Travis run actually passes.
Attachment #8698479 - Flags: review?(mjzffr) → review+
Merged PR to mozilla-beta:

https://github.com/mozilla/firefox-ui-tests/commit/2ea977168113a137c7ae342d46ce87c7865ff5a8

Will backport to release if next beta tests will succeed.
Tests for todays beta were fine. So I finally backported the changeset to mozilla-release:

https://github.com/mozilla/firefox-ui-tests/commit/e60b9711d4ff69dc72558e3afeba57978ce51cd1

As mentioned earlier we shouldn't need this patch for esr38. If it is totally necessary due to unforeseen reasons I will reopen the bug.
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Product: Mozilla QA → Testing
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: