Closed Bug 1227579 Opened 4 years ago Closed 4 years ago

Switch about:healthreport over to Unified Telemetry for Firefox 43+

Categories

(Toolkit :: Telemetry, defect, P1)

defect
Points:
1

Tracking

()

RESOLVED FIXED
mozilla45
Tracking Status
firefox43 + verified
firefox44 + verified
firefox45 + fixed

People

(Reporter: gfritzsche, Assigned: gfritzsche)

References

Details

(Whiteboard: [measurement:client])

Attachments

(1 file)

We conservatively only disabled data upload for v2 / old FHR for Firefox 43+, which means that we don't automatically switch over to the v4/Telemetry backed about:healthreport.

We need to switch over to the new version for privacy & other reasons.
[Tracking Requested - why for this release]:
This needs to happen for privacy & user transparency reasons.
The only open dependencies here are bug 1220110 & bug 1220119, but they minor, server-side (part of the remote content) and already submitted for review (https://github.com/mozilla/fhr-jelly/pull/176).

L10n is not blocking landing the client changes here.
Attachment #8691460 - Flags: review?(alessio.placitelli) → review+
Flags: qe-verify+
QA Contact: alexandra.lucinet
Comment on attachment 8691460 [details] [diff] [review]
Flip the main about:healthreport URL to the v4 content

Approval Request Comment
[Feature/regressing bug #]: Unified Telemetry & about:healthreport
[User impact if declined]: about:healthreport shows the wrong data on 43+
[Describe test coverage new/current, TreeHerder]: Automated coverage for backing system, repeated manual QA coverage over different scenarios, bug 1217341 was the last extensive verification for the new content.
[Risks and why]: Low-risk, this just points about:healthreport to the updated content for v4 / Unified Telemetry, which was already verified.
[String/UUID change made/needed]: None.

More background:
The current content under the new URL is a (risk-free) copy of the old (v2) content.
Bug 1227619 will bring the new (v4) content to the production server.
After that, the v4 content will be powered by Telemetry - bug 1217341 already verified that this works properly.
Attachment #8691460 - Flags: approval-mozilla-beta?
Attachment #8691460 - Flags: approval-mozilla-aurora?
Tracking for 43+ since we want to aim this feature change at 43 release.
Georg, I was reviewing the patch and the pref value looks interesting bcuz of locale and v4 in it. Is this a pref that Firefox users can change? or is this a UT server-side pref setting?
Flags: needinfo?(gfritzsche)
(In reply to Ritu Kothari (:ritu) from comment #7)
> Georg, I was reviewing the patch and the pref value looks interesting bcuz
> of locale and v4 in it. Is this a pref that Firefox users can change? or is
> this a UT server-side pref setting?

The %LOCALE% part is substituted with the users locale (e.g. "en-US", "de", ...).
The v4 part is to point it to the new contents - we have to keep the old (v2) contents around to serve existing clients.
Flags: needinfo?(gfritzsche)
Comment on attachment 8691460 [details] [diff] [review]
Flip the main about:healthreport URL to the v4 content

Please uplift this pref flip; part of unified telemetry feature.
Attachment #8691460 - Flags: approval-mozilla-beta?
Attachment #8691460 - Flags: approval-mozilla-beta+
Attachment #8691460 - Flags: approval-mozilla-aurora?
Attachment #8691460 - Flags: approval-mozilla-aurora+
Georg and Adalucinet, please verify this once it lands on beta, sounds like this is pretty crucial to have in place for 43 release. It should be in beta 7 which builds tomorrow and will release on Friday.
(In reply to Georg Fritzsche [:gfritzsche] from comment #8)
> (In reply to Ritu Kothari (:ritu) from comment #7)
> > Georg, I was reviewing the patch and the pref value looks interesting bcuz
> > of locale and v4 in it. Is this a pref that Firefox users can change? or is
> > this a UT server-side pref setting?
> 
> The %LOCALE% part is substituted with the users locale (e.g. "en-US", "de",
> ...).
> The v4 part is to point it to the new contents - we have to keep the old
> (v2) contents around to serve existing clients.

Thanks Georg! So:
1. What happens a few releases down the line? Will the pref value not need V#s in it? Will this be sometime when 47 goes live?
2. What if a FF43 user changes v4 to v2?
3. Are all the data quality issues addressed that made us disable this for FF41 and give it on only for 5% users? I am assuming with this patch UT is enabled for all 43 users. Or am I mistaken?
Flags: needinfo?(gfritzsche)
UT was enabled for all 42 users. The URL is not likely to change in the future (at least any time soon). And it's not exposed to users, so we don't need to worry about them changing it. If they did via about:config, the page would work but not display the data we're actually sending.
Flags: needinfo?(gfritzsche)
https://hg.mozilla.org/mozilla-central/rev/9680aa9b2aeb
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
Verified with 43.0b8 (Build ID: 20151201152349), across platforms [1], that:
- 'datareporting.healthreport.about.reportUrl' pref has 'https://fhr.cdn.mozilla.net/%LOCALE%/v4/' value and about:healthreport displays the correct content 
- 'datareporting.policy.dataSubmissionEnabled.v2' pref is set to false by default
- all the v4 pings are correctly generated

Let me know if anything else needs to be covered here.

[1] Windows 7 64-bit, Ubuntu 14.04 32-bit and Mac OS X 10.11
Verified fixed also with 44.0b2 (Build ID: 20151221151411), across platforms [1]. 

[1] Windows 7 64-bit, Mac OS X 10.11 and Ubuntu 12.04 32-bit
You need to log in before you can comment on or make changes to this bug.