1227599 - Scrubber in video controls is wonky

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Audio/Video, defect)

Description

[James Willcox (:snorp) ([e-mail]) (he/him)]

Attachment: scrubber-problem.png

It has a box around it.

Comment 1

[Flaviu Cos]

Inbound regression window:
last good build: f23ae6d4207719a808b285f0eb0504145b37d709
first bad build: 474012a19e10b189cb6a4521346787fdb44f49e3

pushlog:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=f23ae6d4207719a808b285f0eb0504145b37d709&tochange=474012a19e10b189cb6a4521346787fdb44f49e3

Comment 2

[Kartikaya Gupta (email:[e-mail])]

I suppose I should look at this.

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Apparently the scrubber is a xul|thumb so my change at https://hg.mozilla.org/integration/mozilla-inbound/rev/b5d654090848#l2.105 made it pick up that styling, which gave it a background color. I'll change it back to xul|scrollbar xul|thumb so it doesn't affect non-scrollbar thumbs.

Comment 4

[Kartikaya Gupta (email:[e-mail])]

Attachment: Patch

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/ffa22f766857

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

I had to back this out for android assertions like https://treeherder.mozilla.org/logviewer.html#?job_id=6568946&repo=fx-team
https://hg.mozilla.org/integration/fx-team/rev/efb769687f96

Comment 7

[Timothy Nikkel (:tnikkel)]

Digging into the log these are:

###!!! ASSERTION: Scroll area should be inside client rect: 'r.width >= 0', file /builds/slave/fx-team-and-api-11-d-000000000/build/src/layout/generic/nsGfxScrollFrame.cpp, line 5071
###!!! ASSERTION: Scroll area should be inside client rect: 'r.height >= 0', file /builds/slave/fx-team-and-api-11-d-000000000/build/src/layout/generic/nsGfxScrollFrame.cpp, line 5079

Comment 8

[Kartikaya Gupta (email:[e-mail])]

The assertions came from the other patch in the push (bug 1238239) so I'm relanding this.

Comment 9

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/23c3a6a25a54

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/23c3a6a25a54

Comment 11

[Flaviu Cos]

Verified as fixed in 46.0a1 2016-01-15;
Device: Asus Zenpad 8 (Android 5.0.2).

Comment 12

[Liz Henry (:lizzard) (relman/hg->git project)]

Tracking for 45+ since this is a recent regression. 
kats would you like to request aurora uplift?

Comment 13

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8706629 [details] [diff] [review]
Patch

Approval Request Comment
[Feature/regressing bug #]: bug 1223928
[User impact if declined]: the scrubber used to navigate through a video timeline has a border around it, which shouldn't be there
[Describe test coverage new/current, TreeHerder]: tested locally
[Risks and why]: very low risk, it was an accidental change to the CSS that caused it
[String/UUID change made/needed]: none

Comment 14

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/fdefd1d82a09

Comment 15

[Teodora Vermesan (:TeoVermesan)]

Verified as fixed on:
Device: Nexus 6 (Android 6.0)
Build: Firefox for Android 45.0a2 (2016-01-25)