1227796 - Intermittent screen_lock_settings_test.js | manipulate screenLock settings passcode is enabled and won't get disabled if you tap back button when we try to disable passcode directly

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://treeherder.mozilla.org/logviewer.html#?job_id=3432204&repo=b2g-inbound

Comment 1

[Intermittent Failures Robot]

6 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-inbound: 3
* b2g-inbound: 2
* fx-team: 1

Platform breakdown:
* mulet-linux64: 5
* b2g-linux64: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1227796&startday=2015-11-30&endday=2015-12-06&tree=all

Comment 2

[Michael Henretty [:mikehenrty][:mhenretty]]

I'm seeing this happen more [1] when we disable the retry logic in bug 1222215. I'm going to disable this test for now.

https://treeherder.mozilla.org/logviewer.html#?job_id=3173489&repo=gaia

Comment 3

[Michael Henretty [:mikehenrty][:mhenretty]]

disabled in master: https://github.com/mozilla-b2g/gaia/commit/9ad93b64489bc962f1d819bd414f440ad2d453d1

Comment 4

[GitHub Autolander Bot]

Attachment: [gaia] gasolin:issue-1227796 > mozilla-b2g:master

Comment 5

[[e-mail]]

Comment on attachment 8707734 [details] [review]
[gaia] gasolin:issue-1227796 > mozilla-b2g:master

re-enable screen_lock_settings_test.js by fixing isScreenLockChecked/isPasscodeChecked with new syntax

Comment 6

[Scott Wu [:scottwu]]

Comment on attachment 8707734 [details] [review]
[gaia] gasolin:issue-1227796 > mozilla-b2g:master

One test is giving me intermittent error on my local machine (please see my comment on github), but looks fine on Treeherder, not sure if it's just me. Otherwise looks good. Thanks!

Comment 7

[[e-mail]]

Thanks for review. I skip that test case and rebased to pass treeherder

merged https://github.com/mozilla-b2g/gaia/commit/f75c57cb6bdc315df2516553018342a084ff9487