1227816 - [TV] The default highlight button on browser FTE is incorrect

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::TV, defect, P2)

Description

[Alison Shiue]

STR:
1. First time launch browser
2. Check the FTE highlight button

Expected result:
1. Should be "Sign in"

Actual result:
1. "Skip" button is highlighted


Build info:
Build ID               20151121125805
Gaia Revision          e63c07af8cc636b9ffac2c20f9b8ad7e7fe2b977
Gaia Date              2015-11-24 03:47:05
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/abbd213422a560f1180c4ec6e3bf4792c2ea81ba
Gecko Version          45.0a1
Device Name            hammerhead
Firmware(Release)      5.1
Firmware(Incremental)  eng.worker.20151121.121712
Firmware Date          Sat Nov 21 12:17:28 UTC 2015
Bootloader             HHZ12f

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] begeeben:1227816_the_default_highlight > mozilla-b2g:master

Comment 2

[yifan [:yifan][:yliao]]

Comment on attachment 8691853 [details] [review]
[gaia] begeeben:1227816_the_default_highlight > mozilla-b2g:master

Default focus on the finish button in FTEWizard.

Comment 3

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Comment on attachment 8691853 [details] [review]
[gaia] begeeben:1227816_the_default_highlight > mozilla-b2g:master

r=me
I found some bugs on ftewizard though. I'll open some additional bug to refactor it.

Comment 4

[yifan [:yifan][:yliao]]

Merged into master:
https://github.com/mozilla-b2g/gaia/commit/10798fe53a31cef72800780e960a671a33afe466

Comment 5

[yifan [:yifan][:yliao]]

Comment on attachment 8691853 [details] [review]
[gaia] begeeben:1227816_the_default_highlight > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): 1194108
[User impact] if declined: Bad user experience
[Testing completed]: https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=6f3b1e44f1f6875598ce73ca538832ed9cb31d10
[Risk to taking this patch] (and alternatives if risky): none
[String changes made]: none

Comment 6

[Josh Cheng [:josh]]

Comment on attachment 8691853 [details] [review]
[gaia] begeeben:1227816_the_default_highlight > mozilla-b2g:master

Approve for TV FTU 2.5

Comment 7

[Carsten Book [:Tomcat]]

has problems during uplift Tomcats-MacBook-Pro-2:gaia Tomcat$ git cherry-pick 6f3b1e44f1f6875598ce73ca538832ed9cb31d10
error: could not apply 6f3b1e4... Bug 1227816 - [TV] The default highlight button on browser FTE is incorrect
hint: after resolving the conflicts, mark the corrected paths
hint: with 'git add <paths>' or 'git rm <paths>'
hint: and commit the result with 'git commit'

Comment 8

[yifan [:yifan][:yliao]]

This bug depends on bug 1220581 . The reason this uplift failed is because the uplift in bug 1220581 seems to be incorrect.

Comment 9

[Carsten Book [:Tomcat]]

https://github.com/mozilla-b2g/gaia/commit/e05621cbfd92b3fb4e5aef86621c57cd68fb0414 for 2.5

Comment 10

[Rid Pan]

Verify this issue on the latest build.
Launch Browser at the first time and the "Sign in" button is highlighted.
[Build Info]
Environment: 2.6 Simulator
gaia:
https://github.com/mozilla-b2g/gaia/commit/d9faad5c0f14fcd42f920c9104f0638f46a48b2a
gecko:
https://hg.mozilla.org/mozilla-central/rev/789a12291942763bc1e3a89f97e0b82dc1c9d00b