1227989 - Using text-link in a modal dialog causes multiple tabs to appears after dialog is closed

Status: NEW

(Toolkit :: UI Widgets, defect)

Description

[Mike Kaply [:mkaply]]

If you have a text-link in a modal dialog, when you click it once, you see the page appear behind the dialog. If you click it again, you see the page behind the dialog update. If you keep clicking, you'll see the page continue to update.

If you then close the dialog, you'll have tabs opened up for every click that you made.

To recreate, switch the scratchpad to browser and enter this:

window.open("chrome://browser/content/aboutDialog.xul", "foo", "modal");

And click the privacy link in the resulting dialog.

Comment 1

[Mike Kaply [:mkaply]]

Surprisingly, this is a regression.

Comment 2

[Mike Kaply [:mkaply]]

Having trouble finding a regression window. It definitely happens in 42, and definitely happens in the latest nightly.

When I try mozregression, it works in every build. I tried turning off e10s, but that had no effect. I'm at a loss. Still researching.

Comment 3

[YF (Yang)]

https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=6300571e5c682ee23b9392a8c1f7a87f80785ea2&tochange=ed8a6af1508ac68a28d017e26935e7a12dbda864

Comment 4

[Paul Pasca[Away. Please needinfo? Paul Oiegas [:pauloiegasSV]]]

User Agent: 
Build ID: 

I have tested your issue on latest FF release (45.0.2), latest Nightly build (20160421030302) and managed to reproduce it. In order to switch the scratchpad to browser, "Enable browser chrome and odd-on debugging toolboxes" needs to be checked. After that, open scratchpad and select browser from the "Environment" menu. Following the steps from comment 0 reproduces the issue.

Comment 5

[Julian Descottes [:jdescottes]]

Scratchpad is just mentioned as a way to reproduce the issue, but it's not really related to the actual problem.

I'm not sure which component this should go to, probably DOM or Canvas2D considering the bugs mentioned in the regression window.

Comment 6

[Emil Pasca [:emilpasca]]

User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Firefox/52.0

I have tested this issue on Windows 10 x64 with the latest Firefox release (53.0.3) and the latest Nightly (55.0a1-20170521030205) and managed to reproduce it.
After opening the "About Nightly" dialog window, or running the code provided in the description, in Scratchpad, when clicking the privacy link, the page appears behind the dialog.
The issue is not reproducible on Nightly(20.0a1-20121214030827).

Tested on older builds and managed to perform a regression, the result as follows:
Last good revision: b11065872128 (2012-12-14)
First bad revision: 5ea1c76e4bb3 (2012-12-15)
Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=b11065872128&tochange=5ea1c76e4bb3

However, it seems that this is the intended behavior as how has been discussed in bug 263433.

Comment 7

[Mike Kaply [:mkaply]]

I don't think this was the intended behavior. There's a modal dialog reference and I don't think they realized it would break modal windows.

Comment 8

[Worcester12345]

(In reply to Mike Kaply [:mkaply] from comment #7)
> I don't think this was the intended behavior. There's a modal dialog
> reference and I don't think they realized it would break modal windows.

Should bug 263433 be reopened based on this information?

Comment 9

[Mike Kaply [:mkaply]]

> Should bug 263433 be reopened based on this information?

No, we don't typically reopen bugs. We mark them as blockers (which I did).

Comment 10

[Worcester12345]

(In reply to Mike Kaply [:mkaply] from comment #9)
> > Should bug 263433 be reopened based on this information?
> 
> No, we don't typically reopen bugs. We mark them as blockers (which I did).

You're kidding. I bet the numbers of reopened bugs is into the tens of thousands, if not more, unless this is a new thing.