Closed Bug 122800 Opened 23 years ago Closed 22 years ago

We could not render plane 1 character correctly in right-to-left string

Categories

(Core :: Layout: Text and Fonts, defect)

Product:
Core
Component:
Layout: Text and Fonts
Platform:
x86
Windows NT
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: shanjian, Assigned: smontagu)

References

(
URL
)

Details

Attachments

(2 files, 1 obsolete file)

test case for soon-to-come fix!
5.21 KB, text/html
Details
Updated patch
3.13 KB, patch
mkaply
: review+
darin.moz
: superreview+
Details | Diff | Splinter Review
This is a leftover of bug 118000. After bug 119983 was resolved, plane 1 character in the right-to-left string is still displayed as '?'. How do we render right-to-left string? I once heard from ftang that we render right-to-left string character by character. If that is the case, that is the problem. We need to group a surrogate pair together.
The code to reverse strings takes surrogate pairs into account, but maybe there is a problem with it. I'll look at it in a debugger.
Attached patch fix (obsolete) — — Splinter Review
The problem was in nsIUBidiUtils::SymmSwap, which wasn't 32-bit aware and was stripping the high word.
ftang, can you review the patch?
Status: NEW → ASSIGNED
Hello? Any progress on this bug? Was just about to file a dupe...
Yes, let's get this in. I'll check that the patch hasn't rotted and rerequest reviews.
Attached patch Updated patch — — Splinter Review
Attachment #67309 - Attachment is obsolete: true
Comment on attachment 106947 [details] [diff] [review] Updated patch I know that correct support for Etruscan is not a high priority, but I don't like being broken on prominent Unicode sample pages.
Attachment #106947 - Flags: review?(mkaply)
It is in those small details that the Master Browser will differ from the inferior ones...
Btw, I hope the patch covers all platforms. Bug is certainly also present on Mac OS X.
This patch should be totally cross platform. If the left-to-right texts currently display correctly on OS X, then the right-to-left texts should display correctly after this is checked in.
Comment on attachment 106947 [details] [diff] [review] Updated patch r=mkaply
Attachment #106947 - Flags: review?(mkaply) → review+
Attachment #106947 - Flags: superreview?(darin)
Comment on attachment 106947 [details] [diff] [review] Updated patch sr=darin
Attachment #106947 - Flags: superreview?(darin) → superreview+
Fix checked in.
Status: ASSIGNED → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
Component: Layout: BiDi Hebrew & Arabic → Layout: Text
QA Contact: zach → layout.fonts-and-text
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: