Closed Bug 1228053 Opened 10 years ago Closed 10 years ago

syncThenable pretends to be Promise but doesn't implement catch()

Categories

(Hello (Loop) :: Client, defect)

Product:
Hello (Loop)
Component:
Client
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox45 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla45
Tracking Flags:
Tracking Status
firefox45 --- fixed

People

(Reporter: bzbarsky, Assigned: bzbarsky)

References

Details

Attachments

(1 file)

syncThenable in loop test code should have catch(), since some of the tests assume that Promise instances have a catch() method
1.04 KB, patch
mikedeboer
: review+
Details | Diff | Splinter Review
And some of the tests use that, apparently.
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED
Comment on attachment 8692087 [details] [diff] [review] syncThenable in loop test code should have catch(), since some of the tests assume that Promise instances have a catch() method Review of attachment 8692087 [details] [diff] [review]: ----------------------------------------------------------------- Change discussed over IRC. Thanks!
Attachment #8692087 - Flags: review?(mdeboer) → review+
https://hg.mozilla.org/mozilla-central/rev/622f372d220c
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
status-firefox45: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: