1228089 - Detect if the user has a URL in their clipboard when re-entering the app

Status: RESOLVED FIXED

(Firefox for iOS :: General, defect)

Description

[Stephan Leroux [:sleroux]]

Whenever the app enters the foreground, we need to check the UIPasteboard to see if there a link in the user's clipboard. If there is a URL, we will show the open url toast that will be built as part of https://bugzilla.mozilla.org/show_bug.cgi?id=1228087. For now, let's just print to the console whenever a URL is detected.

Comment 1

[Bryan Munar (:bkmunar)]

Attachment: PR - some questions in the PR

Comment 2

[Stephan Leroux [:sleroux]]

Comment on attachment 8712871 [details] [review]
PR - some questions in the PR

Left some answers on the PR!

Comment 3

[Stephan Leroux [:sleroux]]

Left a couple of comments on the PR. I think it will make more sense to combine this patch with the snack bar view patch since this patch doesn't actually add any functionality - just debug logging.

Comment 4

[Stephan Leroux [:sleroux]]

Comment on attachment 8712871 [details] [review]
PR - some questions in the PR

Clearing r? until patch is revised.

Comment 5

[Rawi]

Attachment: Pull request

Comment 6

[Emily Toop (:fluffyemily)]

Comment on attachment 8760327 [details] [review]
Pull request

Hey. You've deleted some files from another package as part of this patch, which I think must have been a mistake. Could you please update the patch to leave the file deletions out?

Thanks

Comment 7

[Emily Toop (:fluffyemily)]

Comment on attachment 8760327 [details] [review]
Pull request

LGTM. Thanks :rawisa 

Sorry it took me so long to get around to it. It got lost in my review queue.