1228090 - Update tracking protection telemetry probes

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Settings and Preferences, defect)

Description

[:Margaret Leibovic]

Right now we have two separate histograms, one for whether the global pref is set, and one for whether the pb-only pref is set. We should combine this into a single histogram that gives us a better picture of what's going on.

Also, we shouldn't keep this Nightly-only:
mxr.mozilla.org/mozilla-central/source/mobile/android/chrome/content/browser.js#594

Comment 1

[Elvin Lee [:ellee] (no longer with Mozilla)]

If there's a way to coordinate the probe redesign with Desktop that'd be useful too!

Comment 2

[:Margaret Leibovic]

Attachment: MozReview Request: Bug 1228090 - Update traacking protection telemetry histogram to represent user setting. r=mfinkle

Review commit: https://reviewboard.mozilla.org/r/28581/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/28581/

Comment 3

[:Margaret Leibovic]

(In reply to Elvin Lee [:ellee] from comment #1)
> If there's a way to coordinate the probe redesign with Desktop that'd be
> useful too!

I decided to replace our use the current two probes with a new mobile-specific one.

We can coordinate with desktop for the metrics we're collecting, but I don't think that we should block on landing this simple fix right now.

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 8700117 [details]
MozReview Request: Bug 1228090 - Update traacking protection telemetry histogram to represent user setting. r=mfinkle

https://reviewboard.mozilla.org/r/28581/#review25417

LGTM

Comment 5

[:Margaret Leibovic]

Javaun, do you have any plans to update the tracking protection histogram probes on desktop?

If there might be a similar tri-state pref like we have on mobile in the future, I could drop the FENNEC_ bit from this histogram to make a more generic histogram that desktop could implement as well.

Comment 6

[Elvin Lee [:ellee] (no longer with Mozilla)]

Very exciting! How soon before it starts to show up in the dashboard? :)

Comment 7

[:Margaret Leibovic]

https://hg.mozilla.org/integration/fx-team/rev/08ebedc40550de69e2f18a0b2755505a3f06feb0
Bug 1228090 - Update traacking protection telemetry histogram to represent user setting. r=mfinkle

Comment 8

[:Margaret Leibovic]

(In reply to Elvin Lee [:ellee] from comment #6)
> Very exciting! How soon before it starts to show up in the dashboard? :)

I just landed it, so we should be able to get Nightly data soon (maybe in a week or so).

I can sync up with Javaun after the holidays to see if we should update the probe to align better with desktop.

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/08ebedc40550