Closed Bug 1228127 Opened 9 years ago Closed 7 years ago

[Skia canvas] GrAAConvexPathRenderer.cpp:110: failed assertion "!SkScalarIsNaN(c->fX) && !SkScalarIsNaN(c->fY)"

Categories

(Core :: Graphics, defect)

defect
Not set
critical

Tracking

()

RESOLVED WORKSFORME
Tracking Status
firefox45 --- affected

People

(Reporter: jruderman, Unassigned)

References

Details

(Keywords: assertion, testcase, Whiteboard: gfx-noted)

Attachments

(2 files)

Attached file testcase
gfx/skia/skia/src/gpu/GrAAConvexPathRenderer.cpp:110: failed assertion "!SkScalarIsNaN(c->fX) && !SkScalarIsNaN(c->fY)"
Attached file stack
Flags: needinfo?(lsalzman)
Whiteboard: gfx-noted
I investigated this, and it turns out that if you pass some really large numbers in that are not Infs, that deep in the bowels of Skia's GPU path code it will still end up with Infs resulting from certain operations. This particular case requires invasive changes to code that was remodeled in the latest Skia, though the underlying problem still remains and was not fixed by the update.

I'm going to mark this as dependent on the update and we can revisit whether/how to fix that after that has gone through.
Depends on: 1082598
Flags: needinfo?(lsalzman)
With the update, I get a different assertion failure:

gfx/skia/skia/include/core/SkStrokeRec.h:67: failed assertion "rs > 0 && SkScalarIsFinite(rs)"
This no longer reproduces on trunk.
Status: NEW → RESOLVED
Closed: 7 years ago
Flags: in-testsuite+
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: